From 4bd1ce19ebd49a291ba14c955e0b35b6a58d221b Mon Sep 17 00:00:00 2001
From: =?utf8?q?Per-=C3=85ke=20Minborg?= <minborg@speedment.com>
Date: Thu, 27 Oct 2016 22:28:51 -0700
Subject: [PATCH] Add private constructor for utility classes

Change-Id: I80b73b653e97904605dc62484a7448f3bfbf7210
---
 server/src/main/java/com/vaadin/data/util/BeanUtil.java     | 3 +++
 .../main/java/com/vaadin/data/validator/BeanValidator.java  | 3 +++
 .../main/java/com/vaadin/server/ComponentSizeValidator.java | 3 +++
 server/src/main/java/com/vaadin/server/JsonCodec.java       | 3 +++
 server/src/main/java/com/vaadin/server/LegacyPaint.java     | 3 +++
 .../main/java/com/vaadin/server/ServletPortletHelper.java   | 3 +++
 .../com/vaadin/server/VaadinServiceClassLoaderUtil.java     | 3 +++
 server/src/main/java/com/vaadin/ui/declarative/Design.java  | 3 +++
 .../com/vaadin/ui/declarative/DesignAttributeHandler.java   | 3 +++
 server/src/main/java/com/vaadin/ui/themes/ValoTheme.java    | 3 +++
 server/src/main/java/com/vaadin/util/ConnectorHelper.java   | 3 +++
 server/src/main/java/com/vaadin/util/FileTypeResolver.java  | 3 +++
 server/src/main/java/com/vaadin/util/ReflectTools.java      | 3 +++
 server/src/main/java/com/vaadin/util/SerializerHelper.java  | 3 +++
 server/src/test/java/com/vaadin/tests/util/TestUtil.java    | 3 +++
 server/src/test/java/com/vaadin/ui/ComponentTest.java       | 3 +++
 server/src/test/java/com/vaadin/ui/RichTextAreaTest.java    | 6 +++++-
 17 files changed, 53 insertions(+), 1 deletion(-)

diff --git a/server/src/main/java/com/vaadin/data/util/BeanUtil.java b/server/src/main/java/com/vaadin/data/util/BeanUtil.java
index 763e6ec4b1..6faef0ff89 100644
--- a/server/src/main/java/com/vaadin/data/util/BeanUtil.java
+++ b/server/src/main/java/com/vaadin/data/util/BeanUtil.java
@@ -239,5 +239,8 @@ public final class BeanUtil implements Serializable {
                 return false;
             }
         }
+
+        private LazyValidationAvailability() {
+        }
     }
 }
diff --git a/server/src/main/java/com/vaadin/data/validator/BeanValidator.java b/server/src/main/java/com/vaadin/data/validator/BeanValidator.java
index a3f9b86a6e..2734658f8f 100644
--- a/server/src/main/java/com/vaadin/data/validator/BeanValidator.java
+++ b/server/src/main/java/com/vaadin/data/validator/BeanValidator.java
@@ -189,5 +189,8 @@ public class BeanValidator implements Validator<Object> {
         private static ValidatorFactory getFactory() {
             return Validation.buildDefaultValidatorFactory();
         }
+
+        private LazyFactoryInitializer() {
+        }
     }
 }
diff --git a/server/src/main/java/com/vaadin/server/ComponentSizeValidator.java b/server/src/main/java/com/vaadin/server/ComponentSizeValidator.java
index fa3b269fae..54ab672589 100644
--- a/server/src/main/java/com/vaadin/server/ComponentSizeValidator.java
+++ b/server/src/main/java/com/vaadin/server/ComponentSizeValidator.java
@@ -731,4 +731,7 @@ public class ComponentSizeValidator implements Serializable {
 
     }
 
+    private ComponentSizeValidator() {
+    }
+
 }
diff --git a/server/src/main/java/com/vaadin/server/JsonCodec.java b/server/src/main/java/com/vaadin/server/JsonCodec.java
index adf3e029ee..588443d55b 100644
--- a/server/src/main/java/com/vaadin/server/JsonCodec.java
+++ b/server/src/main/java/com/vaadin/server/JsonCodec.java
@@ -993,4 +993,7 @@ public class JsonCodec implements Serializable {
         JSONSerializer serializer = customSerializers.get(value.getClass());
         return serializer.serialize(value, connectorTracker);
     }
+
+    private JsonCodec() {
+    }
 }
diff --git a/server/src/main/java/com/vaadin/server/LegacyPaint.java b/server/src/main/java/com/vaadin/server/LegacyPaint.java
index 471570c125..0a65c932ed 100644
--- a/server/src/main/java/com/vaadin/server/LegacyPaint.java
+++ b/server/src/main/java/com/vaadin/server/LegacyPaint.java
@@ -69,4 +69,7 @@ public class LegacyPaint implements Serializable {
 
     }
 
+    private LegacyPaint() {
+    }
+
 }
diff --git a/server/src/main/java/com/vaadin/server/ServletPortletHelper.java b/server/src/main/java/com/vaadin/server/ServletPortletHelper.java
index 1b9d87a455..5bd4c01427 100644
--- a/server/src/main/java/com/vaadin/server/ServletPortletHelper.java
+++ b/server/src/main/java/com/vaadin/server/ServletPortletHelper.java
@@ -251,4 +251,7 @@ public class ServletPortletHelper implements Serializable {
 
         return Locale.getDefault();
     }
+
+    private ServletPortletHelper() {
+    }
 }
diff --git a/server/src/main/java/com/vaadin/server/VaadinServiceClassLoaderUtil.java b/server/src/main/java/com/vaadin/server/VaadinServiceClassLoaderUtil.java
index 283b897087..b2241f5ba5 100644
--- a/server/src/main/java/com/vaadin/server/VaadinServiceClassLoaderUtil.java
+++ b/server/src/main/java/com/vaadin/server/VaadinServiceClassLoaderUtil.java
@@ -54,4 +54,7 @@ class VaadinServiceClassLoaderUtil {
                 new VaadinServiceClassLoaderUtil.GetClassLoaderPrivilegedAction());
     }
 
+    private VaadinServiceClassLoaderUtil() {
+    }
+
 }
diff --git a/server/src/main/java/com/vaadin/ui/declarative/Design.java b/server/src/main/java/com/vaadin/ui/declarative/Design.java
index 5298b0b1f9..8ac0ef41a8 100644
--- a/server/src/main/java/com/vaadin/ui/declarative/Design.java
+++ b/server/src/main/java/com/vaadin/ui/declarative/Design.java
@@ -773,4 +773,7 @@ public class Design implements Serializable {
         outputStream.write(doc.html().getBytes(UTF8));
     }
 
+    private Design() {
+    }
+
 }
diff --git a/server/src/main/java/com/vaadin/ui/declarative/DesignAttributeHandler.java b/server/src/main/java/com/vaadin/ui/declarative/DesignAttributeHandler.java
index 2eea59a046..44248d095b 100644
--- a/server/src/main/java/com/vaadin/ui/declarative/DesignAttributeHandler.java
+++ b/server/src/main/java/com/vaadin/ui/declarative/DesignAttributeHandler.java
@@ -508,4 +508,7 @@ public class DesignAttributeHandler implements Serializable {
         }
     }
 
+    private DesignAttributeHandler() {
+    }
+
 }
diff --git a/server/src/main/java/com/vaadin/ui/themes/ValoTheme.java b/server/src/main/java/com/vaadin/ui/themes/ValoTheme.java
index df9621bf27..48fad1ce95 100644
--- a/server/src/main/java/com/vaadin/ui/themes/ValoTheme.java
+++ b/server/src/main/java/com/vaadin/ui/themes/ValoTheme.java
@@ -1072,4 +1072,7 @@ public class ValoTheme {
      * </pre>
      */
     public static final String MENU_APPEAR_ON_HOVER = "valo-menu-hover";
+
+    private ValoTheme() {
+    }
 }
diff --git a/server/src/main/java/com/vaadin/util/ConnectorHelper.java b/server/src/main/java/com/vaadin/util/ConnectorHelper.java
index 5b5958175b..46b4ba4bf1 100644
--- a/server/src/main/java/com/vaadin/util/ConnectorHelper.java
+++ b/server/src/main/java/com/vaadin/util/ConnectorHelper.java
@@ -98,4 +98,7 @@ public class ConnectorHelper {
         }
     }
 
+    private ConnectorHelper() {
+    }
+
 }
diff --git a/server/src/main/java/com/vaadin/util/FileTypeResolver.java b/server/src/main/java/com/vaadin/util/FileTypeResolver.java
index 305bc1c5d7..da0d3df853 100644
--- a/server/src/main/java/com/vaadin/util/FileTypeResolver.java
+++ b/server/src/main/java/com/vaadin/util/FileTypeResolver.java
@@ -392,4 +392,7 @@ public class FileTypeResolver implements Serializable {
     public static Map<String, Resource> getMIMETypeToIconMapping() {
         return Collections.unmodifiableMap(MIMEToIconMap);
     }
+
+    private FileTypeResolver() {
+    }
 }
diff --git a/server/src/main/java/com/vaadin/util/ReflectTools.java b/server/src/main/java/com/vaadin/util/ReflectTools.java
index 1d37a4d1e1..bd1035dac5 100644
--- a/server/src/main/java/com/vaadin/util/ReflectTools.java
+++ b/server/src/main/java/com/vaadin/util/ReflectTools.java
@@ -213,4 +213,7 @@ public class ReflectTools implements Serializable {
         }
         return type;
     }
+
+    private ReflectTools() {
+    }
 }
diff --git a/server/src/main/java/com/vaadin/util/SerializerHelper.java b/server/src/main/java/com/vaadin/util/SerializerHelper.java
index 7ef09d9b43..5b6b06c0c1 100644
--- a/server/src/main/java/com/vaadin/util/SerializerHelper.java
+++ b/server/src/main/java/com/vaadin/util/SerializerHelper.java
@@ -154,4 +154,7 @@ public class SerializerHelper {
 
     }
 
+    private SerializerHelper() {
+    }
+
 }
diff --git a/server/src/test/java/com/vaadin/tests/util/TestUtil.java b/server/src/test/java/com/vaadin/tests/util/TestUtil.java
index c4a185647b..eb5bd5e525 100644
--- a/server/src/test/java/com/vaadin/tests/util/TestUtil.java
+++ b/server/src/test/java/com/vaadin/tests/util/TestUtil.java
@@ -43,4 +43,7 @@ public class TestUtil {
                             + " has no match in the first iterable.");
         }
     }
+
+    private TestUtil() {
+    }
 }
diff --git a/server/src/test/java/com/vaadin/ui/ComponentTest.java b/server/src/test/java/com/vaadin/ui/ComponentTest.java
index 09870b866b..c9ff9c7de4 100644
--- a/server/src/test/java/com/vaadin/ui/ComponentTest.java
+++ b/server/src/test/java/com/vaadin/ui/ComponentTest.java
@@ -116,4 +116,7 @@ public class ComponentTest {
                 new HashSet<>(Arrays.asList(encodeState.keys())));
     }
 
+    private ComponentTest() {
+    }
+
 }
diff --git a/server/src/test/java/com/vaadin/ui/RichTextAreaTest.java b/server/src/test/java/com/vaadin/ui/RichTextAreaTest.java
index 6a4fd32173..a18105b5bb 100644
--- a/server/src/test/java/com/vaadin/ui/RichTextAreaTest.java
+++ b/server/src/test/java/com/vaadin/ui/RichTextAreaTest.java
@@ -22,8 +22,12 @@ import com.vaadin.server.ClientConnector;
 import com.vaadin.server.ServerRpcManager.RpcInvocationException;
 import com.vaadin.shared.ui.richtextarea.RichTextAreaServerRpc;
 import com.vaadin.tests.util.MockUI;
+import static com.vaadin.ui.ComponentTest.getRpcProxy;
+import static com.vaadin.ui.ComponentTest.isDirty;
+import static com.vaadin.ui.ComponentTest.syncToClient;
+import static com.vaadin.ui.ComponentTest.updateDiffState;
 
-public class RichTextAreaTest extends ComponentTest {
+public class RichTextAreaTest  {
 
     @Test
     public void initiallyEmpty() {
-- 
2.39.5