From 4c3a69653fcc9293f62f7382d51303e2e7f55338 Mon Sep 17 00:00:00 2001 From: Julien Lancelot Date: Tue, 20 May 2014 19:28:18 +0200 Subject: [PATCH] Add missing session.close() in unit tests --- .../java/org/sonar/core/properties/PropertiesDaoTest.java | 6 ++++++ .../test/java/org/sonar/core/resource/ResourceDaoTest.java | 6 ++++++ .../server/component/persistence/ComponentDaoTest.java | 6 ++++++ 3 files changed, 18 insertions(+) diff --git a/sonar-core/src/test/java/org/sonar/core/properties/PropertiesDaoTest.java b/sonar-core/src/test/java/org/sonar/core/properties/PropertiesDaoTest.java index ce832311193..807bfec1775 100644 --- a/sonar-core/src/test/java/org/sonar/core/properties/PropertiesDaoTest.java +++ b/sonar-core/src/test/java/org/sonar/core/properties/PropertiesDaoTest.java @@ -20,6 +20,7 @@ package org.sonar.core.properties; import com.google.common.collect.ImmutableMap; +import org.junit.After; import org.junit.Before; import org.junit.Rule; import org.junit.Test; @@ -48,6 +49,11 @@ public class PropertiesDaoTest extends AbstractDaoTestCase { session = getMyBatis().openSession(false); } + @After + public void tearDown() throws Exception { + session.close(); + } + @Test public void shouldFindUsersForNotification() { setupData("shouldFindUsersForNotification"); diff --git a/sonar-core/src/test/java/org/sonar/core/resource/ResourceDaoTest.java b/sonar-core/src/test/java/org/sonar/core/resource/ResourceDaoTest.java index 36525add84e..41f3fa4c59b 100644 --- a/sonar-core/src/test/java/org/sonar/core/resource/ResourceDaoTest.java +++ b/sonar-core/src/test/java/org/sonar/core/resource/ResourceDaoTest.java @@ -22,6 +22,7 @@ package org.sonar.core.resource; import com.google.common.base.Function; import com.google.common.collect.Iterables; import org.apache.ibatis.session.SqlSession; +import org.junit.After; import org.junit.Before; import org.junit.Test; import org.sonar.api.component.Component; @@ -52,6 +53,11 @@ public class ResourceDaoTest extends AbstractDaoTestCase { dao = new ResourceDao(getMyBatis()); } + @After + public void tearDown() throws Exception { + session.close(); + } + @Test public void testDescendantProjects_do_not_include_self() { setupData("fixture"); diff --git a/sonar-server/src/test/java/org/sonar/server/component/persistence/ComponentDaoTest.java b/sonar-server/src/test/java/org/sonar/server/component/persistence/ComponentDaoTest.java index d482fd09776..6f72494cb4e 100644 --- a/sonar-server/src/test/java/org/sonar/server/component/persistence/ComponentDaoTest.java +++ b/sonar-server/src/test/java/org/sonar/server/component/persistence/ComponentDaoTest.java @@ -19,6 +19,7 @@ */ package org.sonar.server.component.persistence; +import org.junit.After; import org.junit.Before; import org.junit.Test; import org.sonar.api.resources.Qualifiers; @@ -41,6 +42,11 @@ public class ComponentDaoTest extends AbstractDaoTestCase { dao = new ComponentDao(); } + @After + public void tearDown() throws Exception { + session.close(); + } + @Test public void get_by_key() { setupData("shared"); -- 2.39.5