From 4de983c6d5eacbdc668c0b7280d9818dd6281a53 Mon Sep 17 00:00:00 2001 From: Thomas Meyer Date: Wed, 4 Sep 2013 23:20:45 +0200 Subject: [PATCH] Position: Add unit tests for bug 8710 Ref #8710 Closes gh-1071 --- tests/unit/position/position.html | 3 +++ tests/unit/position/position_core.js | 37 ++++++++++++++++++++++++++++ 2 files changed, 40 insertions(+) diff --git a/tests/unit/position/position.html b/tests/unit/position/position.html index 0cad7d322..334fbbb78 100644 --- a/tests/unit/position/position.html +++ b/tests/unit/position/position.html @@ -47,6 +47,9 @@ elements smaller than 20px have a line-height set on them to avoid a bug in IE6
+ +
+
diff --git a/tests/unit/position/position_core.js b/tests/unit/position/position_core.js index 5b1872af9..7176e37e1 100644 --- a/tests/unit/position/position_core.js +++ b/tests/unit/position/position_core.js @@ -726,4 +726,41 @@ test( "bug #5280: consistent results (avoid fractional values)", function() { deepEqual( offset1, offset2 ); }); +test( "bug #8710: flip if flipped position fits more", function() { + expect( 3 ); + + // Positions a 10px tall element within 99px height at top 90px. + collisionTest({ + within: "#bug-8710-within-smaller", + of: "#parentx", + collision: "flip", + at: "right bottom+30" + }, { + top: 0, + left: 60 + }, "flip - top fits all" ); + + // Positions a 10px tall element within 99px height at top 92px. + collisionTest({ + within: "#bug-8710-within-smaller", + of: "#parentx", + collision: "flip", + at: "right bottom+32" + }, { + top: -2, + left: 60 + }, "flip - top fits more" ); + + // Positions a 10px tall element within 101px height at top 92px. + collisionTest({ + within: "#bug-8710-within-bigger", + of: "#parentx", + collision: "flip", + at: "right bottom+32" + }, { + top: 92, + left: 60 + }, "no flip - top fits less" ); +}); + }( jQuery ) ); -- 2.39.5