From 4eb247b528ba02492246497db8a89653a108cc7e Mon Sep 17 00:00:00 2001 From: Javen O'Neal Date: Sun, 10 Apr 2016 21:28:41 +0000 Subject: [PATCH] add @NotImplemented annotation to methods that are not implemented git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1738469 13f79535-47bb-0310-9956-ffa450edef68 --- .../poi/hssf/usermodel/EscherGraphics.java | 60 +++++++++++++++++-- .../poi/hssf/usermodel/HSSFPatriarch.java | 2 + .../org/apache/poi/sl/draw/SLGraphics.java | 34 ++++++++--- .../apache/poi/openxml4j/opc/OPCPackage.java | 2 + .../poi/openxml4j/opc/ZipPackagePart.java | 4 ++ .../section/geometry/PolyLineTo.java | 2 + .../apache/poi/xslf/usermodel/XSLFSlide.java | 4 ++ .../usermodel/BaseXSSFEvaluationWorkbook.java | 2 + .../poi/xssf/usermodel/XSSFWorkbook.java | 4 ++ .../apache/poi/hslf/model/PPGraphics2D.java | 32 +++++++--- .../eventmodel/TestEventRecordFactory.java | 2 + 11 files changed, 128 insertions(+), 20 deletions(-) diff --git a/src/java/org/apache/poi/hssf/usermodel/EscherGraphics.java b/src/java/org/apache/poi/hssf/usermodel/EscherGraphics.java index 3bae848941..5cdb2a3576 100644 --- a/src/java/org/apache/poi/hssf/usermodel/EscherGraphics.java +++ b/src/java/org/apache/poi/hssf/usermodel/EscherGraphics.java @@ -18,6 +18,7 @@ package org.apache.poi.hssf.usermodel; import org.apache.poi.hssf.util.HSSFColor; +import org.apache.poi.util.NotImplemented; import org.apache.poi.util.POILogFactory; import org.apache.poi.util.POILogger; import org.apache.poi.util.SuppressForbidden; @@ -60,14 +61,14 @@ import java.text.AttributedCharacterIterator; */ public class EscherGraphics extends Graphics { - private HSSFShapeGroup escherGroup; - private HSSFWorkbook workbook; + private final HSSFShapeGroup escherGroup; + private final HSSFWorkbook workbook; private float verticalPointsPerPixel = 1.0f; - private float verticalPixelsPerPoint; + private final float verticalPixelsPerPoint; private Color foreground; private Color background = Color.white; private Font font; - private static POILogger logger = POILogFactory.getLogger(EscherGraphics.class); + private static final POILogger logger = POILogFactory.getLogger(EscherGraphics.class); /** * Construct an escher graphics object. @@ -121,6 +122,8 @@ public class EscherGraphics extends Graphics // } + @Override + @NotImplemented public void clearRect(int x, int y, int width, int height) { Color color = foreground; @@ -129,18 +132,23 @@ public class EscherGraphics extends Graphics setColor(color); } + @Override + @NotImplemented public void clipRect(int x, int y, int width, int height) { if (logger.check( POILogger.WARN )) logger.log(POILogger.WARN,"clipRect not supported"); } + @Override + @NotImplemented public void copyArea(int x, int y, int width, int height, int dx, int dy) { if (logger.check( POILogger.WARN )) logger.log(POILogger.WARN,"copyArea not supported"); } + @Override public Graphics create() { EscherGraphics g = new EscherGraphics(escherGroup, workbook, @@ -148,10 +156,13 @@ public class EscherGraphics extends Graphics return g; } + @Override public void dispose() { } + @Override + @NotImplemented public void drawArc(int x, int y, int width, int height, int startAngle, int arcAngle) { @@ -159,6 +170,8 @@ public class EscherGraphics extends Graphics logger.log(POILogger.WARN,"drawArc not supported"); } + @Override + @NotImplemented public boolean drawImage(Image img, int dx1, int dy1, int dx2, int dy2, int sx1, int sy1, int sx2, int sy2, @@ -171,6 +184,8 @@ public class EscherGraphics extends Graphics return true; } + @Override + @NotImplemented public boolean drawImage(Image img, int dx1, int dy1, int dx2, int dy2, int sx1, int sy1, int sx2, int sy2, @@ -181,26 +196,31 @@ public class EscherGraphics extends Graphics return true; } + @Override public boolean drawImage(Image image, int i, int j, int k, int l, Color color, ImageObserver imageobserver) { return drawImage(image, i, j, i + k, j + l, 0, 0, image.getWidth(imageobserver), image.getHeight(imageobserver), color, imageobserver); } + @Override public boolean drawImage(Image image, int i, int j, int k, int l, ImageObserver imageobserver) { return drawImage(image, i, j, i + k, j + l, 0, 0, image.getWidth(imageobserver), image.getHeight(imageobserver), imageobserver); } + @Override public boolean drawImage(Image image, int i, int j, Color color, ImageObserver imageobserver) { return drawImage(image, i, j, image.getWidth(imageobserver), image.getHeight(imageobserver), color, imageobserver); } + @Override public boolean drawImage(Image image, int i, int j, ImageObserver imageobserver) { return drawImage(image, i, j, image.getWidth(imageobserver), image.getHeight(imageobserver), imageobserver); } + @Override public void drawLine(int x1, int y1, int x2, int y2) { drawLine(x1,y1,x2,y2,0); @@ -214,6 +234,7 @@ public class EscherGraphics extends Graphics shape.setLineStyleColor(foreground.getRed(), foreground.getGreen(), foreground.getBlue()); } + @Override public void drawOval(int x, int y, int width, int height) { HSSFSimpleShape shape = escherGroup.createShape(new HSSFChildAnchor(x,y,x+width,y+height) ); @@ -223,6 +244,7 @@ public class EscherGraphics extends Graphics shape.setNoFill(true); } + @Override public void drawPolygon(int xPoints[], int yPoints[], int nPoints) { @@ -246,6 +268,8 @@ public class EscherGraphics extends Graphics return result; } + @Override + @NotImplemented public void drawPolyline(int xPoints[], int yPoints[], int nPoints) { @@ -253,12 +277,16 @@ public class EscherGraphics extends Graphics logger.log(POILogger.WARN,"drawPolyline not supported"); } + @Override + @NotImplemented public void drawRect(int x, int y, int width, int height) { if (logger.check( POILogger.WARN )) logger.log(POILogger.WARN,"drawRect not supported"); } + @Override + @NotImplemented public void drawRoundRect(int x, int y, int width, int height, int arcWidth, int arcHeight) { @@ -266,6 +294,7 @@ public class EscherGraphics extends Graphics logger.log(POILogger.WARN,"drawRoundRect not supported"); } + @Override public void drawString(String str, int x, int y) { if (str == null || str.equals("")) @@ -326,6 +355,7 @@ public class EscherGraphics extends Graphics } + @Override public void drawString(AttributedCharacterIterator iterator, int x, int y) { @@ -333,6 +363,7 @@ public class EscherGraphics extends Graphics logger.log(POILogger.WARN,"drawString not supported"); } + @Override public void fillArc(int x, int y, int width, int height, int startAngle, int arcAngle) { @@ -340,6 +371,7 @@ public class EscherGraphics extends Graphics logger.log(POILogger.WARN,"fillArc not supported"); } + @Override public void fillOval(int x, int y, int width, int height) { HSSFSimpleShape shape = escherGroup.createShape(new HSSFChildAnchor( x, y, x + width, y + height ) ); @@ -369,6 +401,7 @@ public class EscherGraphics extends Graphics * @param nPoints the total number of points in the polygon. * @see java.awt.Graphics#drawPolygon(int[], int[], int) */ + @Override public void fillPolygon(int xPoints[], int yPoints[], int nPoints) { @@ -405,6 +438,7 @@ public class EscherGraphics extends Graphics return result; } + @Override public void fillRect(int x, int y, int width, int height) { HSSFSimpleShape shape = escherGroup.createShape(new HSSFChildAnchor( x, y, x + width, y + height ) ); @@ -414,6 +448,7 @@ public class EscherGraphics extends Graphics shape.setLineStyleColor(foreground.getRed(), foreground.getGreen(), foreground.getBlue()); } + @Override public void fillRoundRect(int x, int y, int width, int height, int arcWidth, int arcHeight) { @@ -421,26 +456,31 @@ public class EscherGraphics extends Graphics logger.log(POILogger.WARN,"fillRoundRect not supported"); } + @Override public Shape getClip() { return getClipBounds(); } + @Override public Rectangle getClipBounds() { return null; } + @Override public Color getColor() { return foreground; } + @Override public Font getFont() { return font; } + @Override @SuppressWarnings("deprecation") @SuppressForbidden public FontMetrics getFontMetrics(Font f) @@ -448,38 +488,48 @@ public class EscherGraphics extends Graphics return Toolkit.getDefaultToolkit().getFontMetrics(f); } + @Override public void setClip(int x, int y, int width, int height) { setClip(new Rectangle(x,y,width,height)); } + @Override + @NotImplemented public void setClip(Shape shape) { // ignore... not implemented } + @Override public void setColor(Color color) { foreground = color; } + @Override public void setFont(Font f) { font = f; } + @Override + @NotImplemented public void setPaintMode() { if (logger.check( POILogger.WARN )) logger.log(POILogger.WARN,"setPaintMode not supported"); } + @Override + @NotImplemented public void setXORMode(Color color) { if (logger.check( POILogger.WARN )) logger.log(POILogger.WARN,"setXORMode not supported"); } - + @Override + @NotImplemented public void translate(int x, int y) { if (logger.check( POILogger.WARN )) diff --git a/src/java/org/apache/poi/hssf/usermodel/HSSFPatriarch.java b/src/java/org/apache/poi/hssf/usermodel/HSSFPatriarch.java index b431687459..f78d307ade 100644 --- a/src/java/org/apache/poi/hssf/usermodel/HSSFPatriarch.java +++ b/src/java/org/apache/poi/hssf/usermodel/HSSFPatriarch.java @@ -50,6 +50,7 @@ import org.apache.poi.ss.usermodel.ClientAnchor; import org.apache.poi.ss.usermodel.Drawing; import org.apache.poi.util.HexDump; import org.apache.poi.util.Internal; +import org.apache.poi.util.NotImplemented; import org.apache.poi.util.StringUtil; /** @@ -518,6 +519,7 @@ public final class HSSFPatriarch implements HSSFShapeContainer, Drawing { return new HSSFClientAnchor(dx1, dy1, dx2, dy2, (short) col1, row1, (short) col2, row2); } + @NotImplemented public Chart createChart(ClientAnchor anchor) { throw new RuntimeException("NotImplemented"); } diff --git a/src/java/org/apache/poi/sl/draw/SLGraphics.java b/src/java/org/apache/poi/sl/draw/SLGraphics.java index 1deca63d13..47dba62884 100644 --- a/src/java/org/apache/poi/sl/draw/SLGraphics.java +++ b/src/java/org/apache/poi/sl/draw/SLGraphics.java @@ -60,6 +60,7 @@ import org.apache.poi.sl.usermodel.StrokeStyle; import org.apache.poi.sl.usermodel.TextBox; import org.apache.poi.sl.usermodel.TextRun; import org.apache.poi.sl.usermodel.VerticalAlignment; +import org.apache.poi.util.NotImplemented; import org.apache.poi.util.POILogFactory; import org.apache.poi.util.POILogger; import org.apache.poi.util.SuppressForbidden; @@ -381,6 +382,7 @@ public final class SLGraphics extends Graphics2D implements Cloneable { * Clip. If s is null, * this method clears the current Clip. */ + @NotImplemented public void clip(Shape s){ if (log.check(POILogger.WARN)) { log.log(POILogger.WARN, "Not implemented"); @@ -403,6 +405,7 @@ public final class SLGraphics extends Graphics2D implements Cloneable { * @see java.awt.Graphics#setClip(Shape) * @since JDK1.1 */ + @NotImplemented public Shape getClip(){ if (log.check(POILogger.WARN)) { log.log(POILogger.WARN, "Not implemented"); @@ -669,6 +672,7 @@ public final class SLGraphics extends Graphics2D implements Cloneable { * @see java.awt.image.ImageObserver * @see java.awt.image.ImageObserver#imageUpdate(java.awt.Image, int, int, int, int, int) */ + @NotImplemented public boolean drawImage(Image img, int x, int y, Color bgcolor, ImageObserver observer){ @@ -717,6 +721,7 @@ public final class SLGraphics extends Graphics2D implements Cloneable { * @see java.awt.image.ImageObserver * @see java.awt.image.ImageObserver#imageUpdate(java.awt.Image, int, int, int, int, int) */ + @NotImplemented public boolean drawImage(Image img, int x, int y, int width, int height, Color bgcolor, @@ -776,6 +781,7 @@ public final class SLGraphics extends Graphics2D implements Cloneable { * @see java.awt.image.ImageObserver#imageUpdate(java.awt.Image, int, int, int, int, int) * @since JDK1.1 */ + @NotImplemented public boolean drawImage(Image img, int dx1, int dy1, int dx2, int dy2, int sx1, int sy1, int sx2, int sy2, @@ -839,6 +845,7 @@ public final class SLGraphics extends Graphics2D implements Cloneable { * @see java.awt.image.ImageObserver#imageUpdate(java.awt.Image, int, int, int, int, int) * @since JDK1.1 */ + @NotImplemented public boolean drawImage(Image img, int dx1, int dy1, int dx2, int dy2, int sx1, int sy1, int sx2, int sy2, @@ -882,6 +889,7 @@ public final class SLGraphics extends Graphics2D implements Cloneable { * @see java.awt.image.ImageObserver * @see java.awt.image.ImageObserver#imageUpdate(java.awt.Image, int, int, int, int, int) */ + @NotImplemented public boolean drawImage(Image img, int x, int y, ImageObserver observer) { if (log.check(POILogger.WARN)) { @@ -1069,6 +1077,7 @@ public final class SLGraphics extends Graphics2D implements Cloneable { * @see java.awt.Graphics#setClip(int, int, int, int) * @since JDK1.1 */ + @NotImplemented public void setClip(Shape clip) { if (log.check(POILogger.WARN)) { log.log(POILogger.WARN, "Not implemented"); @@ -1368,6 +1377,7 @@ public final class SLGraphics extends Graphics2D implements Cloneable { * @see java.awt.Graphics#setPaintMode * @see java.awt.AlphaComposite */ + @NotImplemented public void setComposite(Composite comp){ if (log.check(POILogger.WARN)) { log.log(POILogger.WARN, "Not implemented"); @@ -1381,6 +1391,7 @@ public final class SLGraphics extends Graphics2D implements Cloneable { * which defines a compositing style. * @see #setComposite */ + @NotImplemented public Composite getComposite(){ if (log.check(POILogger.WARN)) { log.log(POILogger.WARN, "Not implemented"); @@ -1524,6 +1535,7 @@ public final class SLGraphics extends Graphics2D implements Cloneable { * @see #setComposite * @see #setClip */ + @NotImplemented public void drawString(AttributedCharacterIterator iterator, float x, float y) { if (log.check(POILogger.WARN)) { log.log(POILogger.WARN, "Not implemented"); @@ -1630,10 +1642,11 @@ public final class SLGraphics extends Graphics2D implements Cloneable { * @see #clip * @see #setClip(Shape) */ - public boolean drawImage(Image img, AffineTransform xform, ImageObserver obs) { - if (log.check(POILogger.WARN)) { - log.log(POILogger.WARN, "Not implemented"); - } + @NotImplemented + public boolean drawImage(Image img, AffineTransform xform, ImageObserver obs) { + if (log.check(POILogger.WARN)) { + log.log(POILogger.WARN, "Not implemented"); + } return false; } @@ -1673,6 +1686,7 @@ public final class SLGraphics extends Graphics2D implements Cloneable { * @see java.awt.image.ImageObserver * @see java.awt.image.ImageObserver#imageUpdate(java.awt.Image, int, int, int, int, int) */ + @NotImplemented public boolean drawImage(Image img, int x, int y, int width, int height, ImageObserver observer) { @@ -1725,6 +1739,7 @@ public final class SLGraphics extends Graphics2D implements Cloneable { * drawn twice, then all pixels are restored to their original values. * @param c1 the XOR alternation color */ + @NotImplemented public void setXORMode(Color c1) { if (log.check(POILogger.WARN)) { log.log(POILogger.WARN, "Not implemented"); @@ -1738,6 +1753,7 @@ public final class SLGraphics extends Graphics2D implements Cloneable { * overwrite mode. All subsequent rendering operations will * overwrite the destination with the current color. */ + @NotImplemented public void setPaintMode() { if (log.check(POILogger.WARN)) { log.log(POILogger.WARN, "Not implemented"); @@ -1775,10 +1791,11 @@ public final class SLGraphics extends Graphics2D implements Cloneable { * @see #setClip * @see #drawRenderedImage */ - public void drawRenderedImage(RenderedImage img, AffineTransform xform) { - if (log.check(POILogger.WARN)) { - log.log(POILogger.WARN, "Not implemented"); - } + @NotImplemented + public void drawRenderedImage(RenderedImage img, AffineTransform xform) { + if (log.check(POILogger.WARN)) { + log.log(POILogger.WARN, "Not implemented"); + } } /** @@ -1802,6 +1819,7 @@ public final class SLGraphics extends Graphics2D implements Cloneable { * @see #clip * @see #setClip */ + @NotImplemented public void drawRenderableImage(RenderableImage img, AffineTransform xform) { if (log.check(POILogger.WARN)) { log.log(POILogger.WARN, "Not implemented"); diff --git a/src/ooxml/java/org/apache/poi/openxml4j/opc/OPCPackage.java b/src/ooxml/java/org/apache/poi/openxml4j/opc/OPCPackage.java index b1b11b512d..e84d83e3e6 100644 --- a/src/ooxml/java/org/apache/poi/openxml4j/opc/OPCPackage.java +++ b/src/ooxml/java/org/apache/poi/openxml4j/opc/OPCPackage.java @@ -53,6 +53,7 @@ import org.apache.poi.openxml4j.opc.internal.marshallers.ZipPackagePropertiesMar import org.apache.poi.openxml4j.opc.internal.unmarshallers.PackagePropertiesUnmarshaller; import org.apache.poi.openxml4j.opc.internal.unmarshallers.UnmarshallContext; import org.apache.poi.openxml4j.util.Nullable; +import org.apache.poi.util.NotImplemented; import org.apache.poi.util.POILogFactory; import org.apache.poi.util.POILogger; @@ -1433,6 +1434,7 @@ public abstract class OPCPackage implements RelationshipSource, Closeable { * * @return true if the package is valid else false */ + @NotImplemented public boolean validatePackage(OPCPackage pkg) throws InvalidFormatException { throw new InvalidOperationException("Not implemented yet !!!"); } diff --git a/src/ooxml/java/org/apache/poi/openxml4j/opc/ZipPackagePart.java b/src/ooxml/java/org/apache/poi/openxml4j/opc/ZipPackagePart.java index 8c0e18502a..58bbbfe225 100644 --- a/src/ooxml/java/org/apache/poi/openxml4j/opc/ZipPackagePart.java +++ b/src/ooxml/java/org/apache/poi/openxml4j/opc/ZipPackagePart.java @@ -26,6 +26,7 @@ import org.apache.poi.openxml4j.exceptions.InvalidFormatException; import org.apache.poi.openxml4j.exceptions.InvalidOperationException; import org.apache.poi.openxml4j.exceptions.OpenXML4JException; import org.apache.poi.openxml4j.opc.internal.marshallers.ZipPartMarshaller; +import org.apache.poi.util.NotImplemented; /** * Zip implementation of a PackagePart. @@ -124,16 +125,19 @@ public class ZipPackagePart extends PackagePart { } @Override + @NotImplemented public boolean load(InputStream ios) { throw new InvalidOperationException("Method not implemented !"); } @Override + @NotImplemented public void close() { throw new InvalidOperationException("Method not implemented !"); } @Override + @NotImplemented public void flush() { throw new InvalidOperationException("Method not implemented !"); } diff --git a/src/ooxml/java/org/apache/poi/xdgf/usermodel/section/geometry/PolyLineTo.java b/src/ooxml/java/org/apache/poi/xdgf/usermodel/section/geometry/PolyLineTo.java index 88f7327296..c5f1ba011a 100644 --- a/src/ooxml/java/org/apache/poi/xdgf/usermodel/section/geometry/PolyLineTo.java +++ b/src/ooxml/java/org/apache/poi/xdgf/usermodel/section/geometry/PolyLineTo.java @@ -18,6 +18,7 @@ package org.apache.poi.xdgf.usermodel.section.geometry; import org.apache.poi.POIXMLException; +import org.apache.poi.util.NotImplemented; import org.apache.poi.xdgf.usermodel.XDGFCell; import org.apache.poi.xdgf.usermodel.XDGFShape; @@ -90,6 +91,7 @@ public class PolyLineTo implements GeometryRow { } @Override + @NotImplemented public void addToPath(java.awt.geom.Path2D.Double path, XDGFShape parent) { if (getDel()) return; diff --git a/src/ooxml/java/org/apache/poi/xslf/usermodel/XSLFSlide.java b/src/ooxml/java/org/apache/poi/xslf/usermodel/XSLFSlide.java index 9d132baa17..7301b553a5 100644 --- a/src/ooxml/java/org/apache/poi/xslf/usermodel/XSLFSlide.java +++ b/src/ooxml/java/org/apache/poi/xslf/usermodel/XSLFSlide.java @@ -31,6 +31,7 @@ import org.apache.poi.sl.usermodel.Placeholder; import org.apache.poi.sl.usermodel.Slide; import org.apache.poi.util.Beta; import org.apache.poi.util.DocumentHelper; +import org.apache.poi.util.NotImplemented; import org.apache.xmlbeans.XmlException; import org.openxmlformats.schemas.drawingml.x2006.main.CTBlip; import org.openxmlformats.schemas.drawingml.x2006.main.CTGroupShapeProperties; @@ -259,6 +260,7 @@ implements Slide { return false; } + @NotImplemented public void setFollowMasterBackground(boolean follow) { // not implemented ... also not in the specs throw new UnsupportedOperationException(); @@ -268,12 +270,14 @@ implements Slide { return false; } + @NotImplemented public void setFollowMasterColourScheme(boolean follow) { // not implemented ... only for OLE objects in the specs throw new UnsupportedOperationException(); } @Override + @NotImplemented public void setNotes(Notes notes) { assert(notes instanceof XSLFNotes); // TODO Auto-generated method stub diff --git a/src/ooxml/java/org/apache/poi/xssf/usermodel/BaseXSSFEvaluationWorkbook.java b/src/ooxml/java/org/apache/poi/xssf/usermodel/BaseXSSFEvaluationWorkbook.java index 04b559ba10..4a6882ac42 100644 --- a/src/ooxml/java/org/apache/poi/xssf/usermodel/BaseXSSFEvaluationWorkbook.java +++ b/src/ooxml/java/org/apache/poi/xssf/usermodel/BaseXSSFEvaluationWorkbook.java @@ -38,6 +38,7 @@ import org.apache.poi.ss.formula.udf.IndexedUDFFinder; import org.apache.poi.ss.formula.udf.UDFFinder; import org.apache.poi.ss.util.AreaReference; import org.apache.poi.ss.util.CellReference; +import org.apache.poi.util.NotImplemented; import org.apache.poi.xssf.model.ExternalLinksTable; import org.openxmlformats.schemas.spreadsheetml.x2006.main.CTDefinedName; @@ -280,6 +281,7 @@ public abstract class BaseXSSFEvaluationWorkbook implements FormulaRenderingWork } } + @NotImplemented public int getExternalSheetIndex(String workbookName, String sheetName) { throw new RuntimeException("not implemented yet"); } diff --git a/src/ooxml/java/org/apache/poi/xssf/usermodel/XSSFWorkbook.java b/src/ooxml/java/org/apache/poi/xssf/usermodel/XSSFWorkbook.java index 078cfa22de..100c2b95bd 100644 --- a/src/ooxml/java/org/apache/poi/xssf/usermodel/XSSFWorkbook.java +++ b/src/ooxml/java/org/apache/poi/xssf/usermodel/XSSFWorkbook.java @@ -67,6 +67,7 @@ import org.apache.poi.ss.util.WorkbookUtil; import org.apache.poi.util.Beta; import org.apache.poi.util.IOUtils; import org.apache.poi.util.Internal; +import org.apache.poi.util.NotImplemented; import org.apache.poi.util.POILogFactory; import org.apache.poi.util.POILogger; import org.apache.poi.util.PackageHelper; @@ -1777,11 +1778,13 @@ public class XSSFWorkbook extends POIXMLDocument implements Workbook { } @Override + @NotImplemented public boolean isHidden() { throw new RuntimeException("Not implemented yet"); } @Override + @NotImplemented public void setHidden(boolean hiddenFlag) { throw new RuntimeException("Not implemented yet"); } @@ -1937,6 +1940,7 @@ public class XSSFWorkbook extends POIXMLDocument implements Workbook { * @param name The name the workbook will be referenced as in formulas * @param workbook The open workbook to fetch the link required information from */ + @NotImplemented public int linkExternalWorkbook(String name, Workbook workbook) { throw new RuntimeException("Not Implemented - see bug #57184"); } diff --git a/src/scratchpad/src/org/apache/poi/hslf/model/PPGraphics2D.java b/src/scratchpad/src/org/apache/poi/hslf/model/PPGraphics2D.java index 70229b1bd8..74047674c0 100644 --- a/src/scratchpad/src/org/apache/poi/hslf/model/PPGraphics2D.java +++ b/src/scratchpad/src/org/apache/poi/hslf/model/PPGraphics2D.java @@ -61,6 +61,7 @@ import org.apache.poi.hslf.usermodel.HSLFTextRun; import org.apache.poi.sl.draw.DrawPaint; import org.apache.poi.sl.usermodel.StrokeStyle; import org.apache.poi.sl.usermodel.VerticalAlignment; +import org.apache.poi.util.NotImplemented; import org.apache.poi.util.POILogFactory; import org.apache.poi.util.POILogger; import org.apache.poi.util.SuppressForbidden; @@ -139,7 +140,7 @@ public final class PPGraphics2D extends Graphics2D implements Cloneable { * @see java.awt.Color * @see java.awt.Graphics#setColor */ - public Color getColor(){ + public Color getColor(){ return _foreground; } @@ -197,7 +198,7 @@ public final class PPGraphics2D extends Graphics2D implements Cloneable { * color during the rendering process, or null * @see java.awt.Graphics#setColor */ - public void setPaint(Paint paint){ + public void setPaint(Paint paint){ if(paint == null) return; this._paint = paint; @@ -389,6 +390,7 @@ public final class PPGraphics2D extends Graphics2D implements Cloneable { * Clip. If s is null, * this method clears the current Clip. */ + @NotImplemented public void clip(Shape s){ if (log.check(POILogger.WARN)) { log.log(POILogger.WARN, "Not implemented"); @@ -411,6 +413,7 @@ public final class PPGraphics2D extends Graphics2D implements Cloneable { * @see java.awt.Graphics#setClip(Shape) * @since JDK1.1 */ + @NotImplemented public Shape getClip(){ if (log.check(POILogger.WARN)) { log.log(POILogger.WARN, "Not implemented"); @@ -679,6 +682,7 @@ public final class PPGraphics2D extends Graphics2D implements Cloneable { * @see java.awt.image.ImageObserver * @see java.awt.image.ImageObserver#imageUpdate(java.awt.Image, int, int, int, int, int) */ + @NotImplemented public boolean drawImage(Image img, int x, int y, Color bgcolor, ImageObserver observer){ @@ -727,6 +731,7 @@ public final class PPGraphics2D extends Graphics2D implements Cloneable { * @see java.awt.image.ImageObserver * @see java.awt.image.ImageObserver#imageUpdate(java.awt.Image, int, int, int, int, int) */ + @NotImplemented public boolean drawImage(Image img, int x, int y, int width, int height, Color bgcolor, @@ -786,6 +791,7 @@ public final class PPGraphics2D extends Graphics2D implements Cloneable { * @see java.awt.image.ImageObserver#imageUpdate(java.awt.Image, int, int, int, int, int) * @since JDK1.1 */ + @NotImplemented public boolean drawImage(Image img, int dx1, int dy1, int dx2, int dy2, int sx1, int sy1, int sx2, int sy2, @@ -849,6 +855,7 @@ public final class PPGraphics2D extends Graphics2D implements Cloneable { * @see java.awt.image.ImageObserver#imageUpdate(java.awt.Image, int, int, int, int, int) * @since JDK1.1 */ + @NotImplemented public boolean drawImage(Image img, int dx1, int dy1, int dx2, int dy2, int sx1, int sy1, int sx2, int sy2, @@ -892,6 +899,7 @@ public final class PPGraphics2D extends Graphics2D implements Cloneable { * @see java.awt.image.ImageObserver * @see java.awt.image.ImageObserver#imageUpdate(java.awt.Image, int, int, int, int, int) */ + @NotImplemented public boolean drawImage(Image img, int x, int y, ImageObserver observer) { if (log.check(POILogger.WARN)) { @@ -1079,6 +1087,7 @@ public final class PPGraphics2D extends Graphics2D implements Cloneable { * @see java.awt.Graphics#setClip(int, int, int, int) * @since JDK1.1 */ + @NotImplemented public void setClip(Shape clip) { if (log.check(POILogger.WARN)) { log.log(POILogger.WARN, "Not implemented"); @@ -1378,6 +1387,7 @@ public final class PPGraphics2D extends Graphics2D implements Cloneable { * @see java.awt.Graphics#setPaintMode * @see java.awt.AlphaComposite */ + @NotImplemented public void setComposite(Composite comp){ if (log.check(POILogger.WARN)) { log.log(POILogger.WARN, "Not implemented"); @@ -1391,6 +1401,7 @@ public final class PPGraphics2D extends Graphics2D implements Cloneable { * which defines a compositing style. * @see #setComposite */ + @NotImplemented public Composite getComposite(){ if (log.check(POILogger.WARN)) { log.log(POILogger.WARN, "Not implemented"); @@ -1534,6 +1545,7 @@ public final class PPGraphics2D extends Graphics2D implements Cloneable { * @see #setComposite * @see #setClip */ + @NotImplemented public void drawString(AttributedCharacterIterator iterator, float x, float y) { if (log.check(POILogger.WARN)) { log.log(POILogger.WARN, "Not implemented"); @@ -1640,7 +1652,8 @@ public final class PPGraphics2D extends Graphics2D implements Cloneable { * @see #clip * @see #setClip(Shape) */ - public boolean drawImage(Image img, AffineTransform xform, ImageObserver obs) { + @NotImplemented + public boolean drawImage(Image img, AffineTransform xform, ImageObserver obs) { if (log.check(POILogger.WARN)) { log.log(POILogger.WARN, "Not implemented"); } @@ -1683,6 +1696,7 @@ public final class PPGraphics2D extends Graphics2D implements Cloneable { * @see java.awt.image.ImageObserver * @see java.awt.image.ImageObserver#imageUpdate(java.awt.Image, int, int, int, int, int) */ + @NotImplemented public boolean drawImage(Image img, int x, int y, int width, int height, ImageObserver observer) { @@ -1735,6 +1749,7 @@ public final class PPGraphics2D extends Graphics2D implements Cloneable { * drawn twice, then all pixels are restored to their original values. * @param c1 the XOR alternation color */ + @NotImplemented public void setXORMode(Color c1) { if (log.check(POILogger.WARN)) { log.log(POILogger.WARN, "Not implemented"); @@ -1748,6 +1763,7 @@ public final class PPGraphics2D extends Graphics2D implements Cloneable { * overwrite mode. All subsequent rendering operations will * overwrite the destination with the current color. */ + @NotImplemented public void setPaintMode() { if (log.check(POILogger.WARN)) { log.log(POILogger.WARN, "Not implemented"); @@ -1785,10 +1801,11 @@ public final class PPGraphics2D extends Graphics2D implements Cloneable { * @see #setClip * @see #drawRenderedImage */ - public void drawRenderedImage(RenderedImage img, AffineTransform xform) { - if (log.check(POILogger.WARN)) { - log.log(POILogger.WARN, "Not implemented"); - } + @NotImplemented + public void drawRenderedImage(RenderedImage img, AffineTransform xform) { + if (log.check(POILogger.WARN)) { + log.log(POILogger.WARN, "Not implemented"); + } } /** @@ -1812,6 +1829,7 @@ public final class PPGraphics2D extends Graphics2D implements Cloneable { * @see #clip * @see #setClip */ + @NotImplemented public void drawRenderableImage(RenderableImage img, AffineTransform xform) { if (log.check(POILogger.WARN)) { log.log(POILogger.WARN, "Not implemented"); diff --git a/src/testcases/org/apache/poi/hssf/eventmodel/TestEventRecordFactory.java b/src/testcases/org/apache/poi/hssf/eventmodel/TestEventRecordFactory.java index a81b343a71..51454333f5 100644 --- a/src/testcases/org/apache/poi/hssf/eventmodel/TestEventRecordFactory.java +++ b/src/testcases/org/apache/poi/hssf/eventmodel/TestEventRecordFactory.java @@ -28,6 +28,7 @@ import org.apache.poi.hssf.record.Record; import org.apache.poi.hssf.record.RecordFactory; import org.apache.poi.hssf.record.TestcaseRecordInputStream; import org.apache.poi.hssf.record.UnknownRecord; +import org.apache.poi.util.NotImplemented; /** * enclosing_type describe the purpose here @@ -123,6 +124,7 @@ public final class TestEventRecordFactory extends TestCase { * constructed record in the case of a continued record. * TODO - need a real world example to put in a unit test */ + @NotImplemented public void testCreateContinuedRecord() { // fail("not implemented"); -- 2.39.5