From 4f2e209b85b56351ed17ac0b5de60db85666209f Mon Sep 17 00:00:00 2001 From: jeresig Date: Fri, 29 Jan 2010 00:22:20 -0500 Subject: [PATCH] Make sure fragment caching is only happening on nodes in the main document. Fixes #5978. --- src/manipulation.js | 12 ++++++++---- 1 file changed, 8 insertions(+), 4 deletions(-) diff --git a/src/manipulation.js b/src/manipulation.js index 93950de0f..88da6de52 100644 --- a/src/manipulation.js +++ b/src/manipulation.js @@ -384,10 +384,15 @@ function cloneCopyEvent(orig, ret) { } function buildFragment( args, nodes, scripts ) { - var fragment, cacheable, cacheresults, doc; + var fragment, cacheable, cacheresults, + doc = (nodes && nodes[0] ? nodes[0].ownerDocument || nodes[0] : document); + + // Only cache "small" (1/2 KB) strings that are associated with the main document + // Cloning options loses the selected state, so don't cache them + // Also, WebKit does not clone 'checked' attributes on cloneNode, so don't cache + if ( args.length === 1 && typeof args[0] === "string" && args[0].length < 512 && doc === document && + args[0].indexOf("