From 4fc0e09a6029affb5cb5f526387aba12e99065c4 Mon Sep 17 00:00:00 2001 From: Simon Brandhof Date: Mon, 9 May 2016 14:23:04 +0200 Subject: [PATCH] Fix quality flaws --- .../java/org/sonar/server/issue/IssueBulkChangeService.java | 2 +- .../java/org/sonar/server/measure/MeasureFilterCondition.java | 2 +- .../src/main/java/org/sonar/api/server/ws/WebService.java | 2 +- .../src/main/java/org/sonar/api/web/DashboardLayout.java | 2 +- 4 files changed, 4 insertions(+), 4 deletions(-) diff --git a/server/sonar-server/src/main/java/org/sonar/server/issue/IssueBulkChangeService.java b/server/sonar-server/src/main/java/org/sonar/server/issue/IssueBulkChangeService.java index 352defecc4b..9d1d7eba9e0 100644 --- a/server/sonar-server/src/main/java/org/sonar/server/issue/IssueBulkChangeService.java +++ b/server/sonar-server/src/main/java/org/sonar/server/issue/IssueBulkChangeService.java @@ -128,7 +128,7 @@ public class IssueBulkChangeService { private Collection getByKeysForUpdate(List issueKeys) { // Load from index to check permission SearchOptions options = new SearchOptions().setLimit(SearchOptions.MAX_LIMIT); - // TODO restrict fields to issue key, in order to not load all other fields; + // TODO restrict fields to issue key, in order to not load all other fields List authorizedIssues = issueIndex.search(IssueQuery.builder(userSession).issueKeys(issueKeys).build(), options).getDocs(); Collection authorizedKeys = Collections2.transform(authorizedIssues, new Function() { @Override diff --git a/server/sonar-server/src/main/java/org/sonar/server/measure/MeasureFilterCondition.java b/server/sonar-server/src/main/java/org/sonar/server/measure/MeasureFilterCondition.java index 499e5759987..3deaa13005d 100644 --- a/server/sonar-server/src/main/java/org/sonar/server/measure/MeasureFilterCondition.java +++ b/server/sonar-server/src/main/java/org/sonar/server/measure/MeasureFilterCondition.java @@ -30,7 +30,7 @@ public class MeasureFilterCondition { private String code; private String sql; - private Operator(String code, String sql) { + Operator(String code, String sql) { this.code = code; this.sql = sql; } diff --git a/sonar-plugin-api/src/main/java/org/sonar/api/server/ws/WebService.java b/sonar-plugin-api/src/main/java/org/sonar/api/server/ws/WebService.java index 3a9b87fe478..d4bed5bb27a 100644 --- a/sonar-plugin-api/src/main/java/org/sonar/api/server/ws/WebService.java +++ b/sonar-plugin-api/src/main/java/org/sonar/api/server/ws/WebService.java @@ -694,7 +694,7 @@ public interface WebService extends Definable { } }); - private SelectionMode(String paramValue) { + SelectionMode(String paramValue) { this.paramValue = paramValue; } diff --git a/sonar-plugin-api/src/main/java/org/sonar/api/web/DashboardLayout.java b/sonar-plugin-api/src/main/java/org/sonar/api/web/DashboardLayout.java index 1980d835853..346a5f8dcf5 100644 --- a/sonar-plugin-api/src/main/java/org/sonar/api/web/DashboardLayout.java +++ b/sonar-plugin-api/src/main/java/org/sonar/api/web/DashboardLayout.java @@ -54,7 +54,7 @@ public enum DashboardLayout { private String code; private int columns; - private DashboardLayout(String code, int columns) { + DashboardLayout(String code, int columns) { this.code = code; this.columns = columns; } -- 2.39.5