From 52cc3fdc24dbb3814b6924323c032051ddac941e Mon Sep 17 00:00:00 2001
From: Go MAEDA <maeda@farend.jp>
Date: Sat, 24 Oct 2020 02:19:29 +0000
Subject: [PATCH] Update RuboCop Performance to 1.8 (#34159).

git-svn-id: http://svn.redmine.org/redmine/trunk@20174 e93f8b46-1217-0410-a6f0-8f06a7374b81
---
 .rubocop_todo.yml | 47 +++++++++++++++++++++++++++++++++++++++++++++++
 Gemfile           |  2 +-
 2 files changed, 48 insertions(+), 1 deletion(-)

diff --git a/.rubocop_todo.yml b/.rubocop_todo.yml
index c6d0329d2..eece8b2cc 100644
--- a/.rubocop_todo.yml
+++ b/.rubocop_todo.yml
@@ -524,6 +524,34 @@ Naming/VariableNumber:
     - 'test/unit/lib/redmine/scm/adapters/mercurial_adapter_test.rb'
     - 'test/unit/project_test.rb'
 
+# Cop supports --auto-correct.
+Performance/AncestorsInclude:
+  Exclude:
+    - 'test/unit/document_category_test.rb'
+    - 'test/unit/issue_priority_test.rb'
+    - 'test/unit/time_entry_activity_test.rb'
+
+# Configuration parameters: MinSize.
+Performance/CollectionLiteralInLoop:
+  Exclude:
+    - 'app/helpers/imports_helper.rb'
+    - 'app/helpers/queries_helper.rb'
+    - 'app/helpers/settings_helper.rb'
+    - 'app/helpers/timelog_helper.rb'
+    - 'app/models/issue.rb'
+    - 'app/models/workflow_transition.rb'
+    - 'lib/redmine/helpers/time_report.rb'
+    - 'lib/redmine/scm/adapters/filesystem_adapter.rb'
+    - 'lib/redmine/wiki_formatting/textile/redcloth3.rb'
+    - 'test/functional/issues_custom_fields_visibility_test.rb'
+    - 'test/functional/repositories_git_controller_test.rb'
+    - 'test/functional/repositories_mercurial_controller_test.rb'
+    - 'test/functional/timelog_custom_fields_visibility_test.rb'
+    - 'test/unit/lib/redmine/scm/adapters/git_adapter_test.rb'
+    - 'test/unit/lib/redmine/scm/adapters/mercurial_adapter_test.rb'
+    - 'test/unit/repository_git_test.rb'
+    - 'test/unit/repository_mercurial_test.rb'
+
 Performance/FixedSize:
   Exclude:
     - 'test/integration/api_test/issues_test.rb'
@@ -552,6 +580,20 @@ Performance/RedundantMerge:
     - 'test/unit/issue_import_test.rb'
     - 'test/unit/time_entry_import_test.rb'
 
+# Cop supports --auto-correct.
+Performance/Squeeze:
+  Exclude:
+    - 'test/unit/lib/redmine/scm/adapters/bazaar_adapter_test.rb'
+
+# Cop supports --auto-correct.
+# Configuration parameters: AutoCorrect.
+Performance/StringInclude:
+  Exclude:
+    - 'test/functional/versions_controller_test.rb'
+    - 'test/integration/sessions_test.rb'
+    - 'test/unit/lib/redmine/scm/adapters/bazaar_adapter_test.rb'
+    - 'test/unit/lib/redmine/wiki_formatting/macros_test.rb'
+
 # Cop supports --auto-correct.
 Performance/StringReplacement:
   Exclude:
@@ -569,6 +611,11 @@ Performance/StringReplacement:
     - 'test/unit/repository_cvs_test.rb'
     - 'test/unit/repository_git_test.rb'
 
+# Cop supports --auto-correct.
+Performance/Sum:
+  Exclude:
+    - 'app/helpers/issues_helper.rb'
+
 # Cop supports --auto-correct.
 # Configuration parameters: Include.
 # Include: app/models/**/*.rb
diff --git a/Gemfile b/Gemfile
index a550539ad..86f41f9e8 100644
--- a/Gemfile
+++ b/Gemfile
@@ -93,7 +93,7 @@ group :test do
   gem "selenium-webdriver"
   # RuboCop
   gem 'rubocop', '~> 1.0.0'
-  gem 'rubocop-performance', '~> 1.5.0'
+  gem 'rubocop-performance', '~> 1.8.0'
   gem 'rubocop-rails', '~> 2.8.0'
 end
 
-- 
2.39.5