From 609881fcb0994a786bd7285bc0cbfebb73b13ede Mon Sep 17 00:00:00 2001
From: Matti Tahvonen <matti.tahvonen@itmill.com>
Date: Fri, 26 Sep 2008 06:45:05 +0000
Subject: [PATCH] tuning tabIndex behavior

svn changeset:5519/svn branch:trunk
---
 src/com/itmill/toolkit/terminal/gwt/client/ui/IView.java | 8 +++++---
 .../toolkit/terminal/gwt/server/ApplicationServlet.java  | 9 +++++----
 2 files changed, 10 insertions(+), 7 deletions(-)

diff --git a/src/com/itmill/toolkit/terminal/gwt/client/ui/IView.java b/src/com/itmill/toolkit/terminal/gwt/client/ui/IView.java
index 3611e6e0d5..3255f8223c 100644
--- a/src/com/itmill/toolkit/terminal/gwt/client/ui/IView.java
+++ b/src/com/itmill/toolkit/terminal/gwt/client/ui/IView.java
@@ -63,7 +63,9 @@ public class IView extends SimplePanel implements Paintable,
 
         DOM.sinkEvents(getElement(), Event.ONKEYDOWN);
 
-        DOM.setElementProperty(getElement(), "tabIndex", "0");
+        // iview is focused when created so element needs tabIndex
+        // 1 due 0 is at the end of natural tabbing order
+        DOM.setElementProperty(getElement(), "tabIndex", "1");
 
         RootPanel.get(elementId).add(this);
 
@@ -326,8 +328,8 @@ public class IView extends SimplePanel implements Paintable,
     }
 
     private static native void focusElement(Element e) /*-{ 
-                                        e.focus();
-                                        }-*/;
+                                                    e.focus();
+                                                    }-*/;
 
     public String onWindowClosing() {
         return null;
diff --git a/src/com/itmill/toolkit/terminal/gwt/server/ApplicationServlet.java b/src/com/itmill/toolkit/terminal/gwt/server/ApplicationServlet.java
index 30fd38ca73..13b6d7988d 100644
--- a/src/com/itmill/toolkit/terminal/gwt/server/ApplicationServlet.java
+++ b/src/com/itmill/toolkit/terminal/gwt/server/ApplicationServlet.java
@@ -842,7 +842,7 @@ public class ApplicationServlet extends HttpServlet {
             // there are multiple toolkit portlets visible at the same time.
             // TODO remove this when hosted mode on linux gets newer gecko
 
-            page.write("<iframe id=\"__gwt_historyFrame\" "
+            page.write("<iframe tabIndex=\"-1\" id=\"__gwt_historyFrame\" "
                     + "style=\"width:0;height:0;border:0;overflow:"
                     + "hidden\" src=\"javascript:false\"></iframe>\n");
             page.write("<script language='javascript' src='" + staticFilePath
@@ -895,9 +895,10 @@ public class ApplicationServlet extends HttpServlet {
                     + "if(!itmill) { var itmill = {}} \n"
                     + "itmill.toolkitConfigurations = {};\n"
                     + "itmill.themesLoaded = {};\n");
-            page.write("document.write('<iframe id=\"__gwt_historyFrame\" "
-                    + "style=\"width:0;height:0;border:0;overflow:"
-                    + "hidden\" src=\"javascript:false\"></iframe>');\n");
+            page
+                    .write("document.write('<iframe tabIndex=\"-1\" id=\"__gwt_historyFrame\" "
+                            + "style=\"width:0;height:0;border:0;overflow:"
+                            + "hidden\" src=\"javascript:false\"></iframe>');\n");
             page.write("document.write(\"<script language='javascript' src='"
                     + staticFilePath + "/" + WIDGETSET_DIRECTORY_PATH
                     + widgetset + "/" + widgetset
-- 
2.39.5