From 6449facdc365c9072ea1ea4aa347cdc86ba9de4f Mon Sep 17 00:00:00 2001
From: Stas Vilchik <vilchiks@gmail.com>
Date: Thu, 18 Dec 2014 13:25:07 +0100
Subject: [PATCH] SONAR-5607 Apply feedback

---
 .../main/js/source-viewer/measures-overlay.js | 26 ++++++++++++++++---
 1 file changed, 22 insertions(+), 4 deletions(-)

diff --git a/server/sonar-web/src/main/js/source-viewer/measures-overlay.js b/server/sonar-web/src/main/js/source-viewer/measures-overlay.js
index 6d6de2a7adf..a28dd89ffb0 100644
--- a/server/sonar-web/src/main/js/source-viewer/measures-overlay.js
+++ b/server/sonar-web/src/main/js/source-viewer/measures-overlay.js
@@ -157,32 +157,50 @@ define([
           options = {key: this.model.key()};
       return $.get(url, options).done(function (data) {
         that.model.set({tests: data.tests});
-        that.sortTests('name');
-        that.testSorting = 'name';
+        that.sortTests(function (test) {
+          return test.status + '_______' + test.name;
+        });
+        that.testSorting = 'status';
+        that.testAsc = true;
       });
     },
 
     sortTests: function (condition) {
       var tests = this.model.get('tests');
       if (_.isArray(tests)) {
-        this.model.set({tests: _.sortBy(tests, condition)});
+        tests = _.sortBy(tests, condition);
+        if (!this.testAsc) {
+          tests.reverse();
+        }
+        this.model.set({ tests: tests });
       }
     },
 
     sortTestsByDuration: function () {
+      if (this.testSorting === 'duration') {
+        this.testAsc = !this.testAsc;
+      }
       this.sortTests('durationInMs');
       this.testSorting = 'duration';
       this.render();
     },
 
     sortTestsByName: function () {
+      if (this.testSorting === 'name') {
+        this.testAsc = !this.testAsc;
+      }
       this.sortTests('name');
       this.testSorting = 'name';
       this.render();
     },
 
     sortTestsByStatus: function () {
-      this.sortTests('status');
+      if (this.testSorting === 'status') {
+        this.testAsc = !this.testAsc;
+      }
+      this.sortTests(function (test) {
+        return test.status + '_______' + test.name;
+      });
       this.testSorting = 'status';
       this.render();
     },
-- 
2.39.5