From 64929746bc516f9bfcac28a0a2e99572ab007b24 Mon Sep 17 00:00:00 2001 From: Constantin Kaplinsky Date: Thu, 26 Jan 2006 14:32:31 +0000 Subject: [PATCH] A few FIXME comments. git-svn-id: svn://svn.code.sf.net/p/tigervnc/code/trunk@473 3789f03b-4d11-0410-bbf8-ca57d06f2519 --- rfb/VNCSConnectionST.cxx | 7 ++++++- 1 file changed, 6 insertions(+), 1 deletion(-) diff --git a/rfb/VNCSConnectionST.cxx b/rfb/VNCSConnectionST.cxx index 7173758f..98957615 100644 --- a/rfb/VNCSConnectionST.cxx +++ b/rfb/VNCSConnectionST.cxx @@ -671,13 +671,16 @@ void VNCSConnectionST::setSocketTimeouts() char* VNCSConnectionST::getStartTime() { + // FIXME: Using ctime() is not thread-safe. + // Also, it's not good to return the pointer instead of copying. char* result = ctime(&startTime); result[24] = '\0'; - return result; + return result; } void VNCSConnectionST::setStatus(int status) { + // FIXME: What do numbers mean? switch (status) { case 0: accessRights = accessRights | AccessPtrEvents | AccessKeyEvents | AccessView; @@ -691,8 +694,10 @@ void VNCSConnectionST::setStatus(int status) } framebufferUpdateRequest(server->pb->getRect(), false); } + int VNCSConnectionST::getStatus() { + // FIXME: What do numbers mean? if ((accessRights & (AccessPtrEvents | AccessKeyEvents | AccessView)) == 0x0007) return 0; if ((accessRights & (AccessPtrEvents | AccessKeyEvents | AccessView)) == 0x0001) -- 2.39.5