From 68f2569be422634fae7f32eba8056e90fffe9684 Mon Sep 17 00:00:00 2001 From: Julien HENRY Date: Wed, 10 Jul 2013 12:38:34 +0200 Subject: [PATCH] Fix some quality flaws --- .../src/main/java/org/sonar/api/measures/Measure.java | 6 ++++-- .../src/main/java/org/sonar/api/measures/Metric.java | 2 +- .../src/main/java/org/sonar/api/measures/RuleMeasure.java | 2 +- 3 files changed, 6 insertions(+), 4 deletions(-) diff --git a/sonar-plugin-api/src/main/java/org/sonar/api/measures/Measure.java b/sonar-plugin-api/src/main/java/org/sonar/api/measures/Measure.java index 2fa7cc9a326..f8b135458ca 100644 --- a/sonar-plugin-api/src/main/java/org/sonar/api/measures/Measure.java +++ b/sonar-plugin-api/src/main/java/org/sonar/api/measures/Measure.java @@ -24,6 +24,8 @@ import org.apache.commons.lang.builder.ReflectionToStringBuilder; import org.apache.commons.lang.math.NumberUtils; import org.sonar.api.qualitymodel.Characteristic; +import javax.annotation.Nullable; + import java.math.BigDecimal; import java.math.RoundingMode; import java.util.Date; @@ -246,7 +248,7 @@ public class Measure { * @param v the measure value * @return the measure object instance */ - public Measure setValue(Double v) { + public Measure setValue(@Nullable Double v) { return setValue(v, DEFAULT_PRECISION); } @@ -272,7 +274,7 @@ public class Measure { * @param precision the measure value precision * @return the measure object instance */ - public Measure setValue(Double v, int precision) { + public Measure setValue(@Nullable Double v, int precision) { if (v != null) { if (Double.isNaN(v)) { throw new IllegalArgumentException("Measure value can not be NaN"); diff --git a/sonar-plugin-api/src/main/java/org/sonar/api/measures/Metric.java b/sonar-plugin-api/src/main/java/org/sonar/api/measures/Metric.java index 081bb09df62..56c13b2db18 100644 --- a/sonar-plugin-api/src/main/java/org/sonar/api/measures/Metric.java +++ b/sonar-plugin-api/src/main/java/org/sonar/api/measures/Metric.java @@ -274,7 +274,7 @@ public class Metric implements ServerExtension, BatchExtension { /** * For internal use only */ - public Metric setId(Integer id) { + public Metric setId(@Nullable Integer id) { this.id = id; return this; } diff --git a/sonar-plugin-api/src/main/java/org/sonar/api/measures/RuleMeasure.java b/sonar-plugin-api/src/main/java/org/sonar/api/measures/RuleMeasure.java index cf33a84c0ff..f4ba8db90ba 100644 --- a/sonar-plugin-api/src/main/java/org/sonar/api/measures/RuleMeasure.java +++ b/sonar-plugin-api/src/main/java/org/sonar/api/measures/RuleMeasure.java @@ -121,7 +121,7 @@ public class RuleMeasure extends Measure { } @Override - public RuleMeasure setValue(Double v) { + public RuleMeasure setValue(@Nullable Double v) { return (RuleMeasure) super.setValue(v); } -- 2.39.5