From 6ab243383fc6c037289afc9390f73f5b1fe92f45 Mon Sep 17 00:00:00 2001
From: David Gageot <david@gageot.net>
Date: Thu, 5 Jul 2012 10:02:41 +0200
Subject: [PATCH] Fix html input syntax

---
 .../org/sonar/plugins/core/widgets/complexity.html.erb |  8 ++++----
 .../plugins/core/widgets/test_complexity.html.erb      |  8 ++++----
 .../webapp/WEB-INF/app/views/alerts/_edit.html.erb     |  2 +-
 .../main/webapp/WEB-INF/app/views/alerts/_new.html.erb |  2 +-
 .../WEB-INF/app/views/dependencies/index.html.erb      |  2 +-
 .../WEB-INF/app/views/filters/_criterion.html.erb      |  2 +-
 .../WEB-INF/app/views/filters/_customize_list.html.erb |  6 +++---
 .../webapp/WEB-INF/app/views/profiles/index.html.erb   | 10 +++++-----
 .../WEB-INF/app/views/profiles/projects.html.erb       |  4 ++--
 .../app/views/project_roles/edit_groups.html.erb       |  4 ++--
 .../app/views/rules_configuration/edit.html.erb        |  8 ++++----
 .../WEB-INF/app/views/rules_configuration/new.html.erb |  6 +++---
 .../app/views/updatecenter/_operations.html.erb        |  4 ++--
 .../WEB-INF/app/views/updatecenter/available.html.erb  |  4 ++--
 .../WEB-INF/app/views/updatecenter/index.html.erb      |  2 +-
 .../app/views/updatecenter/system_updates.html.erb     |  4 ++--
 .../WEB-INF/app/views/updatecenter/updates.html.erb    |  2 +-
 .../main/webapp/WEB-INF/app/views/users/new.html.erb   |  8 ++++----
 18 files changed, 43 insertions(+), 43 deletions(-)

diff --git a/plugins/sonar-core-plugin/src/main/resources/org/sonar/plugins/core/widgets/complexity.html.erb b/plugins/sonar-core-plugin/src/main/resources/org/sonar/plugins/core/widgets/complexity.html.erb
index 3eb807b0847..f443933d80e 100644
--- a/plugins/sonar-core-plugin/src/main/resources/org/sonar/plugins/core/widgets/complexity.html.erb
+++ b/plugins/sonar-core-plugin/src/main/resources/org/sonar/plugins/core/widgets/complexity.html.erb
@@ -85,25 +85,25 @@ complexity=measure('complexity')
  if function_distribution
    count_dist+=1
  %>
-<input type="radio" name="cmp_dist" value="function_complexity_distribution" id="cmp_dist_function_complexity_distribution" onClick="selectComplexity('function_complexity_distribution');" <%= 'checked' if function_distribution==selected_distribution -%>></input> <label for="cmp_dist_function_complexity_distribution"><%= message('metric.functions.name') -%></label>
+<input type="radio" name="cmp_dist" value="function_complexity_distribution" id="cmp_dist_function_complexity_distribution" onClick="selectComplexity('function_complexity_distribution');" <%= 'checked' if function_distribution==selected_distribution -%>/> <label for="cmp_dist_function_complexity_distribution"><%= message('metric.functions.name') -%></label>
 <%
 end
 if paragraph_distribution
   count_dist+=1
 %>
-<input type="radio" name="cmp_dist" value="paragraph_complexity_distribution" id="cmp_dist_paragraph_complexity_distribution" onClick="selectComplexity('paragraph_complexity_distribution');" <%= 'checked' if paragraph_distribution==selected_distribution -%>></input> <label for="cmp_dist_paragraph_complexity_distribution"><%= message('metric.paragraphs.name') -%></label><%= '<br/>' if count_dist==2 %>
+<input type="radio" name="cmp_dist" value="paragraph_complexity_distribution" id="cmp_dist_paragraph_complexity_distribution" onClick="selectComplexity('paragraph_complexity_distribution');" <%= 'checked' if paragraph_distribution==selected_distribution -%>/> <label for="cmp_dist_paragraph_complexity_distribution"><%= message('metric.paragraphs.name') -%></label><%= '<br/>' if count_dist==2 %>
 <%
 end
 if class_distribution
   count_dist+=1
 %>
-<input type="radio" name="cmp_dist" value="class_complexity_distribution" id="cmp_dist_class_complexity_distribution" onClick="selectComplexity('class_complexity_distribution');" <%= 'checked' if class_distribution==selected_distribution -%>></input> <label for="cmp_dist_class_complexity_distribution"><%= message('metric.classes.name') -%></label><%= '<br/>' if count_dist==2 %>
+<input type="radio" name="cmp_dist" value="class_complexity_distribution" id="cmp_dist_class_complexity_distribution" onClick="selectComplexity('class_complexity_distribution');" <%= 'checked' if class_distribution==selected_distribution -%>/> <label for="cmp_dist_class_complexity_distribution"><%= message('metric.classes.name') -%></label><%= '<br/>' if count_dist==2 %>
 <%
 end
 if file_distribution
    count_dist+=1
 %>
-<input type="radio" name="cmp_dist" value="file_complexity_distribution" id="cmp_dist_file_complexity_distribution" onClick="selectComplexity('file_complexity_distribution');" <%= 'checked' if file_distribution==selected_distribution -%>></input> <label for="cmp_dist_file_complexity_distribution"><%= message('metric.files.name') -%></label>
+<input type="radio" name="cmp_dist" value="file_complexity_distribution" id="cmp_dist_file_complexity_distribution" onClick="selectComplexity('file_complexity_distribution');" <%= 'checked' if file_distribution==selected_distribution -%>/> <label for="cmp_dist_file_complexity_distribution"><%= message('metric.files.name') -%></label>
 <% end %>
 
  </form>
diff --git a/plugins/sonar-core-plugin/src/main/resources/org/sonar/plugins/core/widgets/test_complexity.html.erb b/plugins/sonar-core-plugin/src/main/resources/org/sonar/plugins/core/widgets/test_complexity.html.erb
index 3eb807b0847..f443933d80e 100644
--- a/plugins/sonar-core-plugin/src/main/resources/org/sonar/plugins/core/widgets/test_complexity.html.erb
+++ b/plugins/sonar-core-plugin/src/main/resources/org/sonar/plugins/core/widgets/test_complexity.html.erb
@@ -85,25 +85,25 @@ complexity=measure('complexity')
  if function_distribution
    count_dist+=1
  %>
-<input type="radio" name="cmp_dist" value="function_complexity_distribution" id="cmp_dist_function_complexity_distribution" onClick="selectComplexity('function_complexity_distribution');" <%= 'checked' if function_distribution==selected_distribution -%>></input> <label for="cmp_dist_function_complexity_distribution"><%= message('metric.functions.name') -%></label>
+<input type="radio" name="cmp_dist" value="function_complexity_distribution" id="cmp_dist_function_complexity_distribution" onClick="selectComplexity('function_complexity_distribution');" <%= 'checked' if function_distribution==selected_distribution -%>/> <label for="cmp_dist_function_complexity_distribution"><%= message('metric.functions.name') -%></label>
 <%
 end
 if paragraph_distribution
   count_dist+=1
 %>
-<input type="radio" name="cmp_dist" value="paragraph_complexity_distribution" id="cmp_dist_paragraph_complexity_distribution" onClick="selectComplexity('paragraph_complexity_distribution');" <%= 'checked' if paragraph_distribution==selected_distribution -%>></input> <label for="cmp_dist_paragraph_complexity_distribution"><%= message('metric.paragraphs.name') -%></label><%= '<br/>' if count_dist==2 %>
+<input type="radio" name="cmp_dist" value="paragraph_complexity_distribution" id="cmp_dist_paragraph_complexity_distribution" onClick="selectComplexity('paragraph_complexity_distribution');" <%= 'checked' if paragraph_distribution==selected_distribution -%>/> <label for="cmp_dist_paragraph_complexity_distribution"><%= message('metric.paragraphs.name') -%></label><%= '<br/>' if count_dist==2 %>
 <%
 end
 if class_distribution
   count_dist+=1
 %>
-<input type="radio" name="cmp_dist" value="class_complexity_distribution" id="cmp_dist_class_complexity_distribution" onClick="selectComplexity('class_complexity_distribution');" <%= 'checked' if class_distribution==selected_distribution -%>></input> <label for="cmp_dist_class_complexity_distribution"><%= message('metric.classes.name') -%></label><%= '<br/>' if count_dist==2 %>
+<input type="radio" name="cmp_dist" value="class_complexity_distribution" id="cmp_dist_class_complexity_distribution" onClick="selectComplexity('class_complexity_distribution');" <%= 'checked' if class_distribution==selected_distribution -%>/> <label for="cmp_dist_class_complexity_distribution"><%= message('metric.classes.name') -%></label><%= '<br/>' if count_dist==2 %>
 <%
 end
 if file_distribution
    count_dist+=1
 %>
-<input type="radio" name="cmp_dist" value="file_complexity_distribution" id="cmp_dist_file_complexity_distribution" onClick="selectComplexity('file_complexity_distribution');" <%= 'checked' if file_distribution==selected_distribution -%>></input> <label for="cmp_dist_file_complexity_distribution"><%= message('metric.files.name') -%></label>
+<input type="radio" name="cmp_dist" value="file_complexity_distribution" id="cmp_dist_file_complexity_distribution" onClick="selectComplexity('file_complexity_distribution');" <%= 'checked' if file_distribution==selected_distribution -%>/> <label for="cmp_dist_file_complexity_distribution"><%= message('metric.files.name') -%></label>
 <% end %>
 
  </form>
diff --git a/sonar-server/src/main/webapp/WEB-INF/app/views/alerts/_edit.html.erb b/sonar-server/src/main/webapp/WEB-INF/app/views/alerts/_edit.html.erb
index 72a26668db3..273f8c23a7d 100644
--- a/sonar-server/src/main/webapp/WEB-INF/app/views/alerts/_edit.html.erb
+++ b/sonar-server/src/main/webapp/WEB-INF/app/views/alerts/_edit.html.erb
@@ -20,7 +20,7 @@
     <%= value_field(alert, alert.value_error, 'alert[value_error]') %> <%= alert.metric.suffix if alert.metric %>
   </td>
   <td width="120px" nowrap>
-    <input id="alert_submit" type="submit" value="<%= message('update_verb') -%>"></input>
+    <input id="alert_submit" type="submit" value="<%= message('update_verb') -%>"/>
     <%= link_to message('delete'), {:action => 'delete', :id => alert.id, :profile_id =>@profile.id}, :confirm => message('are_you_sure'), :method => :post, :class => 'action', :id => "delete_#{u alert.name}" %>
   </td>
 </tr>
diff --git a/sonar-server/src/main/webapp/WEB-INF/app/views/alerts/_new.html.erb b/sonar-server/src/main/webapp/WEB-INF/app/views/alerts/_new.html.erb
index e877483affe..028a58d9691 100644
--- a/sonar-server/src/main/webapp/WEB-INF/app/views/alerts/_new.html.erb
+++ b/sonar-server/src/main/webapp/WEB-INF/app/views/alerts/_new.html.erb
@@ -49,7 +49,7 @@
   </td>
 
   <td width="120px" nowrap valign="top">
-    <input type="submit" value="<%= message('create') -%>" id="submit_create"></input>
+    <input type="submit" value="<%= message('create') -%>" id="submit_create"/>
   </td>
 </tr>
 </table>
diff --git a/sonar-server/src/main/webapp/WEB-INF/app/views/dependencies/index.html.erb b/sonar-server/src/main/webapp/WEB-INF/app/views/dependencies/index.html.erb
index 0535341e2ca..631e84f3563 100644
--- a/sonar-server/src/main/webapp/WEB-INF/app/views/dependencies/index.html.erb
+++ b/sonar-server/src/main/webapp/WEB-INF/app/views/dependencies/index.html.erb
@@ -25,7 +25,7 @@ padding: 5px;
 </style>
 <form action="<%= ApplicationController.root_context -%>/dependencies/index" id="search_form">
   <input type="text" name="search" value="<%= params[:search] -%>" id="search_input"> </input>
-  <input type="submit" value="<%= message('dependencies.search_library') -%>" id="search_submit"></input><br/>
+  <input type="submit" value="<%= message('dependencies.search_library') -%>" id="search_submit"/><br/>
   <p class="small gray"><%= message('dependencies.search_help') -%></p>
 </form>
 
diff --git a/sonar-server/src/main/webapp/WEB-INF/app/views/filters/_criterion.html.erb b/sonar-server/src/main/webapp/WEB-INF/app/views/filters/_criterion.html.erb
index 34d80b2abce..f1c6c016dcb 100644
--- a/sonar-server/src/main/webapp/WEB-INF/app/views/filters/_criterion.html.erb
+++ b/sonar-server/src/main/webapp/WEB-INF/app/views/filters/_criterion.html.erb
@@ -28,5 +28,5 @@
   <option value=">" <%= 'selected' if (criterion && criterion.operator=='>') -%>><%= message('greater_than') -%></option>
   <option value=">=" <%= 'selected' if (criterion && criterion.operator=='>=') -%>><%= message('greater_or_equals') -%></option>
 </select>
-<input type="text" name="criteria[<%= id -%>][value]" size="5" value="<%= criterion.value if criterion -%>" id="val-<%= id -%>"></input>
+<input type="text" name="criteria[<%= id -%>][value]" size="5" value="<%= criterion.value if criterion -%>" id="val-<%= id -%>"/>
 <a href="#" onClick="reset_criterion(<%= id -%>);return false;"><%= message('reset_verb') -%></a>
\ No newline at end of file
diff --git a/sonar-server/src/main/webapp/WEB-INF/app/views/filters/_customize_list.html.erb b/sonar-server/src/main/webapp/WEB-INF/app/views/filters/_customize_list.html.erb
index 34d2879e6e3..59f7e5313af 100644
--- a/sonar-server/src/main/webapp/WEB-INF/app/views/filters/_customize_list.html.erb
+++ b/sonar-server/src/main/webapp/WEB-INF/app/views/filters/_customize_list.html.erb
@@ -27,7 +27,7 @@
         </optgroup>
       <% end %>
     </select>
-    <input type="submit" id="add_column_button" value="<%= message('add_verb') -%>"></input>
+    <input type="submit" id="add_column_button" value="<%= message('add_verb') -%>"/>
     </form>
   </td>
 </tr>
@@ -55,8 +55,8 @@
   <td class="keyCell"><%= message('page_size') -%>:</td>
   <td>
     <form id="page_size_form" action="<%= url_for :action => 'set_page_size' -%>" method="post">
-      <input type="hidden" name="id" value="<%= @filter.id -%>"></input>
-      <input type="text" name="size" value="<%= @filter.page_size -%>" maxsize="3" size="3"></input>
+      <input type="hidden" name="id" value="<%= @filter.id -%>"/>
+      <input type="text" name="size" value="<%= @filter.page_size -%>" maxsize="3" size="3"/>
       <input type="submit" id="set_page_size_submit" value="<%= message('change_verb') -%>"/>
       <span class="comments"><%= message('min') -%> <%= ::Filter::MIN_PAGE_SIZE -%>, <%= message('max').downcase -%> <%= ::Filter::MAX_PAGE_SIZE -%></span>
    </td>
diff --git a/sonar-server/src/main/webapp/WEB-INF/app/views/profiles/index.html.erb b/sonar-server/src/main/webapp/WEB-INF/app/views/profiles/index.html.erb
index 10f67a4e247..f107558bf23 100644
--- a/sonar-server/src/main/webapp/WEB-INF/app/views/profiles/index.html.erb
+++ b/sonar-server/src/main/webapp/WEB-INF/app/views/profiles/index.html.erb
@@ -50,17 +50,17 @@
 
 <% if administrator? %>
   <form class="admin" id="create-form-<%= language.getKey()-%>" action="<%= url_for :action => 'create' -%>" style="display: none" enctype="multipart/form-data" method="post">
-    <input type="hidden" name="language" value="<%= language.getKey() -%>"></input>
+    <input type="hidden" name="language" value="<%= language.getKey() -%>"/>
     <table class="spaced width100">
       <tr>
         <td width="1%" nowrap><%= message('name') -%>: </td>
-        <td><input type="text" name="name" id="create-form-<%= language.getKey()-%>-name"></input></td>
+        <td><input type="text" name="name" id="create-form-<%= language.getKey()-%>-name"/></td>
       </tr>
       <% importers.to_a.sort{|x,y| x.getName() <=> y.getName()}.each do |importer| %>
       <tr>
         <td width="1%" nowrap><%= importer.getName() -%>: </td>
         <td>
-          <%= file_field_tag "backup[#{importer.getKey()}]" %></input>
+          <%= file_field_tag "backup[#{importer.getKey()}]" %>
           <span class="note"><%= message('quality_profiles.optional_configuration_file') -%></span>
         </td>
       </tr>
@@ -68,7 +68,7 @@
 
       <tr>
         <td colspan="2">
-          <input type="submit" value="<%= message('quality_profiles.create_x_language_profile', :params => language.getName()) -%>" id="create-submit-<%= language.getKey() -%>"></input>
+          <input type="submit" value="<%= message('quality_profiles.create_x_language_profile', :params => language.getName()) -%>" id="create-submit-<%= language.getKey() -%>"/>
           <a href="#" onclick="$('create-form-<%= language.getKey()-%>').reset();$('create-form-<%= language.getKey()-%>').hide();return false;"><%= message('cancel') -%></a>
         </td>
       </tr>
@@ -124,7 +124,7 @@
          <td align="right">
           <% if !profile.provided? %>
              <% form_tag(:action => 'backup', :id => profile.id) do -%>
-              <input type="submit" name="button_backup" id="backup_<%= u profile.key %>" value="<%= message('backup_verb') -%>"></input>
+              <input type="submit" name="button_backup" id="backup_<%= u profile.key %>" value="<%= message('backup_verb') -%>"/>
             <% end
             end %>
         </td>
diff --git a/sonar-server/src/main/webapp/WEB-INF/app/views/profiles/projects.html.erb b/sonar-server/src/main/webapp/WEB-INF/app/views/profiles/projects.html.erb
index dec38c67172..8a155a8adbd 100644
--- a/sonar-server/src/main/webapp/WEB-INF/app/views/profiles/projects.html.erb
+++ b/sonar-server/src/main/webapp/WEB-INF/app/views/profiles/projects.html.erb
@@ -4,7 +4,7 @@
 <div class="tabs-panel">
 <% if is_admin? %>
 <form action="<%= url_for :action => 'set_projects' -%>" method="post" id="select_projects_form">
-  <input type="hidden" name="id" value="<%= @profile.id -%>"></input>
+  <input type="hidden" name="id" value="<%= @profile.id -%>"/>
 <table>
   <tr>
     <td style="padding: 5px 0" valign="top">
@@ -27,7 +27,7 @@
       <%= options_from_collection_for_select(@profile.projects, "id", "name") %>
       </select><br/>
     <div style="padding:5px 0">
-	   <input type="submit" id="save" value="<%= message('save') -%>" onclick="SelectBox.select_all('to');submit();"></input>
+	   <input type="submit" id="save" value="<%= message('save') -%>" onclick="SelectBox.select_all('to');submit();"/>
 	  </div>
   </td>
 </tr>
diff --git a/sonar-server/src/main/webapp/WEB-INF/app/views/project_roles/edit_groups.html.erb b/sonar-server/src/main/webapp/WEB-INF/app/views/project_roles/edit_groups.html.erb
index 79dc598dbce..26546c894d4 100644
--- a/sonar-server/src/main/webapp/WEB-INF/app/views/project_roles/edit_groups.html.erb
+++ b/sonar-server/src/main/webapp/WEB-INF/app/views/project_roles/edit_groups.html.erb
@@ -7,8 +7,8 @@
 <br/>
 <div>
   <form action="<%= url_for :action => 'grant_groups' -%>" method="post">
-    <input name="resource" value="<%= @project.id -%>" type="hidden"></input>
-    <input name="role" value="<%= @role -%>" type="hidden"></input>
+    <input name="resource" value="<%= @project.id -%>" type="hidden"/>
+    <input name="role" value="<%= @role -%>" type="hidden"/>
     <table>
       <tbody>
         <tr>
diff --git a/sonar-server/src/main/webapp/WEB-INF/app/views/rules_configuration/edit.html.erb b/sonar-server/src/main/webapp/WEB-INF/app/views/rules_configuration/edit.html.erb
index 63990f20cd0..408e3d325c6 100644
--- a/sonar-server/src/main/webapp/WEB-INF/app/views/rules_configuration/edit.html.erb
+++ b/sonar-server/src/main/webapp/WEB-INF/app/views/rules_configuration/edit.html.erb
@@ -28,7 +28,7 @@
   <tr>
     <td width="1%" nowrap><%= message('name') -%>:</td>
     <td class="sep"> </td>
-    <td><input type="text" name="rule[name]" size="80" value="<%= h @rule.name -%>"></input></td>
+    <td><input type="text" name="rule[name]" size="80" value="<%= h @rule.name -%>" /></td>
   </tr>
   <tr>
     <td width="1%" nowrap><%= message('default_severity') -%>:</td>
@@ -44,7 +44,7 @@
       <td width="1%" nowrap><%= parameter.name %>:</td>
       <td class="sep"> </td>
       <td>
-        <input type="text" name="rule_param[<%= u parameter.name -%>]" value="<%= h parameter.default_value -%>"></input>
+        <input type="text" name="rule_param[<%= u parameter.name -%>]" value="<%= h parameter.default_value -%>" />
         <span class="small"><%= parameter.description %></span>
       </td>
     </tr>
@@ -59,8 +59,8 @@
   </tr>
   <tr>
     <td colspan="3">
-      <input type="submit" value="<%= message('update_verb') -%>"></input>
-      <input type="submit" value="<%= message('delete') -%>" onclick="return deleteRule()" class="red-button"></input>
+      <input type="submit" value="<%= message('update_verb') -%>" />
+      <input type="submit" value="<%= message('delete') -%>" onclick="return deleteRule()" class="red-button" />
       <a href="<%= url_for :action => 'index', :id => @profile.id -%>"><%= message('cancel') -%></a>
     </td>
   </tr>
diff --git a/sonar-server/src/main/webapp/WEB-INF/app/views/rules_configuration/new.html.erb b/sonar-server/src/main/webapp/WEB-INF/app/views/rules_configuration/new.html.erb
index fc3374104f0..5eb908c96f0 100644
--- a/sonar-server/src/main/webapp/WEB-INF/app/views/rules_configuration/new.html.erb
+++ b/sonar-server/src/main/webapp/WEB-INF/app/views/rules_configuration/new.html.erb
@@ -14,7 +14,7 @@
   <tr>
     <td width="1%" nowrap><%= message('name') -%>:</td>
     <td class="sep"> </td>
-    <td><input type="text" name="rule[name]" size="80"></input></td>
+    <td><input type="text" name="rule[name]" size="80"/></td>
   </tr>
   <tr>
     <td width="1%" nowrap><%= message('default_severity') -%>:</td>
@@ -30,7 +30,7 @@
       <td width="1%" nowrap><%= parameter.name %>:</td>
       <td class="sep"> </td>
       <td>
-        <input type="text" name="rule_param[<%= parameter.name -%>]" value=""></input>
+        <input type="text" name="rule_param[<%= parameter.name -%>]" value=""/>
         <span class="small"><%= parameter.description %></span>
       </td>
     </tr>
@@ -45,7 +45,7 @@
   </tr>
   <tr>
     <td colspan="3">
-      <input type="submit" value="<%= message('create') -%>"></input> <a href="<%= url_for :action => 'index', :id => @profile.id -%>"><%= message('cancel') -%></a>
+      <input type="submit" value="<%= message('create') -%>"/> <a href="<%= url_for :action => 'index', :id => @profile.id -%>"><%= message('cancel') -%></a>
     </td>
   </tr>
 </table>
diff --git a/sonar-server/src/main/webapp/WEB-INF/app/views/updatecenter/_operations.html.erb b/sonar-server/src/main/webapp/WEB-INF/app/views/updatecenter/_operations.html.erb
index 6798933c73c..dec69e8c8f8 100644
--- a/sonar-server/src/main/webapp/WEB-INF/app/views/updatecenter/_operations.html.erb
+++ b/sonar-server/src/main/webapp/WEB-INF/app/views/updatecenter/_operations.html.erb
@@ -16,7 +16,7 @@
     <li><%= uninstall -%></li>
   <% end %>
   </ul>
-  <input type="submit" value="Cancel uninstalls"></input>
+  <input type="submit" value="Cancel uninstalls"/>
 </p>
 </form>
 <% end %>
@@ -28,7 +28,7 @@
     <li><%= download -%></li>
   <% end %>
   </ul>
-  <input type="submit" value="Cancel pending installations"></input>
+  <input type="submit" value="Cancel pending installations"/>
 </p>
 </form>
 <% end %>
diff --git a/sonar-server/src/main/webapp/WEB-INF/app/views/updatecenter/available.html.erb b/sonar-server/src/main/webapp/WEB-INF/app/views/updatecenter/available.html.erb
index 0e82b72feef..d96b398f17a 100644
--- a/sonar-server/src/main/webapp/WEB-INF/app/views/updatecenter/available.html.erb
+++ b/sonar-server/src/main/webapp/WEB-INF/app/views/updatecenter/available.html.erb
@@ -71,10 +71,10 @@ function installPlugin(key) {
             <tr>
               <td colspan="2">
               <% if plugin.getTermsConditionsUrl() %>
-              <input type="checkbox" id="tc-<%= plugin.getKey() -%>"></input> I accept the <%= link_to 'Terms and Conditions', plugin.getTermsConditionsUrl(), :class => 'external' %>
+              <input type="checkbox" id="tc-<%= plugin.getKey() -%>"/> I accept the <%= link_to 'Terms and Conditions', plugin.getTermsConditionsUrl(), :class => 'external' %>
               <% end %>
               <form method="post" action="<%= ApplicationController.root_context -%>/updatecenter/install?from=available&key=<%= plugin.getKey() -%>&version=<%= update.getRelease().getVersion() -%>" style="display: inline-block" id="install-form-<%= plugin.getKey() -%>">
-                <input type="submit" value="Install" onClick="installPlugin('<%= plugin.getKey() -%>');return false;" id="submit-<%= plugin.getKey() -%>"></input>
+                <input type="submit" value="Install" onClick="installPlugin('<%= plugin.getKey() -%>');return false;" id="submit-<%= plugin.getKey() -%>"/>
               </form>
             </td>
             </tr>
diff --git a/sonar-server/src/main/webapp/WEB-INF/app/views/updatecenter/index.html.erb b/sonar-server/src/main/webapp/WEB-INF/app/views/updatecenter/index.html.erb
index 710b6071d8a..7f3e3191e01 100644
--- a/sonar-server/src/main/webapp/WEB-INF/app/views/updatecenter/index.html.erb
+++ b/sonar-server/src/main/webapp/WEB-INF/app/views/updatecenter/index.html.erb
@@ -46,7 +46,7 @@
           <tr>
             <td colspan="2">
              <form method="post" action="<%= ApplicationController.root_context -%>/updatecenter/uninstall?key=<%= plugin.getKey() -%>" style="display: inline-block">
-               <input type="submit" value="Uninstall" class="red-button"></input>
+               <input type="submit" value="Uninstall" class="red-button"/>
              </form>
               </td>
             </tr>
diff --git a/sonar-server/src/main/webapp/WEB-INF/app/views/updatecenter/system_updates.html.erb b/sonar-server/src/main/webapp/WEB-INF/app/views/updatecenter/system_updates.html.erb
index 1c71d8c1649..a52a6d89968 100644
--- a/sonar-server/src/main/webapp/WEB-INF/app/views/updatecenter/system_updates.html.erb
+++ b/sonar-server/src/main/webapp/WEB-INF/app/views/updatecenter/system_updates.html.erb
@@ -66,14 +66,14 @@
                    <% update.getIncompatiblePlugins().each do |incompatible_plugin| %>
                       <li>
                       <form method="post" action="<%= ApplicationController.root_context -%>/updatecenter/uninstall?key=<%= incompatible_plugin.getKey() -%>&amp;from=system_updates" style="display: inline-block">
-                        <%= image_tag 'warning.png' -%> <input type="submit" value="Uninstall" class="red-button" onClick="return submitForm(this);"></input> the plugin <%= incompatible_plugin.getName() -%> which is not compatible with Sonar <%= release.getVersion() -%>.
+                        <%= image_tag 'warning.png' -%> <input type="submit" value="Uninstall" class="red-button" onClick="return submitForm(this);"/> the plugin <%= incompatible_plugin.getName() -%> which is not compatible with Sonar <%= release.getVersion() -%>.
                       </form>
                    </li>
              <% end %>
            <% update.getPluginsToUpgrade().each do |plugin_to_upgrade| %>
                    <li>
                     <form method="post" id="upgrade-form-<%= plugin_to_upgrade.getArtifact().getKey() -%>" action="<%= ApplicationController.root_context -%>/updatecenter/install?key=<%= plugin_to_upgrade.getArtifact().getKey() -%>&amp;version=<%= plugin_to_upgrade.getVersion() -%>&amp;from=system_updates" style="display: inline-block">
-                      <input type="submit" id="upgrade-submit-<%= plugin_to_upgrade.getArtifact().getKey() -%>" value="Upgrade" onClick="return submitForm(this);"></input>
+                      <input type="submit" id="upgrade-submit-<%= plugin_to_upgrade.getArtifact().getKey() -%>" value="Upgrade" onClick="return submitForm(this);"/>
                       the plugin <%= plugin_to_upgrade.getArtifact().getName() -%> to version <%= plugin_to_upgrade.getVersion() -%>
                     </form>
                  </li>
diff --git a/sonar-server/src/main/webapp/WEB-INF/app/views/updatecenter/updates.html.erb b/sonar-server/src/main/webapp/WEB-INF/app/views/updatecenter/updates.html.erb
index d7b3e30696f..1966fd95241 100644
--- a/sonar-server/src/main/webapp/WEB-INF/app/views/updatecenter/updates.html.erb
+++ b/sonar-server/src/main/webapp/WEB-INF/app/views/updatecenter/updates.html.erb
@@ -53,7 +53,7 @@ function upgradePlugin(key) {
          <td> </td>
          <td colspan="5">
           <form method="post" id="upgrade-form-<%= plugin.getKey() -%>" action="<%= ApplicationController.root_context -%>/updatecenter/install?from=updates&key=<%= plugin.getKey() -%>&version=<%= @last_compatible[plugin.getKey()] -%>" style="display: inline-block">
-             <input type="submit" id="upgrade-submit-<%= plugin.getKey() -%>" value="Upgrade to <%= @last_compatible[plugin.getKey()] -%>" onClick="upgradePlugin('<%= plugin.getKey() -%>');return false;"></input>
+             <input type="submit" id="upgrade-submit-<%= plugin.getKey() -%>" value="Upgrade to <%= @last_compatible[plugin.getKey()] -%>" onClick="upgradePlugin('<%= plugin.getKey() -%>');return false;"/>
            </form>
           </td>
         </tr>
diff --git a/sonar-server/src/main/webapp/WEB-INF/app/views/users/new.html.erb b/sonar-server/src/main/webapp/WEB-INF/app/views/users/new.html.erb
index 8c775b96406..e53d6638f74 100644
--- a/sonar-server/src/main/webapp/WEB-INF/app/views/users/new.html.erb
+++ b/sonar-server/src/main/webapp/WEB-INF/app/views/users/new.html.erb
@@ -5,20 +5,20 @@
         <form action="<%= url_for :controller => 'users', :action => 'signup' -%>" method="post">
           <h3><%= label_tag 'user_login', message('login') %></h3>
           <p>
-            <input id="user_login" name="user[login]" size="30" type="text" ></input>
+            <input id="user_login" name="user[login]" size="30" type="text"/>
             <br/><span class="desc"><%= message('sessions.old_account', :params => [url_for(:controller => 'sessions', :action => 'new')]) -%></span>
           </p>
 
           <h3><%= label_tag 'user_name', message('name') %></h3>
           <p>
-            <input id="user_name" name="user[name]" size="30" type="text" ></input>
+            <input id="user_name" name="user[name]" size="30" type="text"/>
           </p>
           <h3><%= label_tag 'user_password', message('password') %></h3>
-          <p><input id="user_password" maxLength="50" name="user[password]" size="30" type="password"></input></p>
+          <p><input id="user_password" maxLength="50" name="user[password]" size="30" type="password"/></p>
 
           <h3><%= label_tag 'user_password_confirmation', message('sessions.confirm_password') %></h3>
           <p>
-            <input id="user_password_confirmation" maxLength="50" name="user[password_confirmation]" size="30" type="password"></input>
+            <input id="user_password_confirmation" maxLength="50" name="user[password_confirmation]" size="30" type="password"/>
           </p>
           <p>
             <%= submit_tag message('sessions.sign_up') %> <a href="<%= home_path -%>" class="action"><%= message('cancel') -%></a>
-- 
2.39.5