From 6acc0f48f6b546a25af466b857f79b15ac14f779 Mon Sep 17 00:00:00 2001
From: Fabrice Bellingard <bellingard@gmail.com>
Date: Thu, 28 Apr 2011 16:38:09 +0200
Subject: [PATCH] SONAR-2327 Improve rendering for violations when source code
 is missing

---
 sonar-server/src/main/webapp/stylesheets/style.css    | 11 ++++++-----
 .../resources/violations/violation-with-review.json   |  1 +
 2 files changed, 7 insertions(+), 5 deletions(-)
 create mode 100644 sonar-ws-client/src/test/resources/violations/violation-with-review.json

diff --git a/sonar-server/src/main/webapp/stylesheets/style.css b/sonar-server/src/main/webapp/stylesheets/style.css
index b00b47bc7a8..0522dbe0b64 100644
--- a/sonar-server/src/main/webapp/stylesheets/style.css
+++ b/sonar-server/src/main/webapp/stylesheets/style.css
@@ -673,13 +673,13 @@ ul.operations li img {
   margin:0;
   border: 1px solid #DDD;
 }
-.sources2 div.violation .actions{
+.sources2 div.violation .actions, #global_violations div.violation .actions {
   visibility: hidden;
 }
-.sources2 div.violation:hover .actions{
+.sources2 div.violation:hover .actions, #global_violations div.violation:hover .actions {
   visibility: visible;
 }
-.sources2 div.violation .actions form {
+.sources2 div.violation .actions form, #global_violations div.violation .actions form {
   display: inline;
 }
 div.vtitle{
@@ -770,11 +770,12 @@ span.rulename a:hover {
 }
 #global_violations {
   width: 100%;
-  border: 1px solid #DDD;
   margin-bottom: 10px;
 }
+#global_violations > tbody > tr > td {
+  padding-bottom: 10px;
+}
 #global_violations td {
-  background-color: #ECECEC;
   padding: 3px 0.5em;
 }
 #global_violations td img, #source_title img {
diff --git a/sonar-ws-client/src/test/resources/violations/violation-with-review.json b/sonar-ws-client/src/test/resources/violations/violation-with-review.json
new file mode 100644
index 00000000000..4de5df67356
--- /dev/null
+++ b/sonar-ws-client/src/test/resources/violations/violation-with-review.json
@@ -0,0 +1 @@
+[{"message":"'static' modifier out of order with the JLS suggestions.","line":33,"priority":"MINOR","createdAt":"2011-04-26T15:17:46+0200","rule":{"key":"checkstyle:com.puppycrawl.tools.checkstyle.checks.modifier.ModifierOrderCheck","name":"Modifier Order"},"resource":{"key":"org.codehaus.sonar:sonar-channel:org.sonar.channel.CodeReaderConfiguration","name":"CodeReaderConfiguration","scope":"FIL","qualifier":"CLA","language":"java"},"review":{"id":3,"createdAt":"2011-04-26T15:44:42+0200","updatedAt":"2011-04-26T15:44:42+0200","author":"admin","assignee":"admin","title":"'static' modifier out of order with the JLS suggestions.","type":"VIOLATION","status":"OPEN","severity":"MINOR","resource":"org.codehaus.sonar:sonar-channel:org.sonar.channel.CodeReaderConfiguration","line":33,"comments":[{"author":"admin","updatedAt":"2011-04-26T15:44:42+0200","text":"This is a review.<br/>And this is on multiple lines...<br/><br/>''Wouhou!!!!!''"},{"author":"admin","updatedAt":"2011-04-26T17:10:19+0200","text":"<em>Bold on multiple line?</em>"},{"author":"admin","updatedAt":"2011-04-26T17:11:02+0200","text":"And the bullets:<br/><ul><li>1 bullet</li>\n<li>2 bullets</li></ul>"},{"author":"admin","updatedAt":"2011-04-26T17:27:37+0200","text":"Wazzaa"}]}}]
\ No newline at end of file
-- 
2.39.5