From 72fd5fe44fc6d7f13e31cbd196fc18dc573ddd5f Mon Sep 17 00:00:00 2001 From: =?utf8?q?S=C3=A9bastien=20Lesaint?= Date: Wed, 20 Dec 2017 13:57:59 +0100 Subject: [PATCH] SONAR-10085 drop now unused QGChangeEventListeners#isEmpty --- .../changeevent/QGChangeEventListeners.java | 1 - .../QGChangeEventListenersImpl.java | 5 ----- .../QGChangeEventListenersImplTest.java | 21 ------------------- 3 files changed, 27 deletions(-) diff --git a/server/sonar-server/src/main/java/org/sonar/server/qualitygate/changeevent/QGChangeEventListeners.java b/server/sonar-server/src/main/java/org/sonar/server/qualitygate/changeevent/QGChangeEventListeners.java index 1c6b434489f..f3b26ec2510 100644 --- a/server/sonar-server/src/main/java/org/sonar/server/qualitygate/changeevent/QGChangeEventListeners.java +++ b/server/sonar-server/src/main/java/org/sonar/server/qualitygate/changeevent/QGChangeEventListeners.java @@ -22,7 +22,6 @@ package org.sonar.server.qualitygate.changeevent; import java.util.Collection; public interface QGChangeEventListeners { - boolean isEmpty(); void broadcastOnIssueChange(QGChangeEventFactory.IssueChangeData issueChangeData, Collection qgChangeEvents); } diff --git a/server/sonar-server/src/main/java/org/sonar/server/qualitygate/changeevent/QGChangeEventListenersImpl.java b/server/sonar-server/src/main/java/org/sonar/server/qualitygate/changeevent/QGChangeEventListenersImpl.java index 892bd828916..f6047038d2e 100644 --- a/server/sonar-server/src/main/java/org/sonar/server/qualitygate/changeevent/QGChangeEventListenersImpl.java +++ b/server/sonar-server/src/main/java/org/sonar/server/qualitygate/changeevent/QGChangeEventListenersImpl.java @@ -51,11 +51,6 @@ public class QGChangeEventListenersImpl implements QGChangeEventListeners { this.listeners = listeners; } - @Override - public boolean isEmpty() { - return listeners.length == 0; - } - @Override public void broadcastOnIssueChange(QGChangeEventFactory.IssueChangeData issueChangeData, Collection changeEvents) { if (listeners.length == 0 || issueChangeData.getComponents().isEmpty() || issueChangeData.getIssues().isEmpty() || changeEvents.isEmpty()) { diff --git a/server/sonar-server/src/test/java/org/sonar/server/qualitygate/changeevent/QGChangeEventListenersImplTest.java b/server/sonar-server/src/test/java/org/sonar/server/qualitygate/changeevent/QGChangeEventListenersImplTest.java index 64fee2db04e..f96602d71b1 100644 --- a/server/sonar-server/src/test/java/org/sonar/server/qualitygate/changeevent/QGChangeEventListenersImplTest.java +++ b/server/sonar-server/src/test/java/org/sonar/server/qualitygate/changeevent/QGChangeEventListenersImplTest.java @@ -57,27 +57,6 @@ public class QGChangeEventListenersImplTest { private QGChangeEventListenersImpl underTest = new QGChangeEventListenersImpl(new QGChangeEventListener[] {listener1, listener2, listener3}); - @Test - public void isEmpty_returns_true_for_constructor_without_argument() { - QGChangeEventListenersImpl underTest = new QGChangeEventListenersImpl(); - - assertThat(underTest.isEmpty()).isTrue(); - } - - @Test - public void isEmpty_returns_false_for_constructor_with_one_argument() { - QGChangeEventListenersImpl underTest = new QGChangeEventListenersImpl(new QGChangeEventListener[] {listener2}); - - assertThat(underTest.isEmpty()).isFalse(); - } - - @Test - public void isEmpty_returns_false_for_constructor_with_multiple_arguments() { - QGChangeEventListenersImpl underTest = new QGChangeEventListenersImpl(new QGChangeEventListener[] {listener2, listener3}); - - assertThat(underTest.isEmpty()).isFalse(); - } - @Test public void broadcastOnIssueChange_has_no_effect_when_issueChangeData_is_empty() { QGChangeEventFactory.IssueChangeData issueChangeData = new QGChangeEventFactory.IssueChangeData(emptyList(), emptyList()); -- 2.39.5