From 76b1a6fee4c78ec334fbdd729ae5c9d2957ae9c5 Mon Sep 17 00:00:00 2001 From: PJ Fanning Date: Tue, 7 Nov 2023 12:23:53 +0000 Subject: [PATCH] try to fix broken sxssf tests git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1913651 13f79535-47bb-0310-9956-ffa450edef68 --- .../java/org/apache/poi/xssf/streaming/TestSXSSFCell.java | 5 +---- .../poi/xssf/streaming/TestSXSSFFormulaEvaluation.java | 5 ++++- .../test/java/org/apache/poi/ss/usermodel/BaseTestCell.java | 2 +- .../apache/poi/ss/usermodel/BaseTestFormulaEvaluator.java | 2 +- 4 files changed, 7 insertions(+), 7 deletions(-) diff --git a/poi-ooxml/src/test/java/org/apache/poi/xssf/streaming/TestSXSSFCell.java b/poi-ooxml/src/test/java/org/apache/poi/xssf/streaming/TestSXSSFCell.java index 2670a6e291..894bc5c994 100644 --- a/poi-ooxml/src/test/java/org/apache/poi/xssf/streaming/TestSXSSFCell.java +++ b/poi-ooxml/src/test/java/org/apache/poi/xssf/streaming/TestSXSSFCell.java @@ -165,10 +165,7 @@ class TestSXSSFCell extends BaseTestXCell { protected void setCellFormula_onASingleCellArrayFormulaCell_preservesTheValue() { } - @Disabled - protected void setCellFormula_isExceptionSafe_onBlankCell() { - } - + @Override @Disabled protected void setCellType_FORMULA_onAnArrayFormulaCell_doesNothing() { } diff --git a/poi-ooxml/src/test/java/org/apache/poi/xssf/streaming/TestSXSSFFormulaEvaluation.java b/poi-ooxml/src/test/java/org/apache/poi/xssf/streaming/TestSXSSFFormulaEvaluation.java index ac5f209146..63d5f4fcee 100644 --- a/poi-ooxml/src/test/java/org/apache/poi/xssf/streaming/TestSXSSFFormulaEvaluation.java +++ b/poi-ooxml/src/test/java/org/apache/poi/xssf/streaming/TestSXSSFFormulaEvaluation.java @@ -48,7 +48,10 @@ public final class TestSXSSFFormulaEvaluation extends BaseTestFormulaEvaluator super(SXSSFITestDataProvider.instance); } - void testSharedFormulas() throws IOException { + + @Override + @Disabled + protected void testSharedFormulas() throws IOException { /* not implemented */ } diff --git a/poi/src/test/java/org/apache/poi/ss/usermodel/BaseTestCell.java b/poi/src/test/java/org/apache/poi/ss/usermodel/BaseTestCell.java index 71cbfbb7e9..e69b5abbb2 100644 --- a/poi/src/test/java/org/apache/poi/ss/usermodel/BaseTestCell.java +++ b/poi/src/test/java/org/apache/poi/ss/usermodel/BaseTestCell.java @@ -1408,7 +1408,7 @@ public abstract class BaseTestCell { } @Test - void setCellType_FORMULA_onAnArrayFormulaCell_doesNothing() throws IOException { + protected void setCellType_FORMULA_onAnArrayFormulaCell_doesNothing() throws IOException { try (Workbook wb = _testDataProvider.createWorkbook()) { Cell cell = getInstance(wb); cell.getSheet().setArrayFormula("3", CellRangeAddress.valueOf("A1:A2")); diff --git a/poi/src/test/java/org/apache/poi/ss/usermodel/BaseTestFormulaEvaluator.java b/poi/src/test/java/org/apache/poi/ss/usermodel/BaseTestFormulaEvaluator.java index 8f621a1428..def6e2c185 100644 --- a/poi/src/test/java/org/apache/poi/ss/usermodel/BaseTestFormulaEvaluator.java +++ b/poi/src/test/java/org/apache/poi/ss/usermodel/BaseTestFormulaEvaluator.java @@ -117,7 +117,7 @@ public abstract class BaseTestFormulaEvaluator { } @Test - void testSharedFormulas() throws IOException { + protected void testSharedFormulas() throws IOException { String fileName = "shared_formulas.xls" + (getClass().getName().contains("xssf") ? "x" : ""); try (Workbook wb = _testDataProvider.openSampleWorkbook(fileName)) { -- 2.39.5