From 78722ed6c70fbf722c0bd13cd4e41f7fded7cd36 Mon Sep 17 00:00:00 2001 From: Go MAEDA Date: Thu, 20 Jun 2019 13:20:02 +0000 Subject: [PATCH] RuboCop: Disable Metrics git-svn-id: http://svn.redmine.org/redmine/trunk@18292 e93f8b46-1217-0410-a6f0-8f06a7374b81 --- .rubocop.yml | 3 + .rubocop_todo.yml | 309 +--------------------------------------------- 2 files changed, 5 insertions(+), 307 deletions(-) diff --git a/.rubocop.yml b/.rubocop.yml index 976368f89..2d84c4347 100644 --- a/.rubocop.yml +++ b/.rubocop.yml @@ -24,6 +24,9 @@ Rails: Layout/SpaceBeforeBlockBraces: Enabled: false +Metrics: + Enabled: false + Rails/BulkChangeTable: Exclude: - 'db/migrate/20120714122200_add_workflows_rule_fields.rb' diff --git a/.rubocop_todo.yml b/.rubocop_todo.yml index 170f02ea4..d84065936 100644 --- a/.rubocop_todo.yml +++ b/.rubocop_todo.yml @@ -1,12 +1,11 @@ # This configuration was generated by -# `rubocop --auto-gen-config` -# on 2019-06-18 23:55:41 +0900 using RuboCop version 0.71.0. +# `rubocop --auto-gen-config --no-offense-counts --no-auto-gen-timestamp` +# using RuboCop version 0.71.0. # The point is for the user to remove these configuration records # one by one as the offenses are removed from the code base. # Note that changes in the inspected code, or installation of new # versions of RuboCop, may require this file to be generated again. -# Offense count: 11 # Cop supports --auto-correct. # Configuration parameters: TreatCommentsAsGroupSeparators, Include. # Include: **/*.gemfile, **/Gemfile, **/gems.rb @@ -14,7 +13,6 @@ Bundler/OrderedGems: Exclude: - 'Gemfile' -# Offense count: 10 # Cop supports --auto-correct. # Configuration parameters: EnforcedStyle, IndentationWidth. # SupportedStyles: outdent, indent @@ -31,14 +29,12 @@ Layout/AccessModifierIndentation: - 'lib/redmine/wiki_formatting/textile/formatter.rb' - 'lib/redmine/wiki_formatting/textile/redcloth3.rb' -# Offense count: 576 # Cop supports --auto-correct. # Configuration parameters: EnforcedStyle, IndentationWidth. # SupportedStyles: with_first_argument, with_fixed_indentation Layout/AlignArguments: Enabled: false -# Offense count: 91 # Cop supports --auto-correct. Layout/AlignArray: Exclude: @@ -48,7 +44,6 @@ Layout/AlignArray: - 'test/unit/lib/redmine/scm/adapters/mercurial_adapter_test.rb' - 'test/unit/repository_bazaar_test.rb' -# Offense count: 1012 # Cop supports --auto-correct. # Configuration parameters: AllowMultipleStyles, EnforcedHashRocketStyle, EnforcedColonStyle, EnforcedLastArgumentHashStyle. # SupportedHashRocketStyles: key, separator, table @@ -57,7 +52,6 @@ Layout/AlignArray: Layout/AlignHash: Enabled: false -# Offense count: 10 # Cop supports --auto-correct. # Configuration parameters: EnforcedStyleAlignWith. # SupportedStylesAlignWith: either, start_of_block, start_of_line @@ -74,7 +68,6 @@ Layout/BlockAlignment: - 'test/unit/lib/redmine/menu_manager/menu_helper_test.rb' - 'test/unit/lib/redmine/scm/adapters/mercurial_adapter_test.rb' -# Offense count: 5 # Cop supports --auto-correct. Layout/BlockEndNewline: Exclude: @@ -83,7 +76,6 @@ Layout/BlockEndNewline: - 'app/models/issue.rb' - 'app/models/message.rb' -# Offense count: 21 # Cop supports --auto-correct. # Configuration parameters: EnforcedStyle, IndentOneStep, IndentationWidth. # SupportedStyles: case, end @@ -100,7 +92,6 @@ Layout/CaseIndentation: - 'test/test_helper.rb' - 'test/unit/lib/redmine/scm/adapters/mercurial_adapter_test.rb' -# Offense count: 64 # Cop supports --auto-correct. Layout/ClosingHeredocIndentation: Exclude: @@ -115,12 +106,10 @@ Layout/ClosingHeredocIndentation: - 'test/unit/lib/redmine/wiki_formatting_test.rb' - 'test/unit/setting_test.rb' -# Offense count: 65 # Cop supports --auto-correct. Layout/ClosingParenthesisIndentation: Enabled: false -# Offense count: 19 # Cop supports --auto-correct. Layout/CommentIndentation: Exclude: @@ -132,7 +121,6 @@ Layout/CommentIndentation: - 'test/unit/lib/redmine/wiki_formatting/textile_formatter_test.rb' - 'test/unit/repository_cvs_test.rb' -# Offense count: 2 # Cop supports --auto-correct. # Configuration parameters: EnforcedStyleAlignWith, AutoCorrect, Severity. # SupportedStylesAlignWith: start_of_line, def @@ -141,14 +129,12 @@ Layout/DefEndAlignment: - 'test/functional/documents_controller_test.rb' - 'test/unit/repository_cvs_test.rb' -# Offense count: 345 # Cop supports --auto-correct. # Configuration parameters: EnforcedStyle. # SupportedStyles: leading, trailing Layout/DotPosition: Enabled: false -# Offense count: 14 # Cop supports --auto-correct. Layout/ElseAlignment: Exclude: @@ -163,12 +149,10 @@ Layout/ElseAlignment: - 'lib/redmine/plugin.rb' - 'lib/redmine/wiki_formatting.rb' -# Offense count: 205 # Cop supports --auto-correct. Layout/EmptyLineAfterGuardClause: Enabled: false -# Offense count: 29 # Cop supports --auto-correct. # Configuration parameters: AllowAdjacentOneLineDefs, NumberOfEmptyLines. Layout/EmptyLineBetweenDefs: @@ -189,12 +173,10 @@ Layout/EmptyLineBetweenDefs: - 'test/unit/mailer_test.rb' - 'test/unit/project_test.rb' -# Offense count: 21 # Cop supports --auto-correct. Layout/EmptyLines: Enabled: false -# Offense count: 11 # Cop supports --auto-correct. # Configuration parameters: EnforcedStyle. # SupportedStyles: around, only_before @@ -212,13 +194,11 @@ Layout/EmptyLinesAroundAccessModifier: - 'lib/redmine/wiki_formatting/textile/redcloth3.rb' - 'test/functional/repositories_git_controller_test.rb' -# Offense count: 1 # Cop supports --auto-correct. Layout/EmptyLinesAroundArguments: Exclude: - 'lib/redmine/wiki_formatting/textile/redcloth3.rb' -# Offense count: 19 # Cop supports --auto-correct. # Configuration parameters: EnforcedStyle. # SupportedStyles: empty_lines, no_empty_lines @@ -235,14 +215,12 @@ Layout/EmptyLinesAroundBlockBody: - 'test/integration/api_test/my_test.rb' - 'test/unit/changeset_test.rb' -# Offense count: 52 # Cop supports --auto-correct. # Configuration parameters: EnforcedStyle. # SupportedStyles: empty_lines, empty_lines_except_namespace, empty_lines_special, no_empty_lines, beginning_only, ending_only Layout/EmptyLinesAroundClassBody: Enabled: false -# Offense count: 6 # Cop supports --auto-correct. Layout/EmptyLinesAroundExceptionHandlingKeywords: Exclude: @@ -252,7 +230,6 @@ Layout/EmptyLinesAroundExceptionHandlingKeywords: - 'test/functional/settings_controller_test.rb' - 'test/integration/attachments_test.rb' -# Offense count: 20 # Cop supports --auto-correct. Layout/EmptyLinesAroundMethodBody: Exclude: @@ -270,27 +247,23 @@ Layout/EmptyLinesAroundMethodBody: - 'test/unit/lib/redmine/menu_manager/menu_helper_test.rb' - 'test/unit/lib/redmine/unified_diff_test.rb' -# Offense count: 25 # Cop supports --auto-correct. # Configuration parameters: EnforcedStyle. # SupportedStyles: empty_lines, empty_lines_except_namespace, empty_lines_special, no_empty_lines Layout/EmptyLinesAroundModuleBody: Enabled: false -# Offense count: 24 # Cop supports --auto-correct. # Configuration parameters: EnforcedStyleAlignWith, AutoCorrect, Severity. # SupportedStylesAlignWith: keyword, variable, start_of_line Layout/EndAlignment: Enabled: false -# Offense count: 107 # Cop supports --auto-correct. # Configuration parameters: AllowForAlignment, AllowBeforeTrailingComments, ForceEqualSignAlignment. Layout/ExtraSpacing: Enabled: false -# Offense count: 9 # Cop supports --auto-correct. # Configuration parameters: IndentationWidth. Layout/IndentAssignment: @@ -301,28 +274,24 @@ Layout/IndentAssignment: - 'lib/redmine/wiki_formatting/textile/redcloth3.rb' - 'test/unit/lib/redmine/helpers/gantt_test.rb' -# Offense count: 201 # Cop supports --auto-correct. # Configuration parameters: EnforcedStyle, IndentationWidth. # SupportedStyles: consistent, consistent_relative_to_receiver, special_for_inner_method_call, special_for_inner_method_call_in_parentheses Layout/IndentFirstArgument: Enabled: false -# Offense count: 99 # Cop supports --auto-correct. # Configuration parameters: EnforcedStyle, IndentationWidth. # SupportedStyles: special_inside_parentheses, consistent, align_brackets Layout/IndentFirstArrayElement: Enabled: false -# Offense count: 2602 # Cop supports --auto-correct. # Configuration parameters: EnforcedStyle, IndentationWidth. # SupportedStyles: special_inside_parentheses, consistent, align_braces Layout/IndentFirstHashElement: Enabled: false -# Offense count: 79 # Cop supports --auto-correct. # Configuration parameters: EnforcedStyle. # SupportedStyles: squiggly, active_support, powerpack, unindent @@ -342,7 +311,6 @@ Layout/IndentHeredoc: - 'test/unit/lib/redmine/wiki_formatting_test.rb' - 'test/unit/setting_test.rb' -# Offense count: 38 # Cop supports --auto-correct. # Configuration parameters: EnforcedStyle. # SupportedStyles: normal, rails @@ -359,13 +327,11 @@ Layout/IndentationConsistency: - 'test/mocks/open_id_authentication_mock.rb' - 'test/unit/repository_cvs_test.rb' -# Offense count: 287 # Cop supports --auto-correct. # Configuration parameters: Width, IgnoredPatterns. Layout/IndentationWidth: Enabled: false -# Offense count: 32 # Cop supports --auto-correct. Layout/LeadingCommentSpace: Exclude: @@ -382,7 +348,6 @@ Layout/LeadingCommentSpace: - 'test/unit/query_test.rb' - 'test/unit/user_test.rb' -# Offense count: 9 # Cop supports --auto-correct. # Configuration parameters: EnforcedStyle. # SupportedStyles: symmetrical, new_line, same_line @@ -396,7 +361,6 @@ Layout/MultilineArrayBraceLayout: - 'test/unit/lib/redmine/wiki_formatting/textile_formatter_test.rb' - 'test/unit/repository_bazaar_test.rb' -# Offense count: 4 # Cop supports --auto-correct. Layout/MultilineBlockLayout: Exclude: @@ -405,64 +369,54 @@ Layout/MultilineBlockLayout: - 'app/models/issue.rb' - 'app/models/message.rb' -# Offense count: 77 # Cop supports --auto-correct. # Configuration parameters: EnforcedStyle. # SupportedStyles: symmetrical, new_line, same_line Layout/MultilineHashBraceLayout: Enabled: false -# Offense count: 126 # Cop supports --auto-correct. # Configuration parameters: EnforcedStyle. # SupportedStyles: symmetrical, new_line, same_line Layout/MultilineMethodCallBraceLayout: Enabled: false -# Offense count: 218 # Cop supports --auto-correct. # Configuration parameters: EnforcedStyle, IndentationWidth. # SupportedStyles: aligned, indented, indented_relative_to_receiver Layout/MultilineMethodCallIndentation: Enabled: false -# Offense count: 185 # Cop supports --auto-correct. # Configuration parameters: EnforcedStyle, IndentationWidth. # SupportedStyles: aligned, indented Layout/MultilineOperationIndentation: Enabled: false -# Offense count: 1 # Cop supports --auto-correct. Layout/RescueEnsureAlignment: Exclude: - 'db/migrate/085_add_role_tracker_old_status_index_to_workflows.rb' -# Offense count: 4 # Cop supports --auto-correct. Layout/SpaceAfterColon: Exclude: - 'test/functional/issues_controller_test.rb' - 'test/integration/wiki_test.rb' -# Offense count: 357 # Cop supports --auto-correct. Layout/SpaceAfterComma: Enabled: false -# Offense count: 37 # Cop supports --auto-correct. Layout/SpaceAfterNot: Enabled: false -# Offense count: 1 # Cop supports --auto-correct. Layout/SpaceAfterSemicolon: Exclude: - 'app/models/mail_handler.rb' -# Offense count: 6 # Cop supports --auto-correct. # Configuration parameters: EnforcedStyleInsidePipes. # SupportedStylesInsidePipes: space, no_space @@ -472,20 +426,17 @@ Layout/SpaceAroundBlockParameters: - 'lib/redmine/plugin.rb' - 'test/unit/query_test.rb' -# Offense count: 654 # Cop supports --auto-correct. # Configuration parameters: EnforcedStyle. # SupportedStyles: space, no_space Layout/SpaceAroundEqualsInParameterDefault: Enabled: false -# Offense count: 332 # Cop supports --auto-correct. # Configuration parameters: AllowForAlignment. Layout/SpaceAroundOperators: Enabled: false -# Offense count: 7 # Cop supports --auto-correct. Layout/SpaceBeforeComma: Exclude: @@ -495,7 +446,6 @@ Layout/SpaceBeforeComma: - 'test/unit/lib/redmine/helpers/calendar_test.rb' - 'test/unit/time_entry_test.rb' -# Offense count: 5 # Cop supports --auto-correct. # Configuration parameters: AllowForAlignment. Layout/SpaceBeforeFirstArg: @@ -505,7 +455,6 @@ Layout/SpaceBeforeFirstArg: - 'test/unit/lib/redmine/menu_manager_test.rb' - 'test/unit/lib/redmine/scm/adapters/git_adapter_test.rb' -# Offense count: 9 # Cop supports --auto-correct. Layout/SpaceBeforeSemicolon: Exclude: @@ -513,7 +462,6 @@ Layout/SpaceBeforeSemicolon: - 'app/models/user_preference.rb' - 'config/initializers/10-patches.rb' -# Offense count: 12 # Cop supports --auto-correct. # Configuration parameters: EnforcedStyle. # SupportedStyles: require_no_space, require_space @@ -521,7 +469,6 @@ Layout/SpaceInLambdaLiteral: Exclude: - 'app/helpers/application_helper.rb' -# Offense count: 47 # Cop supports --auto-correct. # Configuration parameters: EnforcedStyle, EnforcedStyleForEmptyBrackets. # SupportedStyles: space, no_space, compact @@ -538,7 +485,6 @@ Layout/SpaceInsideArrayLiteralBrackets: - 'test/unit/mailer_test.rb' - 'test/unit/search_test.rb' -# Offense count: 1846 # Cop supports --auto-correct. # Configuration parameters: EnforcedStyle, EnforcedStyleForEmptyBraces, SpaceBeforeBlockParameters. # SupportedStyles: space, no_space @@ -546,7 +492,6 @@ Layout/SpaceInsideArrayLiteralBrackets: Layout/SpaceInsideBlockBraces: Enabled: false -# Offense count: 3691 # Cop supports --auto-correct. # Configuration parameters: EnforcedStyle, EnforcedStyleForEmptyBraces. # SupportedStyles: space, no_space, compact @@ -554,26 +499,22 @@ Layout/SpaceInsideBlockBraces: Layout/SpaceInsideHashLiteralBraces: Enabled: false -# Offense count: 408 # Cop supports --auto-correct. # Configuration parameters: EnforcedStyle. # SupportedStyles: space, no_space Layout/SpaceInsideParens: Enabled: false -# Offense count: 2 # Cop supports --auto-correct. Layout/SpaceInsidePercentLiteralDelimiters: Exclude: - 'app/models/project.rb' -# Offense count: 1 # Cop supports --auto-correct. Layout/SpaceInsideRangeLiteral: Exclude: - 'app/models/repository/cvs.rb' -# Offense count: 27 # Cop supports --auto-correct. # Configuration parameters: EnforcedStyle, EnforcedStyleForEmptyBrackets. # SupportedStyles: space, no_space @@ -583,7 +524,6 @@ Layout/SpaceInsideReferenceBrackets: - 'lib/redmine/scm/adapters/subversion_adapter.rb' - 'test/unit/lib/redmine/scm/adapters/git_adapter_test.rb' -# Offense count: 112 # Cop supports --auto-correct. # Configuration parameters: EnforcedStyle. # SupportedStyles: space, no_space @@ -599,7 +539,6 @@ Layout/SpaceInsideStringInterpolation: - 'test/functional/issues_controller_test.rb' - 'test/integration/admin_test.rb' -# Offense count: 6 # Cop supports --auto-correct. # Configuration parameters: EnforcedStyle. # SupportedStyles: final_newline, final_blank_line @@ -612,19 +551,15 @@ Layout/TrailingBlankLines: - 'test/integration/api_test/my_test.rb' - 'test/unit/lib/redmine/hook_test.rb' -# Offense count: 3 # Cop supports --auto-correct. # Configuration parameters: AllowInHeredoc. Layout/TrailingWhitespace: Exclude: - - 'foo.rb' - 'test/unit/lib/redmine/unified_diff_test.rb' -# Offense count: 124 Lint/AmbiguousBlockAssociation: Enabled: false -# Offense count: 7 Lint/AmbiguousOperator: Exclude: - 'app/controllers/application_controller.rb' @@ -633,16 +568,13 @@ Lint/AmbiguousOperator: - 'test/unit/custom_field_test.rb' - 'test/unit/member_test.rb' -# Offense count: 145 Lint/AmbiguousRegexpLiteral: Enabled: false -# Offense count: 136 # Configuration parameters: AllowSafeAssignment. Lint/AssignmentInCondition: Enabled: false -# Offense count: 19 # Cop supports --auto-correct. Lint/DeprecatedClassMethods: Exclude: @@ -658,7 +590,6 @@ Lint/DeprecatedClassMethods: - 'test/unit/attachment_test.rb' - 'test/unit/issue_import_test.rb' -# Offense count: 7 Lint/DuplicateMethods: Exclude: - 'app/models/custom_field_value.rb' @@ -666,15 +597,12 @@ Lint/DuplicateMethods: - 'app/models/query.rb' - 'app/models/wiki_page.rb' - 'test/functional/issues_controller_test.rb' - - 'test/functional/projects_controller_test.rb' -# Offense count: 2 Lint/EmptyWhen: Exclude: - 'app/controllers/issues_controller.rb' - 'app/controllers/wiki_controller.rb' -# Offense count: 19 # Configuration parameters: AllowComments. Lint/HandleExceptions: Exclude: @@ -693,7 +621,6 @@ Lint/HandleExceptions: - 'lib/redmine/subclass_factory.rb' - 'lib/redmine/version.rb' -# Offense count: 23 Lint/IneffectiveAccessModifier: Exclude: - 'app/models/attachment.rb' @@ -709,22 +636,18 @@ Lint/IneffectiveAccessModifier: - 'lib/redmine/scm/adapters/abstract_adapter.rb' - 'lib/redmine/themes.rb' -# Offense count: 9 Lint/InterpolationCheck: Exclude: - 'app/models/user.rb' -# Offense count: 1 Lint/Loop: Exclude: - 'lib/redmine/helpers/gantt.rb' -# Offense count: 1 Lint/NestedMethodDefinition: Exclude: - 'test/unit/lib/redmine/menu_manager/menu_helper_test.rb' -# Offense count: 23 Lint/ParenthesesAsGroupedExpression: Exclude: - 'lib/redmine/field_format.rb' @@ -737,17 +660,14 @@ Lint/ParenthesesAsGroupedExpression: - 'test/unit/attachment_test.rb' - 'test/unit/lib/redmine/export/pdf_test.rb' -# Offense count: 1 # Cop supports --auto-correct. Lint/ScriptPermission: Exclude: - 'Rakefile' -# Offense count: 52 Lint/ShadowingOuterLocalVariable: Enabled: false -# Offense count: 4 # Cop supports --auto-correct. Lint/StringConversionInInterpolation: Exclude: @@ -756,44 +676,32 @@ Lint/StringConversionInInterpolation: - 'test/functional/repositories_git_controller_test.rb' - 'test/functional/repositories_mercurial_controller_test.rb' -# Offense count: 1 -# Configuration parameters: AllowKeywordBlockArguments. -Lint/UnderscorePrefixedVariableName: - Exclude: - - 'lib/redmine/i18n.rb' - -# Offense count: 1 # Cop supports --auto-correct. Lint/UnifiedInteger: Exclude: - 'test/unit/query_test.rb' -# Offense count: 1 # Cop supports --auto-correct. Lint/UnneededRequireStatement: Exclude: - 'app/models/wiki_page.rb' -# Offense count: 95 # Cop supports --auto-correct. # Configuration parameters: IgnoreEmptyBlocks, AllowUnusedKeywordArguments. Lint/UnusedBlockArgument: Enabled: false -# Offense count: 214 # Cop supports --auto-correct. # Configuration parameters: AllowUnusedKeywordArguments, IgnoreEmptyMethods. Lint/UnusedMethodArgument: Enabled: false -# Offense count: 9 Lint/UriEscapeUnescape: Exclude: - 'lib/redmine/field_format.rb' - 'lib/redmine/scm/adapters/subversion_adapter.rb' - 'test/functional/wiki_controller_test.rb' -# Offense count: 3 # Configuration parameters: ContextCreatingMethods, MethodCreatingMethods. Lint/UselessAccessModifier: Exclude: @@ -801,16 +709,13 @@ Lint/UselessAccessModifier: - 'app/models/watcher.rb' - 'lib/redmine/themes.rb' -# Offense count: 177 Lint/UselessAssignment: Enabled: false -# Offense count: 1 Lint/UselessSetterCall: Exclude: - 'test/unit/issue_test.rb' -# Offense count: 5 # Configuration parameters: CheckForMethodsWithNoSideEffects. Lint/Void: Exclude: @@ -820,50 +725,6 @@ Lint/Void: - 'lib/redmine/unified_diff.rb' - 'test/functional/project_enumerations_controller_test.rb' -# Offense count: 1436 -Metrics/AbcSize: - Max: 343 - -# Offense count: 50 -# Configuration parameters: CountComments, ExcludedMethods. -# ExcludedMethods: refine -Metrics/BlockLength: - Max: 575 - -# Offense count: 55 -# Configuration parameters: CountBlocks. -Metrics/BlockNesting: - Max: 8 - -# Offense count: 190 -# Configuration parameters: CountComments. -Metrics/ClassLength: - Max: 5884 - -# Offense count: 255 -Metrics/CyclomaticComplexity: - Max: 72 - -# Offense count: 1868 -# Configuration parameters: CountComments, ExcludedMethods. -Metrics/MethodLength: - Max: 232 - -# Offense count: 15 -# Configuration parameters: CountComments. -Metrics/ModuleLength: - Max: 1271 - -# Offense count: 19 -# Configuration parameters: CountKeywordArgs. -Metrics/ParameterLists: - Max: 9 - -# Offense count: 225 -Metrics/PerceivedComplexity: - Max: 67 - -# Offense count: 9 Naming/AccessorMethodName: Exclude: - 'app/controllers/account_controller.rb' @@ -876,7 +737,6 @@ Naming/AccessorMethodName: - 'app/models/setting.rb' - 'lib/redmine/i18n.rb' -# Offense count: 16 Naming/BinaryOperatorParameterName: Exclude: - 'app/models/custom_field.rb' @@ -895,7 +755,6 @@ Naming/BinaryOperatorParameterName: - 'lib/redmine/plugin.rb' - 'lib/redmine/themes.rb' -# Offense count: 6 Naming/ConstantName: Exclude: - 'app/models/document_category.rb' @@ -903,7 +762,6 @@ Naming/ConstantName: - 'app/models/time_entry_activity.rb' - 'lib/redmine/helpers/gantt.rb' -# Offense count: 4 # Configuration parameters: ExpectMatchingDefinition, Regex, IgnoreExecutableScripts, AllowedAcronyms. # AllowedAcronyms: CLI, DSL, ACL, API, ASCII, CPU, CSS, DNS, EOF, GUID, HTML, HTTP, HTTPS, ID, IP, JSON, LHS, QPS, RAM, RHS, RPC, SLA, SMTP, SQL, SSH, TCP, TLS, TTL, UDP, UI, UID, UUID, URI, URL, UTF8, VM, XML, XMPP, XSRF, XSS Naming/FileName: @@ -913,7 +771,6 @@ Naming/FileName: - 'config/initializers/20-mime_types.rb' - 'config/initializers/30-redmine.rb' -# Offense count: 10 # Configuration parameters: EnforcedStyleForLeadingUnderscores. # SupportedStylesForLeadingUnderscores: disallowed, required, optional Naming/MemoizedInstanceVariableName: @@ -929,7 +786,6 @@ Naming/MemoizedInstanceVariableName: - 'lib/redmine/helpers/calendar.rb' - 'lib/redmine/search.rb' -# Offense count: 16 # Configuration parameters: EnforcedStyle. # SupportedStyles: snake_case, camelCase Naming/MethodName: @@ -939,7 +795,6 @@ Naming/MethodName: - 'lib/redmine/wiki_formatting/textile/redcloth3.rb' - 'test/helpers/application_helper_test.rb' -# Offense count: 30 # Configuration parameters: NamePrefix, NamePrefixBlacklist, NameWhitelist, MethodDefinitionMacros. # NamePrefix: is_, has_, have_ # NamePrefixBlacklist: is_, has_, have_ @@ -963,7 +818,6 @@ Naming/PredicateName: - 'lib/redmine/scm/adapters/abstract_adapter.rb' - 'lib/redmine/scm/adapters/cvs_adapter.rb' -# Offense count: 4 # Cop supports --auto-correct. # Configuration parameters: PreferredName. Naming/RescuedExceptionsVariableName: @@ -972,13 +826,11 @@ Naming/RescuedExceptionsVariableName: - 'lib/redmine/scm/adapters/abstract_adapter.rb' - 'lib/redmine/scm/adapters/filesystem_adapter.rb' -# Offense count: 60 # Configuration parameters: MinNameLength, AllowNamesEndingInNumbers, AllowedNames, ForbiddenNames. # AllowedNames: io, id, to, by, on, in, at, ip, db Naming/UncommunicativeMethodParamName: Enabled: false -# Offense count: 8 # Configuration parameters: EnforcedStyle. # SupportedStyles: snake_case, camelCase Naming/VariableName: @@ -986,7 +838,6 @@ Naming/VariableName: - 'lib/redmine/scm/adapters/cvs_adapter.rb' - 'lib/redmine/wiki_formatting/textile/redcloth3.rb' -# Offense count: 30 # Configuration parameters: EnforcedStyle. # SupportedStyles: snake_case, normalcase, non_integer Naming/VariableNumber: @@ -998,7 +849,6 @@ Naming/VariableNumber: - 'test/unit/lib/redmine/scm/adapters/mercurial_adapter_test.rb' - 'test/unit/project_test.rb' -# Offense count: 16 # Cop supports --auto-correct. Rails/ActiveRecordAliases: Exclude: @@ -1013,7 +863,6 @@ Rails/ActiveRecordAliases: - 'test/unit/issue_subtasking_test.rb' - 'test/unit/message_test.rb' -# Offense count: 4 # Configuration parameters: Include. # Include: app/models/**/*.rb Rails/ActiveRecordOverride: @@ -1023,19 +872,16 @@ Rails/ActiveRecordOverride: - 'app/models/journal.rb' - 'app/models/member.rb' -# Offense count: 64 # Cop supports --auto-correct. Rails/ApplicationRecord: Enabled: false -# Offense count: 487 # Cop supports --auto-correct. # Configuration parameters: Include. # Include: **/test/**/* Rails/AssertNot: Enabled: false -# Offense count: 14 # Cop supports --auto-correct. # Configuration parameters: NilOrEmpty, NotPresent, UnlessPresent. Rails/Blank: @@ -1054,19 +900,16 @@ Rails/Blank: - 'lib/redmine/field_format.rb' - 'lib/redmine/wiki_formatting/macros.rb' -# Offense count: 57 # Configuration parameters: Include. # Include: db/migrate/*.rb Rails/CreateTableWithTimestamps: Enabled: false -# Offense count: 71 # Configuration parameters: EnforcedStyle. # SupportedStyles: strict, flexible Rails/Date: Enabled: false -# Offense count: 22 # Cop supports --auto-correct. # Configuration parameters: EnforceForPrefixed. Rails/Delegate: @@ -1085,14 +928,12 @@ Rails/Delegate: - 'app/models/wiki_content_version.rb' - 'lib/redmine/menu_manager.rb' -# Offense count: 576 # Cop supports --auto-correct. # Configuration parameters: Whitelist. # Whitelist: find_by_sql Rails/DynamicFindBy: Enabled: false -# Offense count: 3 # Configuration parameters: Include. # Include: app/**/*.rb, config/**/*.rb, lib/**/*.rb Rails/Exit: @@ -1102,13 +943,11 @@ Rails/Exit: - 'config/initializers/10-patches.rb' - 'config/routes.rb' -# Offense count: 39 # Configuration parameters: EnforcedStyle. # SupportedStyles: slashes, arguments Rails/FilePath: Enabled: false -# Offense count: 17 # Cop supports --auto-correct. # Configuration parameters: Include. # Include: app/models/**/*.rb @@ -1126,7 +965,6 @@ Rails/FindBy: - 'app/models/wiki.rb' - 'app/models/wiki_content_version.rb' -# Offense count: 13 # Cop supports --auto-correct. # Configuration parameters: Include. # Include: app/models/**/*.rb @@ -1143,7 +981,6 @@ Rails/FindEach: - 'app/models/watcher.rb' - 'app/models/wiki_page.rb' -# Offense count: 16 # Configuration parameters: Include. # Include: app/models/**/*.rb Rails/HasAndBelongsToMany: @@ -1159,7 +996,6 @@ Rails/HasAndBelongsToMany: - 'app/models/tracker.rb' - 'app/models/user.rb' -# Offense count: 10 # Configuration parameters: Include. # Include: app/models/**/*.rb Rails/HasManyOrHasOneDependent: @@ -1173,7 +1009,6 @@ Rails/HasManyOrHasOneDependent: - 'app/models/tracker.rb' - 'app/models/wiki.rb' -# Offense count: 6 # Cop supports --auto-correct. # Configuration parameters: EnforcedStyle. # SupportedStyles: numeric, symbolic @@ -1183,26 +1018,22 @@ Rails/HttpStatus: - 'app/controllers/sys_controller.rb' - 'app/controllers/watchers_controller.rb' -# Offense count: 29 # Configuration parameters: Include. # Include: app/models/**/*.rb Rails/InverseOf: Enabled: false -# Offense count: 2 # Configuration parameters: Include. # Include: app/controllers/**/*.rb Rails/LexicallyScopedActionFilter: Exclude: - 'app/controllers/projects_controller.rb' -# Offense count: 1 # Cop supports --auto-correct. Rails/LinkToBlank: Exclude: - 'app/helpers/avatars_helper.rb' -# Offense count: 9 # Configuration parameters: Include. # Include: app/**/*.rb, config/**/*.rb, db/**/*.rb, lib/**/*.rb Rails/Output: @@ -1211,11 +1042,9 @@ Rails/Output: - 'config/routes.rb' - 'lib/redmine/unified_diff.rb' -# Offense count: 106 Rails/OutputSafety: Enabled: false -# Offense count: 8 # Cop supports --auto-correct. Rails/PluralizationGrammar: Exclude: @@ -1224,7 +1053,6 @@ Rails/PluralizationGrammar: - 'test/unit/mailer_test.rb' - 'test/unit/query_test.rb' -# Offense count: 16 # Cop supports --auto-correct. Rails/Presence: Exclude: @@ -1243,26 +1071,22 @@ Rails/Presence: - 'lib/redmine/scm/adapters/mercurial_adapter.rb' - 'lib/redmine/sort_criteria.rb' -# Offense count: 67 # Cop supports --auto-correct. # Configuration parameters: NotNilAndNotEmpty, NotBlank, UnlessBlank. Rails/Present: Enabled: false -# Offense count: 38 # Cop supports --auto-correct. # Configuration parameters: Include. # Include: app/models/**/*.rb Rails/ReadWriteAttribute: Enabled: false -# Offense count: 2 Rails/ReflectionClassName: Exclude: - 'lib/redmine/nested_set/issue_nested_set.rb' - 'lib/redmine/nested_set/project_nested_set.rb' -# Offense count: 13 # Cop supports --auto-correct. # Configuration parameters: Include. # Include: **/test/**/* @@ -1277,39 +1101,33 @@ Rails/RefuteMethods: - 'test/unit/lib/redmine/project_jump_box_test.rb' - 'test/unit/mail_handler_test.rb' -# Offense count: 354 # Configuration parameters: Blacklist, Whitelist. # Blacklist: decrement!, decrement_counter, increment!, increment_counter, toggle!, touch, update_all, update_attribute, update_column, update_columns, update_counters Rails/SkipsModelValidations: Enabled: false -# Offense count: 103 # Cop supports --auto-correct. # Configuration parameters: EnforcedStyle. # SupportedStyles: strict, flexible Rails/TimeZone: Enabled: false -# Offense count: 144 # Cop supports --auto-correct. # Configuration parameters: Include. # Include: app/models/**/*.rb Rails/Validation: Enabled: false -# Offense count: 4 Security/Eval: Exclude: - 'app/helpers/attachments_helper.rb' - 'app/models/user.rb' - 'config/initializers/00-core_plugins.rb' -# Offense count: 1 Security/Open: Exclude: - 'app/models/version.rb' -# Offense count: 4 # Cop supports --auto-correct. Security/YAMLLoad: Exclude: @@ -1317,27 +1135,23 @@ Security/YAMLLoad: - 'app/models/setting.rb' - 'lib/redmine/configuration.rb' -# Offense count: 52 # Configuration parameters: EnforcedStyle. # SupportedStyles: inline, group Style/AccessModifierDeclarations: Enabled: false -# Offense count: 25 # Cop supports --auto-correct. # Configuration parameters: EnforcedStyle. # SupportedStyles: prefer_alias, prefer_alias_method Style/Alias: Enabled: false -# Offense count: 40 # Cop supports --auto-correct. # Configuration parameters: EnforcedStyle. # SupportedStyles: always, conditionals Style/AndOr: Enabled: false -# Offense count: 3 # Configuration parameters: AllowedChars. Style/AsciiComments: Exclude: @@ -1345,7 +1159,6 @@ Style/AsciiComments: - 'lib/redmine/search.rb' - 'test/unit/mail_handler_test.rb' -# Offense count: 1 # Cop supports --auto-correct. # Configuration parameters: EnforcedStyle. # SupportedStyles: percent_q, bare_percent @@ -1353,13 +1166,11 @@ Style/BarePercentLiterals: Exclude: - 'test/integration/api_test/api_test.rb' -# Offense count: 1 # Cop supports --auto-correct. Style/BlockComments: Exclude: - 'lib/diff.rb' -# Offense count: 147 # Cop supports --auto-correct. # Configuration parameters: EnforcedStyle, ProceduralMethods, FunctionalMethods, IgnoredMethods, AllowBracesOnProceduralOneLiners. # SupportedStyles: line_count_based, semantic, braces_for_chaining, always_braces @@ -1369,28 +1180,24 @@ Style/BlockComments: Style/BlockDelimiters: Enabled: false -# Offense count: 209 # Cop supports --auto-correct. # Configuration parameters: EnforcedStyle. # SupportedStyles: braces, no_braces, context_dependent Style/BracesAroundHashParameters: Enabled: false -# Offense count: 2 # Cop supports --auto-correct. Style/CharacterLiteral: Exclude: - 'lib/redmine/wiki_formatting.rb' - 'lib/redmine/wiki_formatting/textile/redcloth3.rb' -# Offense count: 79 # Cop supports --auto-correct. # Configuration parameters: AutoCorrect, EnforcedStyle. # SupportedStyles: nested, compact Style/ClassAndModuleChildren: Enabled: false -# Offense count: 2 # Cop supports --auto-correct. # Configuration parameters: EnforcedStyle. # SupportedStyles: is_a?, kind_of? @@ -1398,17 +1205,14 @@ Style/ClassCheck: Exclude: - 'lib/redmine/scm/adapters/cvs_adapter.rb' -# Offense count: 1 # Cop supports --auto-correct. Style/ClassMethods: Exclude: - 'lib/diff.rb' -# Offense count: 48 Style/ClassVars: Enabled: false -# Offense count: 34 # Cop supports --auto-correct. Style/ColonMethodCall: Exclude: @@ -1424,7 +1228,6 @@ Style/ColonMethodCall: - 'test/unit/default_data_test.rb' - 'test/unit/lib/redmine/export/pdf_test.rb' -# Offense count: 1 # Cop supports --auto-correct. # Configuration parameters: Keywords. # Keywords: TODO, FIXME, OPTIMIZE, HACK, REVIEW @@ -1432,23 +1235,19 @@ Style/CommentAnnotation: Exclude: - 'lib/redmine/scm/adapters/cvs_adapter.rb' -# Offense count: 1 Style/CommentedKeyword: Exclude: - 'app/models/repository/cvs.rb' -# Offense count: 76 # Cop supports --auto-correct. # Configuration parameters: EnforcedStyle, SingleLineConditionsOnly, IncludeTernaryExpressions. # SupportedStyles: assign_to_condition, assign_inside_condition Style/ConditionalAssignment: Enabled: false -# Offense count: 626 Style/Documentation: Enabled: false -# Offense count: 9 Style/DoubleNegation: Exclude: - 'app/controllers/application_controller.rb' @@ -1460,19 +1259,16 @@ Style/DoubleNegation: - 'app/models/user.rb' - 'lib/redmine/sudo_mode.rb' -# Offense count: 27 # Cop supports --auto-correct. Style/EachWithObject: Enabled: false -# Offense count: 2 # Cop supports --auto-correct. Style/EmptyCaseCondition: Exclude: - 'app/models/auth_source_ldap.rb' - 'app/models/issue_priority.rb' -# Offense count: 5 # Cop supports --auto-correct. # Configuration parameters: EnforcedStyle. # SupportedStyles: empty, nil, both @@ -1483,30 +1279,25 @@ Style/EmptyElse: - 'app/models/mail_handler.rb' - 'app/models/query.rb' -# Offense count: 1 # Cop supports --auto-correct. Style/EmptyLiteral: Exclude: - 'lib/redmine/scm/adapters/cvs_adapter.rb' -# Offense count: 39 # Cop supports --auto-correct. # Configuration parameters: EnforcedStyle. # SupportedStyles: compact, expanded Style/EmptyMethod: Enabled: false -# Offense count: 1 Style/EvalWithLocation: Exclude: - 'app/helpers/attachments_helper.rb' -# Offense count: 320 # Cop supports --auto-correct. Style/ExpandPathArguments: Enabled: false -# Offense count: 3 # Cop supports --auto-correct. # Configuration parameters: EnforcedStyle. # SupportedStyles: each, for @@ -1515,7 +1306,6 @@ Style/For: - 'lib/redmine/export/pdf/issues_pdf_helper.rb' - 'lib/redmine/export/pdf/wiki_pdf_helper.rb' -# Offense count: 18 # Cop supports --auto-correct. # Configuration parameters: EnforcedStyle. # SupportedStyles: format, sprintf, percent @@ -1531,7 +1321,6 @@ Style/FormatString: - 'lib/redmine/i18n.rb' - 'lib/redmine/info.rb' -# Offense count: 13 # Configuration parameters: EnforcedStyle. # SupportedStyles: annotated, template, unannotated Style/FormatStringToken: @@ -1542,31 +1331,15 @@ Style/FormatStringToken: - 'test/helpers/application_helper_test.rb' - 'test/unit/lib/redmine/unified_diff_test.rb' -# Offense count: 2 -# Cop supports --auto-correct. -# Configuration parameters: EnforcedStyle. -# SupportedStyles: always, never -Style/FrozenStringLiteralComment: - Exclude: - - 'db/**/*.rb' - - 'Gemfile' - - 'Rakefile' - - 'config.ru' - - 'config/additional_environment.rb' - - 'foo.rb' - -# Offense count: 8 # Configuration parameters: AllowedVariables. Style/GlobalVars: Exclude: - 'test/test_helper.rb' -# Offense count: 298 # Configuration parameters: MinBodyLength. Style/GuardClause: Enabled: false -# Offense count: 2 # Cop supports --auto-correct. # Configuration parameters: EnforcedStyle, UseHashRocketsWithSymbolValues, PreferHashRocketsForNonAlnumEndingSymbols. # SupportedStyles: ruby19, hash_rockets, no_mixed_keys, ruby19_no_mixed_keys @@ -1574,51 +1347,42 @@ Style/HashSyntax: Exclude: - 'test/functional/issues_controller_test.rb' -# Offense count: 7 Style/IdenticalConditionalBranches: Exclude: - 'app/models/project.rb' - 'config/initializers/10-patches.rb' - 'lib/redmine/wiki_formatting/textile/redcloth3.rb' -# Offense count: 30 Style/IfInsideElse: Enabled: false -# Offense count: 536 # Cop supports --auto-correct. Style/IfUnlessModifier: Enabled: false -# Offense count: 1 Style/IfUnlessModifierOfIfUnless: Exclude: - 'app/models/attachment.rb' -# Offense count: 1 Style/IfWithSemicolon: Exclude: - 'lib/redmine/wiki_formatting/textile/redcloth3.rb' -# Offense count: 23 # Cop supports --auto-correct. # Configuration parameters: InverseMethods, InverseBlocks. Style/InverseMethods: Enabled: false -# Offense count: 118 # Cop supports --auto-correct. # Configuration parameters: EnforcedStyle. # SupportedStyles: line_count_dependent, lambda, literal Style/Lambda: Enabled: false -# Offense count: 226 # Cop supports --auto-correct. Style/LineEndConcatenation: Enabled: false -# Offense count: 17 # Cop supports --auto-correct. # Configuration parameters: IgnoredMethods. Style/MethodCallWithoutArgsParentheses: @@ -1631,7 +1395,6 @@ Style/MethodCallWithoutArgsParentheses: - 'test/functional/repositories_git_controller_test.rb' - 'test/unit/activity_test.rb' -# Offense count: 1 # Cop supports --auto-correct. # Configuration parameters: EnforcedStyle. # SupportedStyles: require_parentheses, require_no_parentheses, require_no_parentheses_except_multiline @@ -1639,32 +1402,26 @@ Style/MethodDefParentheses: Exclude: - 'lib/redmine/menu_manager.rb' -# Offense count: 1 Style/MethodMissingSuper: Exclude: - 'lib/redmine/views/builders/structure.rb' -# Offense count: 1 Style/MissingRespondToMissing: Exclude: - 'lib/redmine/views/builders/structure.rb' -# Offense count: 1 Style/MixinUsage: Exclude: - 'test/test_helper.rb' -# Offense count: 1 Style/MultilineBlockChain: Exclude: - 'lib/redmine/scm/adapters/mercurial_adapter.rb' -# Offense count: 37 # Cop supports --auto-correct. Style/MultilineIfModifier: Enabled: false -# Offense count: 20 Style/MultilineTernaryOperator: Exclude: - 'app/controllers/workflows_controller.rb' @@ -1681,7 +1438,6 @@ Style/MultilineTernaryOperator: - 'lib/redmine/utils.rb' - 'lib/redmine/wiki_formatting.rb' -# Offense count: 9 Style/MultipleComparison: Exclude: - 'app/helpers/application_helper.rb' @@ -1692,14 +1448,12 @@ Style/MultipleComparison: - 'app/models/workflow_transition.rb' - 'lib/redmine/scm/adapters/git_adapter.rb' -# Offense count: 83 # Cop supports --auto-correct. # Configuration parameters: EnforcedStyle. # SupportedStyles: literals, strict Style/MutableConstant: Enabled: false -# Offense count: 20 # Cop supports --auto-correct. # Configuration parameters: EnforcedStyle. # SupportedStyles: both, prefix, postfix @@ -1718,13 +1472,11 @@ Style/NegatedIf: - 'lib/redmine/scm/adapters/bazaar_adapter.rb' - 'lib/redmine/thumbnail.rb' -# Offense count: 1 # Cop supports --auto-correct. Style/NegatedWhile: Exclude: - 'app/helpers/application_helper.rb' -# Offense count: 2 # Cop supports --auto-correct. # Configuration parameters: Whitelist. # Whitelist: be, be_a, be_an, be_between, be_falsey, be_kind_of, be_instance_of, be_truthy, be_within, eq, eql, end_with, include, match, raise_error, respond_to, start_with @@ -1733,7 +1485,6 @@ Style/NestedParenthesizedCalls: - 'lib/redmine/views/labelled_form_builder.rb' - 'test/unit/mail_handler_test.rb' -# Offense count: 7 Style/NestedTernaryOperator: Exclude: - 'app/helpers/issues_helper.rb' @@ -1741,16 +1492,13 @@ Style/NestedTernaryOperator: - 'app/helpers/versions_helper.rb' - 'app/models/issue_relation.rb' - 'app/models/journal.rb' - - 'lib/redmine/i18n.rb' -# Offense count: 40 # Cop supports --auto-correct. # Configuration parameters: EnforcedStyle, MinBodyLength. # SupportedStyles: skip_modifier_ifs, always Style/Next: Enabled: false -# Offense count: 4 # Cop supports --auto-correct. Style/Not: Exclude: @@ -1758,7 +1506,6 @@ Style/Not: - 'lib/redmine/scm/adapters/filesystem_adapter.rb' - 'lib/redmine/wiki_formatting/textile/redcloth3.rb' -# Offense count: 3 # Cop supports --auto-correct. # Configuration parameters: EnforcedOctalStyle. # SupportedOctalStyles: zero_with_o, zero_only @@ -1766,7 +1513,6 @@ Style/NumericLiteralPrefix: Exclude: - 'test/unit/user_test.rb' -# Offense count: 20 # Cop supports --auto-correct. # Configuration parameters: MinDigits, Strict. Style/NumericLiterals: @@ -1783,20 +1529,17 @@ Style/NumericLiterals: - 'test/unit/search_test.rb' - 'test/unit/time_entry_test.rb' -# Offense count: 151 # Cop supports --auto-correct. # Configuration parameters: AutoCorrect, EnforcedStyle, IgnoredMethods. # SupportedStyles: predicate, comparison Style/NumericPredicate: Enabled: false -# Offense count: 1 # Cop supports --auto-correct. Style/OneLineConditional: Exclude: - 'lib/redmine/wiki_formatting/textile/redcloth3.rb' -# Offense count: 5 # Cop supports --auto-correct. Style/OrAssignment: Exclude: @@ -1805,12 +1548,10 @@ Style/OrAssignment: - 'app/models/user.rb' - 'lib/redmine/helpers/diff.rb' -# Offense count: 72 # Cop supports --auto-correct. Style/ParallelAssignment: Enabled: false -# Offense count: 23 # Cop supports --auto-correct. # Configuration parameters: AllowSafeAssignment, AllowInMultilineConditions. Style/ParenthesesAroundCondition: @@ -1831,30 +1572,25 @@ Style/ParenthesesAroundCondition: - 'lib/redmine/wiki_formatting.rb' - 'lib/redmine/wiki_formatting/textile/redcloth3.rb' -# Offense count: 318 # Cop supports --auto-correct. # Configuration parameters: PreferredDelimiters. Style/PercentLiteralDelimiters: Enabled: false -# Offense count: 213 # Cop supports --auto-correct. Style/PerlBackrefs: Enabled: false -# Offense count: 50 # Cop supports --auto-correct. # Configuration parameters: EnforcedStyle. # SupportedStyles: short, verbose Style/PreferredHashMethods: Enabled: false -# Offense count: 74 # Cop supports --auto-correct. Style/Proc: Enabled: false -# Offense count: 33 # Cop supports --auto-correct. # Configuration parameters: EnforcedStyle. # SupportedStyles: compact, exploded @@ -1875,13 +1611,11 @@ Style/RaiseArgs: - 'lib/redmine/scm/adapters/filesystem_adapter.rb' - 'lib/redmine/sort_criteria.rb' -# Offense count: 1 # Cop supports --auto-correct. Style/RedundantBegin: Exclude: - 'lib/redmine/scm/adapters/git_adapter.rb' -# Offense count: 5 # Cop supports --auto-correct. Style/RedundantConditional: Exclude: @@ -1891,30 +1625,25 @@ Style/RedundantConditional: - 'app/models/enumeration.rb' - 'lib/redmine/field_format.rb' -# Offense count: 27 # Cop supports --auto-correct. Style/RedundantParentheses: Enabled: false -# Offense count: 67 # Cop supports --auto-correct. # Configuration parameters: AllowMultipleReturnValues. Style/RedundantReturn: Enabled: false -# Offense count: 250 # Cop supports --auto-correct. Style/RedundantSelf: Enabled: false -# Offense count: 158 # Cop supports --auto-correct. # Configuration parameters: EnforcedStyle, AllowInnerSlashes. # SupportedStyles: slashes, percent_r, mixed Style/RegexpLiteral: Enabled: false -# Offense count: 20 # Cop supports --auto-correct. Style/RescueModifier: Exclude: @@ -1934,21 +1663,18 @@ Style/RescueModifier: - 'lib/redmine/wiki_formatting.rb' - 'test/unit/lib/redmine/wiki_formatting/markdown_formatter_test.rb' -# Offense count: 56 # Cop supports --auto-correct. # Configuration parameters: EnforcedStyle. # SupportedStyles: implicit, explicit Style/RescueStandardError: Enabled: false -# Offense count: 135 # Cop supports --auto-correct. # Configuration parameters: ConvertCodeThatCanStartToReturnNil, Whitelist. # Whitelist: present?, blank?, presence, try, try! Style/SafeNavigation: Enabled: false -# Offense count: 28 # Cop supports --auto-correct. Style/SelfAssignment: Exclude: @@ -1963,40 +1689,34 @@ Style/SelfAssignment: - 'lib/redmine/helpers/gantt.rb' - 'lib/redmine/helpers/time_report.rb' -# Offense count: 37 # Cop supports --auto-correct. # Configuration parameters: AllowAsExpressionSeparator. Style/Semicolon: Enabled: false -# Offense count: 59 # Cop supports --auto-correct. # Configuration parameters: AllowIfMethodIsEmpty. Style/SingleLineMethods: Enabled: false -# Offense count: 63 # Cop supports --auto-correct. # Configuration parameters: . # SupportedStyles: use_perl_names, use_english_names Style/SpecialGlobalVars: EnforcedStyle: use_perl_names -# Offense count: 2 # Cop supports --auto-correct. Style/StderrPuts: Exclude: - 'config/environment.rb' - 'config/initializers/10-patches.rb' -# Offense count: 6361 # Cop supports --auto-correct. # Configuration parameters: EnforcedStyle, ConsistentQuotesInMultiline. # SupportedStyles: single_quotes, double_quotes Style/StringLiterals: Enabled: false -# Offense count: 16 # Cop supports --auto-correct. # Configuration parameters: EnforcedStyle. # SupportedStyles: single_quotes, double_quotes @@ -2010,34 +1730,29 @@ Style/StringLiteralsInInterpolation: - 'lib/redmine/wiki_formatting/textile/redcloth3.rb' - 'test/unit/member_test.rb' -# Offense count: 2 Style/StructInheritance: Exclude: - 'lib/redmine/notifiable.rb' - 'lib/redmine/sudo_mode.rb' -# Offense count: 317 # Cop supports --auto-correct. # Configuration parameters: MinSize. # SupportedStyles: percent, brackets Style/SymbolArray: EnforcedStyle: brackets -# Offense count: 75 # Cop supports --auto-correct. # Configuration parameters: IgnoredMethods. # IgnoredMethods: respond_to, define_method Style/SymbolProc: Enabled: false -# Offense count: 44 # Cop supports --auto-correct. # Configuration parameters: EnforcedStyle, AllowSafeAssignment. # SupportedStyles: require_parentheses, require_no_parentheses, require_parentheses_when_complex Style/TernaryParentheses: Enabled: false -# Offense count: 1 # Cop supports --auto-correct. # Configuration parameters: EnforcedStyleForMultiline. # SupportedStylesForMultiline: comma, consistent_comma, no_comma @@ -2045,7 +1760,6 @@ Style/TrailingCommaInArguments: Exclude: - 'test/unit/issue_test.rb' -# Offense count: 31 # Cop supports --auto-correct. # Configuration parameters: EnforcedStyleForMultiline. # SupportedStylesForMultiline: comma, consistent_comma, no_comma @@ -2062,14 +1776,12 @@ Style/TrailingCommaInArrayLiteral: - 'test/unit/lib/redmine/scm/adapters/mercurial_adapter_test.rb' - 'test/unit/repository_git_test.rb' -# Offense count: 71 # Cop supports --auto-correct. # Configuration parameters: EnforcedStyleForMultiline. # SupportedStylesForMultiline: comma, consistent_comma, no_comma Style/TrailingCommaInHashLiteral: Enabled: false -# Offense count: 11 # Cop supports --auto-correct. # Configuration parameters: ExactNameMatch, AllowPredicates, AllowDSLWriters, IgnoreClassMethods, Whitelist. # Whitelist: to_ary, to_a, to_c, to_enum, to_h, to_hash, to_i, to_int, to_io, to_open, to_path, to_proc, to_r, to_regexp, to_str, to_s, to_sym @@ -2085,7 +1797,6 @@ Style/TrivialAccessors: - 'lib/redmine/scm/adapters/git_adapter.rb' - 'lib/redmine/scm/adapters/mercurial_adapter.rb' -# Offense count: 5 # Cop supports --auto-correct. Style/UnlessElse: Exclude: @@ -2095,7 +1806,6 @@ Style/UnlessElse: - 'lib/redmine/unified_diff.rb' - 'lib/redmine/wiki_formatting/textile/redcloth3.rb' -# Offense count: 7 # Cop supports --auto-correct. Style/UnneededCondition: Exclude: @@ -2104,7 +1814,6 @@ Style/UnneededCondition: - 'app/models/issue.rb' - 'app/models/setting.rb' -# Offense count: 24 # Cop supports --auto-correct. Style/UnneededInterpolation: Exclude: @@ -2122,7 +1831,6 @@ Style/UnneededInterpolation: - 'test/functional/watchers_controller_test.rb' - 'test/unit/repository_mercurial_test.rb' -# Offense count: 13 # Cop supports --auto-correct. Style/UnneededSort: Exclude: @@ -2132,13 +1840,11 @@ Style/UnneededSort: - 'test/unit/member_test.rb' - 'test/unit/repository_git_test.rb' -# Offense count: 1 # Cop supports --auto-correct. Style/VariableInterpolation: Exclude: - 'lib/redmine/configuration.rb' -# Offense count: 10 # Cop supports --auto-correct. Style/WhenThen: Exclude: @@ -2147,7 +1853,6 @@ Style/WhenThen: - 'app/models/role.rb' - 'lib/redmine/views/builders.rb' -# Offense count: 12 # Cop supports --auto-correct. Style/WhileUntilModifier: Exclude: @@ -2161,14 +1866,12 @@ Style/WhileUntilModifier: - 'lib/redmine/wiki_formatting/textile/redcloth3.rb' - 'test/application_system_test_case.rb' -# Offense count: 391 # Cop supports --auto-correct. # Configuration parameters: EnforcedStyle, MinSize, WordRegex. # SupportedStyles: percent, brackets Style/WordArray: Enabled: false -# Offense count: 2 # Cop supports --auto-correct. # Configuration parameters: EnforcedStyle. # SupportedStyles: forbid_for_all_comparison_operators, forbid_for_equality_operators_only, require_for_all_comparison_operators, require_for_equality_operators_only @@ -2176,7 +1879,6 @@ Style/YodaCondition: Exclude: - 'lib/redmine/scm/adapters/abstract_adapter.rb' -# Offense count: 12 # Cop supports --auto-correct. Style/ZeroLengthPredicate: Exclude: @@ -2191,10 +1893,3 @@ Style/ZeroLengthPredicate: - 'test/object_helpers.rb' - 'test/unit/activity_test.rb' - 'test/unit/custom_field_test.rb' - -# Offense count: 7893 -# Cop supports --auto-correct. -# Configuration parameters: AutoCorrect, AllowHeredoc, AllowURI, URISchemes, IgnoreCopDirectives, IgnoredPatterns. -# URISchemes: http, https -Metrics/LineLength: - Max: 461 -- 2.39.5