From 7aa2c8c49a4c9fd7660c8ea2e5c9980dfda74ed0 Mon Sep 17 00:00:00 2001
From: Jean-Baptiste Lievremont <jean-baptiste.lievremont@sonarsource.com>
Date: Fri, 13 Jun 2014 16:46:07 +0200
Subject: [PATCH] SONAR-5135 Fix UI details about bulk change of rules

---
 sonar-server/src/main/coffee/coding-rules/app.coffee       | 2 ++
 .../src/main/coffee/coding-rules/views/actions-view.coffee | 7 -------
 .../views/coding-rules-detail-quality-profile-view.coffee  | 2 +-
 .../src/main/hbs/coding-rules/coding-rules-actions.hbs     | 4 ++--
 .../src/main/hbs/coding-rules/coding-rules-bulk-change.hbs | 5 +++--
 sonar-server/src/main/less/style.less                      | 1 +
 6 files changed, 9 insertions(+), 12 deletions(-)

diff --git a/sonar-server/src/main/coffee/coding-rules/app.coffee b/sonar-server/src/main/coffee/coding-rules/app.coffee
index 7c8aa97cb2e..00e027cca13 100644
--- a/sonar-server/src/main/coffee/coding-rules/app.coffee
+++ b/sonar-server/src/main/coffee/coding-rules/app.coffee
@@ -446,6 +446,8 @@ requirejs [
     App.canWrite = r.canWrite
     App.qualityProfiles = _.sortBy r.qualityprofiles, ['name', 'lang']
     App.languages = _.extend r.languages, none: 'None'
+    _.map App.qualityProfiles, (profile) ->
+      profile.language = App.languages[profile.lang]
     App.repositories = r.repositories
     App.repositories.push
       key: 'manual'
diff --git a/sonar-server/src/main/coffee/coding-rules/views/actions-view.coffee b/sonar-server/src/main/coffee/coding-rules/views/actions-view.coffee
index dba669468b6..b5f13553de5 100644
--- a/sonar-server/src/main/coffee/coding-rules/views/actions-view.coffee
+++ b/sonar-server/src/main/coffee/coding-rules/views/actions-view.coffee
@@ -57,15 +57,8 @@ define [
       @options.app.codingRulesBulkChangeDropdownView.toggle()
 
 
-    bulkEnabled: ->
-      return false if @collection.isEmpty()
-      resultLanguages = _.uniq(@collection.pluck 'lang')
-      resultLanguages.length == 1
-
-
     serializeData: ->
       _.extend super,
         canWrite: @options.app.canWrite
         paging: @collection.paging
         sorting: @collection.sorting
-        bulkEnabled: @bulkEnabled()
diff --git a/sonar-server/src/main/coffee/coding-rules/views/coding-rules-detail-quality-profile-view.coffee b/sonar-server/src/main/coffee/coding-rules/views/coding-rules-detail-quality-profile-view.coffee
index 651fb072a29..b2ab3bfe447 100644
--- a/sonar-server/src/main/coffee/coding-rules/views/coding-rules-detail-quality-profile-view.coffee
+++ b/sonar-server/src/main/coffee/coding-rules/views/coding-rules-detail-quality-profile-view.coffee
@@ -67,7 +67,7 @@ define [
       return null unless @model.get('inherit') && @model.get('inherit') != 'NONE'
       parentKey = @model.get('parent') + ':' + @model.get('lang')
       parent = _.extend {}, _.findWhere(@options.app.qualityProfiles, key: parentKey)
-      parentActiveInfo = @model.collection.findWhere(qProfile: parentKey) or {}
+      parentActiveInfo = @model.collection.findWhere(qProfile: parentKey) or new Backbone.Model()
       _.extend parent, parentActiveInfo.toJSON()
       parent
 
diff --git a/sonar-server/src/main/hbs/coding-rules/coding-rules-actions.hbs b/sonar-server/src/main/hbs/coding-rules/coding-rules-actions.hbs
index a170f69a602..36c94e0a030 100644
--- a/sonar-server/src/main/hbs/coding-rules/coding-rules-actions.hbs
+++ b/sonar-server/src/main/hbs/coding-rules/coding-rules-actions.hbs
@@ -14,6 +14,6 @@
 </ul>
 <div class="navigator-actions-total">
   {{t 'coding_rules.found'}}: <strong>{{paging.total}}</strong>
-  {{#if canWrite}}{{#if bulkEnabled}}<a class="navigator-actions-bulk"
-     title="{{t 'bulk_change'}}"><i class="icon-bulk-change"></i></a>{{/if}}{{/if}}
+  {{#if canWrite}}<a class="navigator-actions-bulk"
+     title="{{t 'bulk_change'}}"><i class="icon-bulk-change"></i></a>{{/if}}
 </div>
diff --git a/sonar-server/src/main/hbs/coding-rules/coding-rules-bulk-change.hbs b/sonar-server/src/main/hbs/coding-rules/coding-rules-bulk-change.hbs
index 837ca64225c..d5de084eaf1 100644
--- a/sonar-server/src/main/hbs/coding-rules/coding-rules-bulk-change.hbs
+++ b/sonar-server/src/main/hbs/coding-rules/coding-rules-bulk-change.hbs
@@ -21,11 +21,12 @@
         {{#eq action 'deactivate'}}{{t 'coding_rules.deactivate_in'}}{{/eq}}
       </label></h3>
       {{#if qualityProfile}}
-        <h3 class="readonly-field">{{qualityProfileName}}</h3>
+        <h3 class="readonly-field">{{qualityProfileName}}{{#notEq action 'change-severity'}} —
+          {{t 'are_you_sure'}}{{/notEq}}</h3>
       {{else}}
         <select id="coding-rules-bulk-change-profile">
           {{#each availableQualityProfiles}}
-            <option value="{{key}}">{{name}}</option>
+            <option value="{{key}}">{{name}} - {{language}}</option>
           {{/each}}
         </select>
       {{/if}}
diff --git a/sonar-server/src/main/less/style.less b/sonar-server/src/main/less/style.less
index 0f5f917c758..33c298fe662 100644
--- a/sonar-server/src/main/less/style.less
+++ b/sonar-server/src/main/less/style.less
@@ -2498,6 +2498,7 @@ ul.modal-head-metadata li {
 
 .readonly-field {
   padding-top: 5px;
+  margin-left: -5px;
   line-height: 1;
 }
 
-- 
2.39.5