From 7c939aadf8c661f1230627d51bf1450f99effcc3 Mon Sep 17 00:00:00 2001 From: Mike Sherov Date: Sun, 14 Apr 2013 12:58:42 -0400 Subject: [PATCH] Test Suite: Remove Flaky Datepicker test, and correct more old jQuery test cases for old Opera and old Safari. --- tests/unit/button/button_core.js | 2 +- tests/unit/datepicker/datepicker_options.js | 11 ++++++----- tests/unit/draggable/draggable_core.js | 1 + tests/unit/draggable/draggable_options.js | 13 +++++++++---- 4 files changed, 17 insertions(+), 10 deletions(-) diff --git a/tests/unit/button/button_core.js b/tests/unit/button/button_core.js index 55dda68b3..6df7da9db 100644 --- a/tests/unit/button/button_core.js +++ b/tests/unit/button/button_core.js @@ -166,7 +166,7 @@ asyncTest( "Resetting a button's form should refresh the visual state of the but ok( !checkbox.button( "widget" ).hasClass( "ui-state-active" ) ); form.get( 0 ).reset(); - + // #9213: If a button has been removed, refresh should not be called on it when // its corresponding form is reset. button.remove(); diff --git a/tests/unit/datepicker/datepicker_options.js b/tests/unit/datepicker/datepicker_options.js index a5d66314c..a763b2fda 100644 --- a/tests/unit/datepicker/datepicker_options.js +++ b/tests/unit/datepicker/datepicker_options.js @@ -1066,11 +1066,12 @@ test("formatDate", function() { "Format date 'jour' d 'de' MM (''DD''), yy with settings"); }); -test("Ticket 6827: formatDate day of year calculation is wrong during day lights savings time", function(){ - expect( 1 ); - var time = $.datepicker.formatDate("oo", new Date("2010/03/30 12:00:00 CDT")); - equal(time, "089"); -}); +// TODO: Fix this test so it isn't mysteriously flaky in Browserstack on certain OS/Browser combos +// test("Ticket 6827: formatDate day of year calculation is wrong during day lights savings time", function(){ +// expect( 1 ); +// var time = $.datepicker.formatDate("oo", new Date("2010/03/30 12:00:00 CDT")); +// equal(time, "089"); +// }); test( "Ticket 7602: Stop datepicker from appearing with beforeShow event handler", function() { expect( 3 ); diff --git a/tests/unit/draggable/draggable_core.js b/tests/unit/draggable/draggable_core.js index dd71bd48b..e7fcdfa87 100644 --- a/tests/unit/draggable/draggable_core.js +++ b/tests/unit/draggable/draggable_core.js @@ -94,6 +94,7 @@ test( "#8269: Removing draggable element on drop", function() { // Support: Opera 12.10, Safari 5.1, jQuery <1.8 if ( TestHelpers.draggable.unreliableContains ) { ok( true, "Opera <12.14 and Safari <6.0 report wrong values for $.contains in jQuery < 1.8" ); + ok( true, "Opera <12.14 and Safari <6.0 report wrong values for $.contains in jQuery < 1.8" ); } else { element.simulate( "drag", { handle: "corner", diff --git a/tests/unit/draggable/draggable_options.js b/tests/unit/draggable/draggable_options.js index c361318b1..ef551003d 100644 --- a/tests/unit/draggable/draggable_options.js +++ b/tests/unit/draggable/draggable_options.js @@ -472,10 +472,15 @@ test( "#6889: Cursor doesn't revert to pre-dragging state after revert action wh }), expected = getCursor(); - element.simulate( "drag", { - dx: -1, - dy: -1 - }); + if ( TestHelpers.draggable.unreliableContains ) { + ok( true, "Opera <12.14 and Safari <6.0 report wrong values for $.contains in jQuery < 1.8" ); + ok( true, "Opera <12.14 and Safari <6.0 report wrong values for $.contains in jQuery < 1.8" ); + } else { + element.simulate( "drag", { + dx: -1, + dy: -1 + }); + } }); test( "cursor, default, switching after initialization", function() { -- 2.39.5