From 824a30f8c36e35b3b9ca396619e3204f7568115b Mon Sep 17 00:00:00 2001 From: Julien Lancelot Date: Fri, 28 Aug 2015 11:04:46 +0200 Subject: [PATCH] SONAR-6730 Add component key in the API It will allow to have more information in error generated by plugin or in debug logs. --- .../sonar/server/computation/measure/api/ComponentImpl.java | 5 +++++ .../server/computation/measure/api/ComponentImplTest.java | 1 + .../src/main/java/org/sonar/api/ce/measure/Component.java | 2 ++ .../java/org/sonar/api/test/ce/measure/ComponentImpl.java | 5 +++++ 4 files changed, 13 insertions(+) diff --git a/server/sonar-server/src/main/java/org/sonar/server/computation/measure/api/ComponentImpl.java b/server/sonar-server/src/main/java/org/sonar/server/computation/measure/api/ComponentImpl.java index 5578afdbcee..d5c9f582b02 100644 --- a/server/sonar-server/src/main/java/org/sonar/server/computation/measure/api/ComponentImpl.java +++ b/server/sonar-server/src/main/java/org/sonar/server/computation/measure/api/ComponentImpl.java @@ -59,6 +59,11 @@ public class ComponentImpl implements Component { return type; } + @Override + public String getKey() { + return key; + } + @Override public FileAttributes getFileAttributes() { checkState(this.type == Component.Type.FILE, "Only component of type FILE have a FileAttributes object"); diff --git a/server/sonar-server/src/test/java/org/sonar/server/computation/measure/api/ComponentImplTest.java b/server/sonar-server/src/test/java/org/sonar/server/computation/measure/api/ComponentImplTest.java index 6c133a2b1f6..d9b383f5f7a 100644 --- a/server/sonar-server/src/test/java/org/sonar/server/computation/measure/api/ComponentImplTest.java +++ b/server/sonar-server/src/test/java/org/sonar/server/computation/measure/api/ComponentImplTest.java @@ -36,6 +36,7 @@ public class ComponentImplTest { public void create_project() throws Exception { ComponentImpl component = new ComponentImpl("Project", Component.Type.PROJECT, null); + assertThat(component.getKey()).isEqualTo("Project"); assertThat(component.getType()).isEqualTo(Component.Type.PROJECT); } diff --git a/sonar-plugin-api/src/main/java/org/sonar/api/ce/measure/Component.java b/sonar-plugin-api/src/main/java/org/sonar/api/ce/measure/Component.java index bd8746a5fd2..ede0cce0b21 100644 --- a/sonar-plugin-api/src/main/java/org/sonar/api/ce/measure/Component.java +++ b/sonar-plugin-api/src/main/java/org/sonar/api/ce/measure/Component.java @@ -30,6 +30,8 @@ public interface Component { Type getType(); + String getKey(); + /** * The attributes of the Component if it's type is File. * diff --git a/sonar-plugin-api/src/test/java/org/sonar/api/test/ce/measure/ComponentImpl.java b/sonar-plugin-api/src/test/java/org/sonar/api/test/ce/measure/ComponentImpl.java index ca2936def4f..b8fef1332bc 100644 --- a/sonar-plugin-api/src/test/java/org/sonar/api/test/ce/measure/ComponentImpl.java +++ b/sonar-plugin-api/src/test/java/org/sonar/api/test/ce/measure/ComponentImpl.java @@ -59,6 +59,11 @@ public class ComponentImpl implements Component { return type; } + @Override + public String getKey() { + return key; + } + @Override public FileAttributes getFileAttributes() { checkState(this.type == Component.Type.FILE, "Only component of type FILE have a FileAttributes object"); -- 2.39.5