From 82a503a50a6b252190f2f91eeb40257209f52100 Mon Sep 17 00:00:00 2001 From: Hamid Dehnavi Date: Wed, 19 Jul 2023 16:08:54 +0330 Subject: [PATCH] Make adjustments based on the review Co-authored-by: Louis Chemineau Signed-off-by: Hamid Dehnavi --- lib/private/Notification/Action.php | 6 ------ lib/private/Notification/Notification.php | 21 --------------------- 2 files changed, 27 deletions(-) diff --git a/lib/private/Notification/Action.php b/lib/private/Notification/Action.php index f0e40f6e1d6..9590d28af4a 100644 --- a/lib/private/Notification/Action.php +++ b/lib/private/Notification/Action.php @@ -27,22 +27,16 @@ namespace OC\Notification; use OCP\Notification\IAction; class Action implements IAction { - /** @var string */ protected string $label; - /** @var string */ protected string $labelParsed; - /** @var string */ protected string $link; - /** @var string */ protected string $requestType; - /** @var string */ protected string $icon; - /** @var bool */ protected bool $primary; public function __construct() { diff --git a/lib/private/Notification/Notification.php b/lib/private/Notification/Notification.php index 1ae75a6b466..9222f3cb0e3 100644 --- a/lib/private/Notification/Notification.php +++ b/lib/private/Notification/Notification.php @@ -32,67 +32,46 @@ use OCP\RichObjectStrings\InvalidObjectExeption; use OCP\RichObjectStrings\IValidator; class Notification implements INotification { - /** @var string */ protected string $app; - /** @var string */ protected string $user; - /** @var \DateTime */ protected \DateTime $dateTime; - /** @var string */ protected string $objectType; - /** @var string */ protected string $objectId; - /** @var string */ protected string $subject; - /** @var array */ protected array $subjectParameters; - /** @var string */ protected string $subjectParsed; - /** @var string */ protected string $subjectRich; - /** @var array */ protected array $subjectRichParameters; - /** @var string */ protected string $message; - /** @var array */ protected array $messageParameters; - /** @var string */ protected string $messageParsed; - /** @var string */ protected string $messageRich; - /** @var array */ protected array $messageRichParameters; - /** @var string */ protected string $link; - /** @var string */ protected string $icon; - /** @var array */ protected array $actions; - /** @var array */ protected array $actionsParsed; - /** @var bool */ protected bool $hasPrimaryAction; - /** @var bool */ protected bool $hasPrimaryParsedAction; public function __construct( -- 2.39.5