From 85af4e6412e49c2e6a872feef00718a46c2fa2ce Mon Sep 17 00:00:00 2001 From: Jonathan Sampson Date: Tue, 11 Mar 2014 03:44:34 -0400 Subject: [PATCH] Manipulation: Change support test to be WWA-friendly Setting the innerHTML property in an unsafe manner raises issues in Windows Web Applications. Strings being passed into innerHTML cannot include the name attribute. Closes gh-1537 --- src/manipulation/support.js | 11 +++++++++-- 1 file changed, 9 insertions(+), 2 deletions(-) diff --git a/src/manipulation/support.js b/src/manipulation/support.js index e2ba066ec..fb1e85567 100644 --- a/src/manipulation/support.js +++ b/src/manipulation/support.js @@ -4,10 +4,17 @@ define([ (function() { var fragment = document.createDocumentFragment(), - div = fragment.appendChild( document.createElement( "div" ) ); + div = fragment.appendChild( document.createElement( "div" ) ), + input = document.createElement( "input" ); // #11217 - WebKit loses check when the name is after the checked attribute - div.innerHTML = ""; + // Support: Windows Web Apps (WWA) + // `name` and `type` need .setAttribute for WWA + input.setAttribute( "type", "radio" ); + input.setAttribute( "checked", "checked" ); + input.setAttribute( "name", "t" ); + + div.appendChild( input ); // Support: Safari 5.1, iOS 5.1, Android 4.x, Android 2.3 // old WebKit doesn't clone checked state correctly in fragments -- 2.39.5