From 85d48bdf93f28be5e2d442caf0c426f9ca436bab Mon Sep 17 00:00:00 2001
From: Brett Porter <brett@apache.org>
Date: Wed, 7 Jun 2006 08:19:57 +0000
Subject: [PATCH] some more notes

git-svn-id: https://svn.apache.org/repos/asf/maven/repository-manager/trunk@412324 13f79535-47bb-0310-9956-ffa450edef68
---
 .../indexing/DefaultRepositoryIndexSearcher.java       |  4 +++-
 .../indexing/DefaultRepositoryIndexingFactory.java     |  1 +
 .../maven/repository/proxy/DefaultProxyManager.java    |  1 +
 .../proxy/configuration/MavenProxyPropertyLoader.java  | 10 ++++++++--
 4 files changed, 13 insertions(+), 3 deletions(-)

diff --git a/maven-repository-indexer/src/main/java/org/apache/maven/repository/indexing/DefaultRepositoryIndexSearcher.java b/maven-repository-indexer/src/main/java/org/apache/maven/repository/indexing/DefaultRepositoryIndexSearcher.java
index fabe952bd..54def2bfb 100644
--- a/maven-repository-indexer/src/main/java/org/apache/maven/repository/indexing/DefaultRepositoryIndexSearcher.java
+++ b/maven-repository-indexer/src/main/java/org/apache/maven/repository/indexing/DefaultRepositoryIndexSearcher.java
@@ -47,7 +47,9 @@ import java.util.Map;
 import java.util.StringTokenizer;
 
 /**
- * Implementation Class for searching through the index
+ * Implementation Class for searching through the index.
+ *
+ * @todo this is not a component, but extends ALE, meaning logging will throw an exception! -- should be a component
  */
 public class DefaultRepositoryIndexSearcher
     extends AbstractLogEnabled
diff --git a/maven-repository-indexer/src/main/java/org/apache/maven/repository/indexing/DefaultRepositoryIndexingFactory.java b/maven-repository-indexer/src/main/java/org/apache/maven/repository/indexing/DefaultRepositoryIndexingFactory.java
index 8d38b715a..7c2af3ec0 100644
--- a/maven-repository-indexer/src/main/java/org/apache/maven/repository/indexing/DefaultRepositoryIndexingFactory.java
+++ b/maven-repository-indexer/src/main/java/org/apache/maven/repository/indexing/DefaultRepositoryIndexingFactory.java
@@ -23,6 +23,7 @@ import org.apache.maven.repository.digest.Digester;
 /**
  * @author Edwin Punzalan
  * @plexus.component role="org.apache.maven.repository.indexing.RepositoryIndexingFactory"
+ * @todo these methods should be replaced by plexus lookups of some kind!
  */
 public class DefaultRepositoryIndexingFactory
     implements RepositoryIndexingFactory
diff --git a/maven-repository-proxy/src/main/java/org/apache/maven/repository/proxy/DefaultProxyManager.java b/maven-repository-proxy/src/main/java/org/apache/maven/repository/proxy/DefaultProxyManager.java
index 08812b4de..ddac61885 100644
--- a/maven-repository-proxy/src/main/java/org/apache/maven/repository/proxy/DefaultProxyManager.java
+++ b/maven-repository-proxy/src/main/java/org/apache/maven/repository/proxy/DefaultProxyManager.java
@@ -53,6 +53,7 @@ import java.util.Map;
  * @plexus.component role="org.apache.maven.repository.proxy.ProxyManager"
  * @todo too much of wagon manager is reproduced here because checksums need to be downloaded separately - is that necessary?
  * @todo this isn't reusing the parts of wagon manager than handle snapshots [!]
+ * @todo currently, cache must be in the same layout as the request, which prohibits any mapping
  */
 public class DefaultProxyManager
     extends AbstractLogEnabled
diff --git a/maven-repository-proxy/src/main/java/org/apache/maven/repository/proxy/configuration/MavenProxyPropertyLoader.java b/maven-repository-proxy/src/main/java/org/apache/maven/repository/proxy/configuration/MavenProxyPropertyLoader.java
index 8e336b1c0..3fb52cc05 100644
--- a/maven-repository-proxy/src/main/java/org/apache/maven/repository/proxy/configuration/MavenProxyPropertyLoader.java
+++ b/maven-repository-proxy/src/main/java/org/apache/maven/repository/proxy/configuration/MavenProxyPropertyLoader.java
@@ -122,7 +122,10 @@ public class MavenProxyPropertyLoader
         return config;
     }
 
-    private void validateRemoteRepo( ProxyConfiguration configuration )
+    /**
+     * @todo should be shared with any other configuration loader - move method to configuration?
+     */
+    private static void validateRemoteRepo( ProxyConfiguration configuration )
         throws ValidationException
     {
         //Verify remote repository set
@@ -171,7 +174,10 @@ public class MavenProxyPropertyLoader
         return value;
     }
 
-    private void validateDirectories( ProxyConfiguration configuration )
+    /**
+     * @todo should be shared with any other configuration loader - move method to configuration?
+     */
+    private static void validateDirectories( ProxyConfiguration configuration )
         throws ValidationException
     {
         File f = new File( configuration.getRepositoryCachePath() );
-- 
2.39.5