From 85d749e23f32af63e4349931575e60abc4be857a Mon Sep 17 00:00:00 2001
From: Godin <mandrikov@gmail.com>
Date: Tue, 16 Nov 2010 16:08:53 +0000
Subject: [PATCH] Increase code coverage for XMLRuleParser

---
 .../java/org/sonar/api/rules/XMLRuleParserTest.java   | 11 +++++++++--
 1 file changed, 9 insertions(+), 2 deletions(-)

diff --git a/sonar-plugin-api/src/test/java/org/sonar/api/rules/XMLRuleParserTest.java b/sonar-plugin-api/src/test/java/org/sonar/api/rules/XMLRuleParserTest.java
index c444fdda875..02027741ceb 100644
--- a/sonar-plugin-api/src/test/java/org/sonar/api/rules/XMLRuleParserTest.java
+++ b/sonar-plugin-api/src/test/java/org/sonar/api/rules/XMLRuleParserTest.java
@@ -24,6 +24,7 @@ import org.junit.Test;
 import org.sonar.api.utils.SonarException;
 import org.sonar.check.Cardinality;
 
+import java.io.File;
 import java.io.StringReader;
 import java.util.List;
 
@@ -35,8 +36,9 @@ import static org.junit.Assert.assertThat;
 public class XMLRuleParserTest {
 
   @Test
-  public void parseXml() {
-    List<Rule> rules = new XMLRuleParser().parse(getClass().getResourceAsStream("/org/sonar/api/rules/XMLRuleParserTest/rules.xml"));
+  public void parseXml() throws Exception {
+    File file = new File(getClass().getResource("/org/sonar/api/rules/XMLRuleParserTest/rules.xml").toURI());
+    List<Rule> rules = new XMLRuleParser().parse(file);
     assertThat(rules.size(), is(2));
 
     Rule rule = rules.get(0);
@@ -63,6 +65,11 @@ public class XMLRuleParserTest {
     new XMLRuleParser().parse(new StringReader("<rules><rule><name>Foo</name></rule></rules>"));
   }
 
+  @Test(expected = SonarException.class)
+  public void failIfMissingRuleName() {
+    new XMLRuleParser().parse(new StringReader("<rules><rule><key>foo</key></rule></rules>"));
+  }
+
   @Test(expected = SonarException.class)
   public void failIfMissingPropertyKey() {
     new XMLRuleParser().parse(new StringReader("<rules><rule><key>foo</key><name>Foo</name><param></param></rule></rules>"));
-- 
2.39.5