From 876ee0fd76b6c464740379cc8fb8d5001e8628c7 Mon Sep 17 00:00:00 2001 From: =?utf8?q?Daniel=20Calvi=C3=B1o=20S=C3=A1nchez?= Date: Sat, 24 Nov 2018 18:16:09 +0100 Subject: [PATCH] Wait for the comment to be added before changing to another file MIME-Version: 1.0 Content-Type: text/plain; charset=utf8 Content-Transfer-Encoding: 8bit If the server is too slow, changing to a different file immediately after sending a new comment but without waiting for the comment to be shown for the original file could cause the new comment to be shown for the current file instead. This is, indeed, a bug in the comments. However, it is not possible to test it reliably in the acceptance tests, as it depends on how fast the server adds the message and how fast the client changes to a different file; sometimes the test would fail and sometimes it would not. Therefore, now it is waited for the comment to be added before changing to another file, as in this case it can be reliably tested that changing to a different file does not cause the comments from the previous file to be shown in the current file (this was a different bug already fixed and due to which this test was added in the first place). Signed-off-by: Daniel Calviño Sánchez --- tests/acceptance/features/app-comments.feature | 1 + 1 file changed, 1 insertion(+) diff --git a/tests/acceptance/features/app-comments.feature b/tests/acceptance/features/app-comments.feature index 1ee113d0aac..42893e5ea35 100644 --- a/tests/acceptance/features/app-comments.feature +++ b/tests/acceptance/features/app-comments.feature @@ -24,6 +24,7 @@ Feature: app-comments And I open the details view for "Folder" And I open the "Comments" tab in the details view And I create a new comment with "Comment in Folder" as message + And I see a comment with "Comment in Folder" as message And I open the details view for "welcome.txt" # The "Comments" tab should already be opened When I create a new comment with "Comment in welcome.txt" as message -- 2.39.5