From 8888d2fdfab4589720ee7cda5173e72374aa484a Mon Sep 17 00:00:00 2001
From: Guillaume Peoc'h <guillaume.peoch@sonarsource.com>
Date: Thu, 1 Sep 2022 11:44:30 +0200
Subject: [PATCH] SONAR-16878 [891665] Form elements must have labels

---
 .../HotspotReviewHistoryAndComments.tsx       |  7 +--
 ...spotReviewHistoryAndComments-test.tsx.snap | 49 +++++++++----------
 2 files changed, 28 insertions(+), 28 deletions(-)

diff --git a/server/sonar-web/src/main/js/apps/security-hotspots/components/HotspotReviewHistoryAndComments.tsx b/server/sonar-web/src/main/js/apps/security-hotspots/components/HotspotReviewHistoryAndComments.tsx
index 68813b61263..32e8ec99959 100644
--- a/server/sonar-web/src/main/js/apps/security-hotspots/components/HotspotReviewHistoryAndComments.tsx
+++ b/server/sonar-web/src/main/js/apps/security-hotspots/components/HotspotReviewHistoryAndComments.tsx
@@ -93,9 +93,10 @@ export default class HotspotReviewHistoryAndComments extends React.PureComponent
     return (
       <div className="padded it__hs-review-history">
         {isLoggedIn(currentUser) && (
-          <div>
-            <div className="little-spacer-bottom">{translate('hotspots.comment.field')}</div>
+          <>
+            <label htmlFor="security-hotspot-comment">{translate('hotspots.comment.field')}</label>
             <textarea
+              id="security-hotspot-comment"
               className="form-field fixed-width width-100 spacer-bottom"
               onChange={this.handleCommentChange}
               ref={commentTextRef}
@@ -113,7 +114,7 @@ export default class HotspotReviewHistoryAndComments extends React.PureComponent
                 </Button>
               </div>
             </div>
-          </div>
+          </>
         )}
 
         <h2 className="spacer-top big-spacer-bottom">{translate('hotspot.section.activity')}</h2>
diff --git a/server/sonar-web/src/main/js/apps/security-hotspots/components/__tests__/__snapshots__/HotspotReviewHistoryAndComments-test.tsx.snap b/server/sonar-web/src/main/js/apps/security-hotspots/components/__tests__/__snapshots__/HotspotReviewHistoryAndComments-test.tsx.snap
index 4ff3d4da333..92eb3c747a9 100644
--- a/server/sonar-web/src/main/js/apps/security-hotspots/components/__tests__/__snapshots__/HotspotReviewHistoryAndComments-test.tsx.snap
+++ b/server/sonar-web/src/main/js/apps/security-hotspots/components/__tests__/__snapshots__/HotspotReviewHistoryAndComments-test.tsx.snap
@@ -4,33 +4,32 @@ exports[`should render correctly 1`] = `
 <div
   className="padded it__hs-review-history"
 >
-  <div>
-    <div
-      className="little-spacer-bottom"
-    >
-      hotspots.comment.field
-    </div>
-    <textarea
-      className="form-field fixed-width width-100 spacer-bottom"
-      onChange={[Function]}
-      rows={2}
-      value=""
+  <label
+    htmlFor="security-hotspot-comment"
+  >
+    hotspots.comment.field
+  </label>
+  <textarea
+    className="form-field fixed-width width-100 spacer-bottom"
+    id="security-hotspot-comment"
+    onChange={[Function]}
+    rows={2}
+    value=""
+  />
+  <div
+    className="display-flex-space-between display-flex-center "
+  >
+    <FormattingTips
+      className="huge-spacer-bottom"
     />
-    <div
-      className="display-flex-space-between display-flex-center "
-    >
-      <FormattingTips
+    <div>
+      <Button
         className="huge-spacer-bottom"
-      />
-      <div>
-        <Button
-          className="huge-spacer-bottom"
-          id="hotspot-comment-box-submit"
-          onClick={[Function]}
-        >
-          hotspots.comment.submit
-        </Button>
-      </div>
+        id="hotspot-comment-box-submit"
+        onClick={[Function]}
+      >
+        hotspots.comment.submit
+      </Button>
     </div>
   </div>
   <h2
-- 
2.39.5