From 89442ad258d001b6a6ca03483442df14c6724731 Mon Sep 17 00:00:00 2001
From: Jeremy Davis <jeremy.davis@sonarsource.com>
Date: Wed, 4 Nov 2020 15:06:42 +0100
Subject: [PATCH] SONAR-14058 Add URL to azure config form

---
 .../AlmBindingDefinitionBox.tsx               | 38 +++++++++++++---
 .../components/almIntegration/AzureForm.tsx   | 15 +++++++
 .../components/almIntegration/AzureTab.tsx    |  2 +-
 .../__tests__/AzureForm-test.tsx              |  4 +-
 .../AlmBindingDefinitionBox-test.tsx.snap     | 44 +++++++++++++++----
 .../__snapshots__/AzureForm-test.tsx.snap     | 36 ++++++++++++++-
 .../__snapshots__/AzureTab-test.tsx.snap      |  1 +
 .../src/main/js/types/alm-settings.ts         |  1 +
 .../resources/org/sonar/l10n/core.properties  |  7 ++-
 9 files changed, 126 insertions(+), 22 deletions(-)

diff --git a/server/sonar-web/src/main/js/apps/settings/components/almIntegration/AlmBindingDefinitionBox.tsx b/server/sonar-web/src/main/js/apps/settings/components/almIntegration/AlmBindingDefinitionBox.tsx
index 74203d53f70..fa55dca833d 100644
--- a/server/sonar-web/src/main/js/apps/settings/components/almIntegration/AlmBindingDefinitionBox.tsx
+++ b/server/sonar-web/src/main/js/apps/settings/components/almIntegration/AlmBindingDefinitionBox.tsx
@@ -57,6 +57,7 @@ const STATUS_ICON = {
 };
 
 function getImportFeatureStatus(
+  definition: AlmBindingDefinition,
   multipleDefinitions: boolean,
   type: AlmSettingsBindingStatusType.Success | AlmSettingsBindingStatusType.Failure
 ) {
@@ -68,7 +69,19 @@ function getImportFeatureStatus(
         </strong>
         <HelpTooltip
           className="little-spacer-left"
-          overlay={translate('settings.almintegration.feature.alm_repo_import.help')}
+          overlay={translate('settings.almintegration.feature.alm_repo_import.disabled.multiple')}
+        />
+      </div>
+    );
+  } else if (!definition.url) {
+    return (
+      <div className="display-inline-flex-center">
+        <strong className="spacer-left">
+          {translate('settings.almintegration.feature.alm_repo_import.disabled')}
+        </strong>
+        <HelpTooltip
+          className="little-spacer-left"
+          overlay={translate('settings.almintegration.feature.alm_repo_import.disabled.no_url')}
         />
       </div>
     );
@@ -111,10 +124,23 @@ export default function AlmBindingDefinitionBox(props: AlmBindingDefinitionBoxPr
       {!VALIDATED_ALMS.includes(alm) && (
         <>
           <div className="display-flex-row spacer-bottom">
-            <Tooltip overlay={importFeatureDescription}>
-              <span>{importFeatureTitle}</span>
-            </Tooltip>
-            <AlertSuccessIcon className="spacer-left" />
+            <div className="huge-spacer-right">
+              <Tooltip overlay={importFeatureDescription}>
+                <span>{importFeatureTitle}</span>
+              </Tooltip>
+              <AlertSuccessIcon className="spacer-left" />
+            </div>
+            <div>
+              <Tooltip
+                overlay={translate('settings.almintegration.feature.alm_repo_import.description')}>
+                <span>{translate('settings.almintegration.feature.alm_repo_import.title')}</span>
+              </Tooltip>
+              {getImportFeatureStatus(
+                definition,
+                multipleDefinitions,
+                AlmSettingsBindingStatusType.Success
+              )}
+            </div>
           </div>
 
           <div className="width-50">
@@ -148,7 +174,7 @@ export default function AlmBindingDefinitionBox(props: AlmBindingDefinitionBoxPr
                       {translate('settings.almintegration.feature.alm_repo_import.title')}
                     </span>
                   </Tooltip>
-                  {getImportFeatureStatus(multipleDefinitions, status.type)}
+                  {getImportFeatureStatus(definition, multipleDefinitions, status.type)}
                 </div>
               </div>
             )}
diff --git a/server/sonar-web/src/main/js/apps/settings/components/almIntegration/AzureForm.tsx b/server/sonar-web/src/main/js/apps/settings/components/almIntegration/AzureForm.tsx
index fef12180192..3ce487298e1 100644
--- a/server/sonar-web/src/main/js/apps/settings/components/almIntegration/AzureForm.tsx
+++ b/server/sonar-web/src/main/js/apps/settings/components/almIntegration/AzureForm.tsx
@@ -45,6 +45,21 @@ export default function AzureForm(props: AzureFormProps) {
           value={formData.key}
         />
       )}
+      <AlmBindingDefinitionFormField
+        help={
+          <>
+            {translate('settings.almintegration.form.url.azure.help')}
+            <br />
+            <em>https://ado.your-company.com/DefaultCollection</em>
+          </>
+        }
+        id="url.azure"
+        maxLength={2000}
+        onFieldChange={onFieldChange}
+        propKey="url"
+        readOnly={readOnly}
+        value={formData.url || ''}
+      />
       <AlmBindingDefinitionFormField
         help={translate('settings.almintegration.form.personal_access_token.azure.help')}
         id="personal_access_token"
diff --git a/server/sonar-web/src/main/js/apps/settings/components/almIntegration/AzureTab.tsx b/server/sonar-web/src/main/js/apps/settings/components/almIntegration/AzureTab.tsx
index f6998962796..55834019bff 100644
--- a/server/sonar-web/src/main/js/apps/settings/components/almIntegration/AzureTab.tsx
+++ b/server/sonar-web/src/main/js/apps/settings/components/almIntegration/AzureTab.tsx
@@ -52,7 +52,7 @@ export default function AzureTab(props: AzureTabProps) {
       <AlmTab
         alm={AlmKeys.Azure}
         createConfiguration={createAzureConfiguration}
-        defaultBinding={{ key: '', personalAccessToken: '' }}
+        defaultBinding={{ key: '', personalAccessToken: '', url: '' }}
         definitions={definitions}
         definitionStatus={definitionStatus}
         form={childProps => <AzureForm {...childProps} />}
diff --git a/server/sonar-web/src/main/js/apps/settings/components/almIntegration/__tests__/AzureForm-test.tsx b/server/sonar-web/src/main/js/apps/settings/components/almIntegration/__tests__/AzureForm-test.tsx
index fe4a99102a0..3faea7a6a07 100644
--- a/server/sonar-web/src/main/js/apps/settings/components/almIntegration/__tests__/AzureForm-test.tsx
+++ b/server/sonar-web/src/main/js/apps/settings/components/almIntegration/__tests__/AzureForm-test.tsx
@@ -23,8 +23,8 @@ import { mockAzureBindingDefinition } from '../../../../../helpers/mocks/alm-set
 import AzureForm, { AzureFormProps } from '../AzureForm';
 
 it('should render correctly', () => {
-  expect(shallowRender()).toMatchSnapshot();
-  expect(shallowRender({ formData: mockAzureBindingDefinition() })).toMatchSnapshot();
+  expect(shallowRender()).toMatchSnapshot('create');
+  expect(shallowRender({ formData: mockAzureBindingDefinition() })).toMatchSnapshot('edit');
 });
 
 function shallowRender(props: Partial<AzureFormProps> = {}) {
diff --git a/server/sonar-web/src/main/js/apps/settings/components/almIntegration/__tests__/__snapshots__/AlmBindingDefinitionBox-test.tsx.snap b/server/sonar-web/src/main/js/apps/settings/components/almIntegration/__tests__/__snapshots__/AlmBindingDefinitionBox-test.tsx.snap
index 43bc1bfbc5b..2fd332649c6 100644
--- a/server/sonar-web/src/main/js/apps/settings/components/almIntegration/__tests__/__snapshots__/AlmBindingDefinitionBox-test.tsx.snap
+++ b/server/sonar-web/src/main/js/apps/settings/components/almIntegration/__tests__/__snapshots__/AlmBindingDefinitionBox-test.tsx.snap
@@ -35,16 +35,42 @@ exports[`should render correctly: Azure DevOps 1`] = `
   <div
     className="display-flex-row spacer-bottom"
   >
-    <Tooltip
-      overlay="settings.almintegration.feature.pr_decoration.description"
+    <div
+      className="huge-spacer-right"
     >
-      <span>
-        settings.almintegration.feature.pr_decoration.title
-      </span>
-    </Tooltip>
-    <AlertSuccessIcon
-      className="spacer-left"
-    />
+      <Tooltip
+        overlay="settings.almintegration.feature.pr_decoration.description"
+      >
+        <span>
+          settings.almintegration.feature.pr_decoration.title
+        </span>
+      </Tooltip>
+      <AlertSuccessIcon
+        className="spacer-left"
+      />
+    </div>
+    <div>
+      <Tooltip
+        overlay="settings.almintegration.feature.alm_repo_import.description"
+      >
+        <span>
+          settings.almintegration.feature.alm_repo_import.title
+        </span>
+      </Tooltip>
+      <div
+        className="display-inline-flex-center"
+      >
+        <strong
+          className="spacer-left"
+        >
+          settings.almintegration.feature.alm_repo_import.disabled
+        </strong>
+        <HelpTooltip
+          className="little-spacer-left"
+          overlay="settings.almintegration.feature.alm_repo_import.disabled.no_url"
+        />
+      </div>
+    </div>
   </div>
   <div
     className="width-50"
diff --git a/server/sonar-web/src/main/js/apps/settings/components/almIntegration/__tests__/__snapshots__/AzureForm-test.tsx.snap b/server/sonar-web/src/main/js/apps/settings/components/almIntegration/__tests__/__snapshots__/AzureForm-test.tsx.snap
index ba43fbcd654..99c2341cba2 100644
--- a/server/sonar-web/src/main/js/apps/settings/components/almIntegration/__tests__/__snapshots__/AzureForm-test.tsx.snap
+++ b/server/sonar-web/src/main/js/apps/settings/components/almIntegration/__tests__/__snapshots__/AzureForm-test.tsx.snap
@@ -1,6 +1,6 @@
 // Jest Snapshot v1, https://goo.gl/fbAQLP
 
-exports[`should render correctly 1`] = `
+exports[`should render correctly: create 1`] = `
 <Fragment>
   <AlmBindingDefinitionFormField
     autoFocus={true}
@@ -10,6 +10,22 @@ exports[`should render correctly 1`] = `
     propKey="key"
     value=""
   />
+  <AlmBindingDefinitionFormField
+    help={
+      <React.Fragment>
+        settings.almintegration.form.url.azure.help
+        <br />
+        <em>
+          https://ado.your-company.com/
+        </em>
+      </React.Fragment>
+    }
+    id="url.azure"
+    maxLength={2000}
+    onFieldChange={[MockFunction]}
+    propKey="url"
+    value=""
+  />
   <AlmBindingDefinitionFormField
     help="settings.almintegration.form.personal_access_token.azure.help"
     id="personal_access_token"
@@ -21,7 +37,7 @@ exports[`should render correctly 1`] = `
 </Fragment>
 `;
 
-exports[`should render correctly 2`] = `
+exports[`should render correctly: edit 1`] = `
 <Fragment>
   <AlmBindingDefinitionFormField
     autoFocus={true}
@@ -31,6 +47,22 @@ exports[`should render correctly 2`] = `
     propKey="key"
     value="key"
   />
+  <AlmBindingDefinitionFormField
+    help={
+      <React.Fragment>
+        settings.almintegration.form.url.azure.help
+        <br />
+        <em>
+          https://ado.your-company.com/
+        </em>
+      </React.Fragment>
+    }
+    id="url.azure"
+    maxLength={2000}
+    onFieldChange={[MockFunction]}
+    propKey="url"
+    value=""
+  />
   <AlmBindingDefinitionFormField
     help="settings.almintegration.form.personal_access_token.azure.help"
     id="personal_access_token"
diff --git a/server/sonar-web/src/main/js/apps/settings/components/almIntegration/__tests__/__snapshots__/AzureTab-test.tsx.snap b/server/sonar-web/src/main/js/apps/settings/components/almIntegration/__tests__/__snapshots__/AzureTab-test.tsx.snap
index 395e569599d..4f8aeff8b9a 100644
--- a/server/sonar-web/src/main/js/apps/settings/components/almIntegration/__tests__/__snapshots__/AzureTab-test.tsx.snap
+++ b/server/sonar-web/src/main/js/apps/settings/components/almIntegration/__tests__/__snapshots__/AzureTab-test.tsx.snap
@@ -11,6 +11,7 @@ exports[`should render correctly 1`] = `
       Object {
         "key": "",
         "personalAccessToken": "",
+        "url": "",
       }
     }
     definitionStatus={Object {}}
diff --git a/server/sonar-web/src/main/js/types/alm-settings.ts b/server/sonar-web/src/main/js/types/alm-settings.ts
index 09284f3c8c3..8ae38c80b91 100644
--- a/server/sonar-web/src/main/js/types/alm-settings.ts
+++ b/server/sonar-web/src/main/js/types/alm-settings.ts
@@ -31,6 +31,7 @@ export interface AlmBindingDefinition {
 
 export interface AzureBindingDefinition extends AlmBindingDefinition {
   personalAccessToken: string;
+  url?: string;
 }
 
 export interface BitbucketBindingDefinition extends AlmBindingDefinition {
diff --git a/sonar-core/src/main/resources/org/sonar/l10n/core.properties b/sonar-core/src/main/resources/org/sonar/l10n/core.properties
index 3ba74543794..f8cd9e2d12e 100644
--- a/sonar-core/src/main/resources/org/sonar/l10n/core.properties
+++ b/sonar-core/src/main/resources/org/sonar/l10n/core.properties
@@ -1073,7 +1073,7 @@ settings.almintegration.check_configuration=Check configuration
 settings.almintegration.checking_configuration=Checking configuration
 settings.almintegration.configuration_valid=Configuration valid
 settings.almintegration.could_not_validate=Could not validate this configuration.
-settings.almintegration.no_validation=Pull Request decoration is enabled. However, SonarQube doesn't currently validate Azure DevOps Server configurations.
+settings.almintegration.no_validation=SonarQube doesn't currently validate Azure DevOps Server configurations.
 settings.almintegration.delete.header=Delete configuration
 settings.almintegration.delete.message=Are you sure you want to delete the {id} configuration?
 settings.almintegration.delete.info={0} projects will no longer get Pull Request Decorations.
@@ -1089,6 +1089,8 @@ settings.almintegration.form.name.github=Configuration name
 settings.almintegration.form.name.github.help=Give your configuration a clear and succinct name. This name will be used at project level to identify the correct configured GitHub App for a project.
 settings.almintegration.form.name.gitlab=Configuration name
 settings.almintegration.form.name.gitlab.help=Give your configuration a clear and succinct name. This name will be used at project level to identify the correct configured GitLab instance for a project.
+settings.almintegration.form.url.azure=Azure DevOps Server collection URL
+settings.almintegration.form.url.azure.help=Provide the full Azure DevOps Server collection URL. For example:
 settings.almintegration.form.url.bitbucket=Bitbucket Server URL
 settings.almintegration.form.url.bitbucket.help=Example: {example}
 settings.almintegration.form.url.github=GitHub API URL
@@ -1112,7 +1114,8 @@ settings.almintegration.feature.mr_decoration.description=Add analysis and a Qua
 settings.almintegration.feature.alm_repo_import.title=Import repositories from your ALM
 settings.almintegration.feature.alm_repo_import.description=Select repositories from your ALM, and import them into SonarQube.
 settings.almintegration.feature.alm_repo_import.disabled=Disabled
-settings.almintegration.feature.alm_repo_import.help=This feature is disabled because you have 2 or more integration instances configured.
+settings.almintegration.feature.alm_repo_import.disabled.multiple=This feature is disabled because you have 2 or more integration instances configured.
+settings.almintegration.feature.alm_repo_import.disabled.no_url=This feature is disabled because your configured instance has no URL.
 
 settings.pr_decoration.binding.category=Pull Request Decoration
 settings.pr_decoration.binding.no_bindings=This feature must first be enabled in the global settings. {link}
-- 
2.39.5