From 8d44e537ac1ee41662743db5525e910a58c08d70 Mon Sep 17 00:00:00 2001 From: Roeland Jago Douma Date: Wed, 27 Jan 2016 22:34:27 +0100 Subject: [PATCH] [Share 2.0] Remove setId and setProviderId from the interface Those should only ever be set by the providers --- lib/private/share20/manager.php | 2 -- lib/public/share/ishare.php | 18 ------------------ 2 files changed, 20 deletions(-) diff --git a/lib/private/share20/manager.php b/lib/private/share20/manager.php index 52580e27818..d6245f4beac 100644 --- a/lib/private/share20/manager.php +++ b/lib/private/share20/manager.php @@ -497,7 +497,6 @@ class Manager implements IManager { $provider = $this->factory->getProviderForType($share->getShareType()); $share = $provider->create($share); - $share->setProviderId($provider->identifier()); // Post share hook $postHookData = [ @@ -754,7 +753,6 @@ class Manager implements IManager { $provider = $this->factory->getProvider($providerId); $share = $provider->getShareById($id); - $share->setProviderId($provider->identifier()); return $share; } diff --git a/lib/public/share/ishare.php b/lib/public/share/ishare.php index 2fb41a17add..80e7f7f56ef 100644 --- a/lib/public/share/ishare.php +++ b/lib/public/share/ishare.php @@ -43,15 +43,6 @@ interface IShare { */ public function getId(); - /** - * Set the internal id of the share. - * - * @param string $id - * @return \OCP\Share\IShare The modified share object - * @since 9.0.0 - */ - public function setId($id); - /** * Get the full share id. This is the :. * The full id is unique in the system. @@ -61,15 +52,6 @@ interface IShare { */ public function getFullId(); - /** - * Set the provider id - * - * @param string $id - * @return \OCP\Share\IShare The modified share object\ - * @since 9.0.0 - */ - public function setProviderId($id); - /** * Set the node of the file/folder that is shared * -- 2.39.5