From 8ef3a6caa4a6e190062a65b7e3e96915d913f3af Mon Sep 17 00:00:00 2001 From: Eric Hartmann Date: Tue, 10 Sep 2013 11:00:00 +0200 Subject: [PATCH] Finish merge of master --- .../SendIssueNotificationsPostJobTest.java | 20 ------------------- pom.xml | 20 +++---------------- sonar-duplications/pom.xml | 11 ++++++++++ 3 files changed, 14 insertions(+), 37 deletions(-) diff --git a/plugins/sonar-core-plugin/src/test/java/org/sonar/plugins/core/issue/notification/SendIssueNotificationsPostJobTest.java b/plugins/sonar-core-plugin/src/test/java/org/sonar/plugins/core/issue/notification/SendIssueNotificationsPostJobTest.java index 87276370b60..82a1fe70ff4 100644 --- a/plugins/sonar-core-plugin/src/test/java/org/sonar/plugins/core/issue/notification/SendIssueNotificationsPostJobTest.java +++ b/plugins/sonar-core-plugin/src/test/java/org/sonar/plugins/core/issue/notification/SendIssueNotificationsPostJobTest.java @@ -170,24 +170,4 @@ public class SendIssueNotificationsPostJobTest { return map.size() == 1 && map.get(issue) != null && map.get(issue).equals(rule); } } - - @Test - public void should_not_send_notification_on_any_change() throws Exception { - IssueChangeContext changeContext = mock(IssueChangeContext.class); - - when(project.getAnalysisDate()).thenReturn(DateUtils.parseDate("2013-05-18")); - RuleKey ruleKey = RuleKey.of("squid", "AvoidCycles"); - DefaultIssue issue = new DefaultIssue() - .setChanged(true) - .setSendNotifications(false) - .setFieldChange(changeContext, "severity", "MINOR", "BLOCKER") - .setRuleKey(ruleKey); - when(issueCache.all()).thenReturn(Arrays.asList(issue)); - when(ruleFinder.findByKey(ruleKey)).thenReturn(null); - - SendIssueNotificationsPostJob job = new SendIssueNotificationsPostJob(issueCache, notifications, ruleFinder); - job.executeOn(project, sensorContext); - - verify(notifications, never()).sendChanges(eq(issue), eq(changeContext), any(Rule.class), any(Component.class), any(Component.class)); - } } diff --git a/pom.xml b/pom.xml index 6e5fe233a56..e104363a576 100644 --- a/pom.xml +++ b/pom.xml @@ -71,7 +71,7 @@ - 1.6.1 + 1.8 1.3 3.3.1 1.3.172 @@ -349,22 +349,8 @@ true - - - - - - enforce-no-repositories - - enforce - - - - - The rules for repo1.maven.org are that pom.xml files should not include repository - definitions. - + Definition of new repositories is not allowed in order to deploy to central repository. @@ -1091,7 +1077,7 @@ scm:git:git@github.com:SonarSource/sonar.git scm:git:git@github.com:SonarSource/sonar.git https://github.com/SonarSource/sonar - 3.7-RC1 + HEAD diff --git a/sonar-duplications/pom.xml b/sonar-duplications/pom.xml index d9777ddd1aa..f7fb7114f78 100644 --- a/sonar-duplications/pom.xml +++ b/sonar-duplications/pom.xml @@ -25,7 +25,18 @@ com.google.guava guava + + com.google.code.findbugs + jsr305 + provided + + + + commons-io + commons-io + test + pmd pmd -- 2.39.5