From 90d7e00154b26dfc22b0ea46fc7775e39430eeec Mon Sep 17 00:00:00 2001
From: Jouni Koivuviita <jouni@vaadin.com>
Date: Tue, 19 Aug 2014 11:06:02 +0300
Subject: [PATCH] Table column resize does not work in Valo (Firefox) ( #14401)

Fix a similar issue with context menu items also.

Change-Id: I1c851ea43aa81a39e2c4596315b34976df0cba62
---
 WebContent/VAADIN/themes/valo/components/_table.scss   | 10 ++++++----
 WebContent/VAADIN/themes/valo/shared/_contextmenu.scss |  1 +
 2 files changed, 7 insertions(+), 4 deletions(-)

diff --git a/WebContent/VAADIN/themes/valo/components/_table.scss b/WebContent/VAADIN/themes/valo/components/_table.scss
index 46318590d0..3144acb37c 100644
--- a/WebContent/VAADIN/themes/valo/components/_table.scss
+++ b/WebContent/VAADIN/themes/valo/components/_table.scss
@@ -153,10 +153,10 @@ $v-table-background-color: null !default;
     width: $v-table-resizer-width;
     cursor: e-resize;
     cursor: col-resize;
-    position: absolute;
-    top: 0;
+    position: relative;
     right: round($v-table-resizer-width / -2);
     z-index: 1;
+    margin-left: -$v-table-resizer-width;
   }
 
   .#{$primary-stylename}-cell-content {
@@ -248,8 +248,7 @@ $v-table-background-color: null !default;
     width: $v-table-sort-indicator-width;
     height: $v-table-row-height;
     line-height: $v-table-row-height;
-    position: absolute;
-    right: 0;
+    margin-left: -$v-table-sort-indicator-width;
   }
 
   .#{$primary-stylename}-header-cell-asc .#{$primary-stylename}-sort-indicator:before,
@@ -295,13 +294,16 @@ $v-table-background-color: null !default;
   .#{$primary-stylename}-focus-slot-right {
     border-right: $v-table-border-width + 2px solid $v-focus-color;
     right: -$v-table-border-width - 1px;
+    margin-left: -$v-table-resizer-width - $v-table-border-width - 2px;
   }
 
   .#{$primary-stylename}-focus-slot-left {
+    float: left;
     border-left: $v-table-border-width + 2px solid $v-focus-color;
     left: -$v-table-border-width;
     right: auto;
     margin-left: 0 !important;
+    margin-right: -$v-table-resizer-width - $v-table-border-width - 2px;
   }
 
   .#{$primary-stylename}-column-selector {
diff --git a/WebContent/VAADIN/themes/valo/shared/_contextmenu.scss b/WebContent/VAADIN/themes/valo/shared/_contextmenu.scss
index 8a3894b524..4b737416c2 100644
--- a/WebContent/VAADIN/themes/valo/shared/_contextmenu.scss
+++ b/WebContent/VAADIN/themes/valo/shared/_contextmenu.scss
@@ -10,6 +10,7 @@
 
   .v-contextmenu .gwt-MenuItem {
     @include valo-selection-item-style;
+    display: block; // Firefox 24 needs this to make position: relative; work
   }
 
   .v-contextmenu .gwt-MenuItem-selected {
-- 
2.39.5