From 923a1f48ceecfefbcf8e2bf46da71c38a70854d6 Mon Sep 17 00:00:00 2001 From: Andy Clement Date: Fri, 20 Oct 2017 12:41:48 -0700 Subject: [PATCH] removed shared reflection world test for now --- .../weaver/TestJava5ReflectionBasedReferenceTypeDelegate.java | 3 +-- .../org/aspectj/weaver/reflect/ReflectionWorldTest.java | 4 +++- 2 files changed, 4 insertions(+), 3 deletions(-) diff --git a/weaver5/java5-testsrc/org/aspectj/weaver/TestJava5ReflectionBasedReferenceTypeDelegate.java b/weaver5/java5-testsrc/org/aspectj/weaver/TestJava5ReflectionBasedReferenceTypeDelegate.java index 9474d63cd..f5061e32b 100644 --- a/weaver5/java5-testsrc/org/aspectj/weaver/TestJava5ReflectionBasedReferenceTypeDelegate.java +++ b/weaver5/java5-testsrc/org/aspectj/weaver/TestJava5ReflectionBasedReferenceTypeDelegate.java @@ -1,5 +1,5 @@ /* ******************************************************************* - * Copyright (c) 2005 Contributors. + * Copyright (c) 2005-2017 Contributors. * All rights reserved. * This program and the accompanying materials are made available * under the terms of the Eclipse Public License v1.0 @@ -77,7 +77,6 @@ public class TestJava5ReflectionBasedReferenceTypeDelegate extends ReflectionBas ResolvedType rt2 = genericType.getSuperclass(); assertTrue("Superclass for Map generic type should be Object but was " + rt2, rt2.equals(UnresolvedType.OBJECT)); } - /** * This is testing the optimization in the reflective annotation finder to verify that if you only want runtime diff --git a/weaver5/java5-testsrc/org/aspectj/weaver/reflect/ReflectionWorldTest.java b/weaver5/java5-testsrc/org/aspectj/weaver/reflect/ReflectionWorldTest.java index db3e44711..1108ca13c 100644 --- a/weaver5/java5-testsrc/org/aspectj/weaver/reflect/ReflectionWorldTest.java +++ b/weaver5/java5-testsrc/org/aspectj/weaver/reflect/ReflectionWorldTest.java @@ -40,7 +40,9 @@ public class ReflectionWorldTest extends TestCase { assertEquals("Ljava/lang/Object;", rt.getSignature()); } - public void testReflectionWorldFactory() throws Exception { + // Removed for now. In Spring the reflection worlds are customized by introducing new + // PCD handlers. It means more thought needs to be put into reusing worlds. + public void xtestReflectionWorldFactory() throws Exception { ClassLoader parent = getClass().getClassLoader(); ClassLoader cl1 = new URLClassLoader(new URL[] {}, parent); ClassLoader cl2 = new URLClassLoader(new URL[] {}, parent); -- 2.39.5