From 92c16e8dc34f86500628a825141cd035bdf1bc4a Mon Sep 17 00:00:00 2001 From: aclement Date: Fri, 19 Aug 2005 16:17:14 +0000 Subject: [PATCH] genericitds: I'll be finished when I get to Z --- .../generics/genericaspects/GenericAspectR.aj | 8 +- .../generics/genericaspects/GenericAspectS.aj | 140 +++++++++++++++++ .../generics/genericaspects/GenericAspectT.aj | 15 ++ .../generics/genericaspects/GenericAspectU.aj | 148 ++++++++++++++++++ 4 files changed, 306 insertions(+), 5 deletions(-) create mode 100644 tests/java5/generics/genericaspects/GenericAspectS.aj create mode 100644 tests/java5/generics/genericaspects/GenericAspectT.aj create mode 100644 tests/java5/generics/genericaspects/GenericAspectU.aj diff --git a/tests/java5/generics/genericaspects/GenericAspectR.aj b/tests/java5/generics/genericaspects/GenericAspectR.aj index 73a81b91e..85a88c829 100644 --- a/tests/java5/generics/genericaspects/GenericAspectR.aj +++ b/tests/java5/generics/genericaspects/GenericAspectR.aj @@ -14,12 +14,9 @@ abstract aspect ParentChildRelationship { public P ChildHasParent

.parent; public List ParentHasChildren.getChildren() { - return children;//Collections.unmodifiableList(children); + return Collections.unmodifiableList(children); } -// public List getChildren() { -// return Collections.unmodifiableList(new ArrayList()); -// } } @@ -87,7 +84,8 @@ class Bottom {} TestO promoted the fields up - a parent knows its children, a child knows its parents - but then used them incorrectly TestP uses the fields correctly - TestQ promoted getChildren() method + TestQ ... tests some stumbling blocks I encountered... + TestR promoted getChildren() method public abstract aspect ParentChildRelationship { diff --git a/tests/java5/generics/genericaspects/GenericAspectS.aj b/tests/java5/generics/genericaspects/GenericAspectS.aj new file mode 100644 index 000000000..b7ef626a9 --- /dev/null +++ b/tests/java5/generics/genericaspects/GenericAspectS.aj @@ -0,0 +1,140 @@ +import java.util.*; +import java.lang.reflect.*; +import org.aspectj.lang.annotation.*; + +abstract aspect ParentChildRelationship { + + interface ParentHasChildren{} + interface ChildHasParent

{} + + declare parents: Parent implements ParentHasChildren; + declare parents: Child implements ChildHasParent; + + public List ParentHasChildren.children; + public P ChildHasParent

.parent; + + public List ParentHasChildren.getChildren() { + return Collections.unmodifiableList(children); + } + + public P ChildHasParent

.getParent() { + return parent; + } + + public void ChildHasParent

.setParent(P parent) { + this.parent = parent; + //parent.addChild(this); + } + +} + +aspect GenericAspectS extends ParentChildRelationship { + + public static void main(String []argv) { + + // Check the state of top + Top t = new Top(); + check(t instanceof ParentHasChildren,"Top should implement ParentHasChildren"); + Type[] intfs = Top.class.getGenericInterfaces(); + check(intfs[0] instanceof ParameterizedType, + "Expected Top to have parameterized interface but found "+intfs[0]); + ParameterizedType pt = (ParameterizedType) intfs[0]; + Type[] tArgs = pt.getActualTypeArguments(); + check(tArgs[0]==Bottom.class, + "Expecting Bottom parameter but found " + tArgs[0]); + + + // Check the state of top + Bottom b = new Bottom(); + check(b instanceof ChildHasParent,"Bottom should implement ChildHasParent"); + intfs = Bottom.class.getGenericInterfaces(); + check(intfs[0] instanceof ParameterizedType, + "Expected Bottom to have parameterized interface but found "+intfs[0]); + pt = (ParameterizedType) intfs[0]; + tArgs = pt.getActualTypeArguments(); + check(tArgs[0]==Top.class, + "Expecting Top parameter but found " + tArgs[0]); + + + + + // Field fiddling + b.parent = t; + List kids = new ArrayList(); + kids.add(b); + t.children = kids; + + + // start using the methods + List kids2 = t.getChildren(); + check(kids2.size()==1, + "Expected one child of the Top but found "+kids2.size()); + check(kids2.get(0).equals(b), + "Expected one child of the Top which was what we put in there!"+kids2.get(0)); + + // and the parent methods + Top retrievedParent = b.getParent(); + check(retrievedParent==t, + "parent check 1 failed "+ + "retrieved="+retrievedParent+" expected="+t); + + Top top2 = new Top(); + b.setParent(top2); + Top retrievedParent2 = b.getParent(); + check(retrievedParent2==top2, + "parent check 2 failed "+ + "retrieved="+retrievedParent2+" expected="+top2); + + + } + + public static void check(boolean b,String msg) { + if (!b) throw new RuntimeException(msg); + } +} + +class Top {} +class Bottom {} + +////////////////////////////////////////////////////////////////// + +/* End game for test Z, as bits work they are promoted up into the + testcase above :) + + TestN promoted the declare parents statements up + TestO promoted the fields up - a parent knows its children, a + child knows its parents - but then used them incorrectly + TestP uses the fields correctly + TestQ ... tests some stumbling blocks I encountered... + TestR promoted getChildren() method + TestS promoted getParent() and setParent() + +public abstract aspect ParentChildRelationship { + + + + public void ParentHasChildren.addChild(C child) { + if (child.parent != null) { + child.parent.removeChild(child); + } + children.add(child); + child.parent = this; + } + + public void ParentHasChildren.removeChild(C child) { + if (children.remove(child)) { + child.parent = null; + } + } + + + @SuppressAjWarnings + public pointcut addingChild(Parent p, Child c) : + execution(* Parent.addChild(Child)) && this(p) && args(c); + + @SuppressAjWarnings + public pointcut removingChild(Parent p, Child c) : + execution(* Parent.removeChild(Child)) && this(p) && args(c); +} +*/ + diff --git a/tests/java5/generics/genericaspects/GenericAspectT.aj b/tests/java5/generics/genericaspects/GenericAspectT.aj new file mode 100644 index 000000000..a34e4c0b4 --- /dev/null +++ b/tests/java5/generics/genericaspects/GenericAspectT.aj @@ -0,0 +1,15 @@ +import java.util.*; +import java.lang.reflect.*; +import org.aspectj.lang.annotation.*; + +aspect ParentChildRelationship { + + interface I

{} + + public String I.parent; + + public void I.do(T a) { + a.parent=null; + } + +} diff --git a/tests/java5/generics/genericaspects/GenericAspectU.aj b/tests/java5/generics/genericaspects/GenericAspectU.aj new file mode 100644 index 000000000..8ed1f100e --- /dev/null +++ b/tests/java5/generics/genericaspects/GenericAspectU.aj @@ -0,0 +1,148 @@ +import java.util.*; +import java.lang.reflect.*; +import org.aspectj.lang.annotation.*; + +abstract aspect ParentChildRelationship { + + interface ParentHasChildren{} + interface ChildHasParent

{} + + declare parents: Parent implements ParentHasChildren; + declare parents: Child implements ChildHasParent; + + public List ParentHasChildren.children; + public P ChildHasParent

.parent; + + public List ParentHasChildren.getChildren() { + return Collections.unmodifiableList(children); + } + + public P ChildHasParent

.getParent() { + return parent; + } + + public void ChildHasParent.setParent(R parent) { +// parent.addChild(this); + } + + public void ParentHasChildren.addChild(X child) { + //if (child.parent != null) { + //child.parent.removeChild(child); + // } + children.add(child); + } + +/* + public void ParentHasChildren.removeChild(Y child) { + if (children.remove(child)) { + child.parent = null; + } + } +*/ + +} + +aspect GenericAspectT extends ParentChildRelationship { + + public static void main(String []argv) { + + // Check the state of top + Top t = new Top(); + check(t instanceof ParentHasChildren,"Top should implement ParentHasChildren"); + Type[] intfs = Top.class.getGenericInterfaces(); + check(intfs[0] instanceof ParameterizedType, + "Expected Top to have parameterized interface but found "+intfs[0]); + ParameterizedType pt = (ParameterizedType) intfs[0]; + Type[] tArgs = pt.getActualTypeArguments(); + check(tArgs[0]==Bottom.class, + "Expecting Bottom parameter but found " + tArgs[0]); + + + // Check the state of top + Bottom b = new Bottom(); + check(b instanceof ChildHasParent,"Bottom should implement ChildHasParent"); + intfs = Bottom.class.getGenericInterfaces(); + check(intfs[0] instanceof ParameterizedType, + "Expected Bottom to have parameterized interface but found "+intfs[0]); + pt = (ParameterizedType) intfs[0]; + tArgs = pt.getActualTypeArguments(); + check(tArgs[0]==Top.class, + "Expecting Top parameter but found " + tArgs[0]); + + + + + // Field fiddling + b.parent = t; + List kids = new ArrayList(); + kids.add(b); + t.children = kids; + + + // start using the methods + List kids2 = t.getChildren(); + check(kids2.size()==1, + "Expected one child of the Top but found "+kids2.size()); + check(kids2.get(0).equals(b), + "Expected one child of the Top which was what we put in there!"+kids2.get(0)); + + // and the parent methods + Top retrievedParent = b.getParent(); + check(retrievedParent==t, + "parent check 1 failed "+ + "retrieved="+retrievedParent+" expected="+t); + +/* + Top top2 = new Top(); + b.setParent(top2); + Top retrievedParent2 = b.getParent(); + check(retrievedParent2==top2, + "parent check 2 failed "+ + "retrieved="+retrievedParent2+" expected="+top2); + + Bottom bot2 = new Bottom(); + top2.addChild(bot2); + //Bottom aBottom = top2.getChildren().get(0); + //check(aBottom==bot2,"Incorrect child? expected="+bot2+" found="+aBottom); + //top2.removeChild(bot2); + //int size=top2.getChildren().size(); + //check(size==0,"Should be no children but there were "+size); +*/ + + } + + public static void check(boolean b,String msg) { + if (!b) throw new RuntimeException(msg); + } +} + +class Top {} +class Bottom {} + +////////////////////////////////////////////////////////////////// + +/* End game for test Z, as bits work they are promoted up into the + testcase above :) + + TestN promoted the declare parents statements up + TestO promoted the fields up - a parent knows its children, a + child knows its parents - but then used them incorrectly + TestP uses the fields correctly + TestQ ... tests some stumbling blocks I encountered before R... + TestR promoted getChildren() method + TestS promoted getParent() and setParent() + TestT ... tests some stumbling blocks I encountered before U... + TestU promoted addChild and removeChild + +public abstract aspect ParentChildRelationship { + + @SuppressAjWarnings + public pointcut addingChild(Parent p, Child c) : + execution(* Parent.addChild(Child)) && this(p) && args(c); + + @SuppressAjWarnings + public pointcut removingChild(Parent p, Child c) : + execution(* Parent.removeChild(Child)) && this(p) && args(c); +} +*/ + -- 2.39.5