From 935c8ab06a6dd7921b0d48067339aa9603b5a848 Mon Sep 17 00:00:00 2001 From: PJ Fanning Date: Tue, 15 Mar 2022 09:40:48 +0000 Subject: [PATCH] add xssf test (width/height) git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1898944 13f79535-47bb-0310-9956-ffa450edef68 --- .../apache/poi/xssf/usermodel/XSSFSheet.java | 2 +- .../poi/xssf/usermodel/TestXSSFSheet.java | 30 +++++++++++++++++- test-data/spreadsheet/WidthsAndHeights.xlsx | Bin 0 -> 8597 bytes 3 files changed, 30 insertions(+), 2 deletions(-) create mode 100644 test-data/spreadsheet/WidthsAndHeights.xlsx diff --git a/poi-ooxml/src/main/java/org/apache/poi/xssf/usermodel/XSSFSheet.java b/poi-ooxml/src/main/java/org/apache/poi/xssf/usermodel/XSSFSheet.java index 8f13959b3b..513d9ad7ba 100644 --- a/poi-ooxml/src/main/java/org/apache/poi/xssf/usermodel/XSSFSheet.java +++ b/poi-ooxml/src/main/java/org/apache/poi/xssf/usermodel/XSSFSheet.java @@ -868,7 +868,7 @@ public class XSSFSheet extends POIXMLDocumentPart implements Sheet, OoxmlSheetEx * Get the actual column width (in units of 1/256th of a character width ) * *

- * Note, the returned value is always gerater that {@link #getDefaultColumnWidth()} because the latter does not include margins. + * Note, the returned value is always greater that {@link #getDefaultColumnWidth()} because the latter does not include margins. * Actual column width measured as the number of characters of the maximum digit width of the * numbers 0, 1, 2, ..., 9 as rendered in the normal style's font. There are 4 pixels of margin * padding (two on each side), plus 1 pixel padding for the gridlines. diff --git a/poi-ooxml/src/test/java/org/apache/poi/xssf/usermodel/TestXSSFSheet.java b/poi-ooxml/src/test/java/org/apache/poi/xssf/usermodel/TestXSSFSheet.java index 4dc4d622ef..385d0af869 100644 --- a/poi-ooxml/src/test/java/org/apache/poi/xssf/usermodel/TestXSSFSheet.java +++ b/poi-ooxml/src/test/java/org/apache/poi/xssf/usermodel/TestXSSFSheet.java @@ -18,6 +18,7 @@ package org.apache.poi.xssf.usermodel; import static java.util.concurrent.TimeUnit.SECONDS; +import static org.apache.poi.xssf.XSSFTestDataSamples.openSamplePackage; import static org.apache.poi.xssf.XSSFTestDataSamples.openSampleWorkbook; import static org.apache.poi.xssf.XSSFTestDataSamples.writeOutAndReadBack; import static org.junit.jupiter.api.Assertions.assertEquals; @@ -2190,7 +2191,7 @@ public final class TestXSSFSheet extends BaseTestXSheet { } @Test - public void bug65120() throws IOException { + void bug65120() throws IOException { try (XSSFWorkbook wb = new XSSFWorkbook()) { XSSFCreationHelper creationHelper = wb.getCreationHelper(); @@ -2222,4 +2223,31 @@ public final class TestXSSFSheet extends BaseTestXSheet { } } + @Test + void testCustomWidthAndHeight() throws IOException { + try (XSSFWorkbook wb = (XSSFWorkbook) _testDataProvider.openSampleWorkbook("WidthsAndHeights.xlsx")) { + XSSFSheet sheet = wb.getSheetAt(0); + assertEquals(5120, sheet.getColumnWidth(0)); + assertEquals(2048, sheet.getColumnWidth(1)); + assertEquals(0, sheet.getColumnWidth(2)); + assertEquals(140.034, sheet.getColumnWidthInPixels(0), 0.00001); + assertEquals(56.0136, sheet.getColumnWidthInPixels(1), 0.00001); + assertEquals(0.0, sheet.getColumnWidthInPixels(2), 0.00001); + assertFalse(sheet.isColumnHidden(0)); + assertFalse(sheet.isColumnHidden(1)); + assertTrue(sheet.isColumnHidden(2)); + XSSFRow row0 = sheet.getRow(0); + assertEquals(750, row0.getHeight()); + assertEquals(37.5, row0.getHeightInPoints(), 0.00001); + assertFalse(row0.getZeroHeight()); + XSSFRow row1 = sheet.getRow(1); + assertEquals(300, row1.getHeight()); + assertEquals(15.0, row1.getHeightInPoints(), 0.00001); + assertFalse(row1.getZeroHeight()); + XSSFRow row2 = sheet.getRow(2); + assertEquals(15, row2.getHeight()); + assertEquals(0.75, row2.getHeightInPoints(), 0.00001); + assertTrue(row2.getZeroHeight()); + } + } } diff --git a/test-data/spreadsheet/WidthsAndHeights.xlsx b/test-data/spreadsheet/WidthsAndHeights.xlsx new file mode 100644 index 0000000000000000000000000000000000000000..880dfdce026d18f2ad95775747173c659a6c517b GIT binary patch literal 8597 zcmeHsg;$i@_x@1QEsb>N01}dtN;gu{-7-TXDV@?SQX<_jq;yGxwB*nsASv-3z4!jS zSMTpH_}nvVowH`W@3Y?%&yKUViaY}1eZV~c3IG701}KQb;~K&N0I`Sw06qW(UQg1| z0c`F7Hq`KNG6y~9aJRRk%0Yx@$_Bv0-v6)t5AQ%pf}&C<5GUyT=>qjJA-#hR)vGjc z`v@M3Dwffztm#xG`$$bqz2#~h%G>dPxhVGDtn=39N@3D+!E|=&oTIY)ohDS=PPNlL zLvlxaF9#f@gYz=9J_#{(ld41(4@QiE9{_mDT(!fKm=>B^4rcog{BturF;$}|vQ^RLXV=2T9G}u?-=DqNFgnykBM9KFrC~^vf9Kn< zt``!(IzeKm_<^+t$GKdx?WC!_?jR^POh%GV^>vnJFR`;ZG$iK4?QpZ(__atvtF;2= z+;l`VJ`+$%g;Wo)WA}O^N4;mi;rtSGM0e#!Zu;sDf6sZR_~e5GPXC8zYRC^DNQ`&f zUll)P-)*%h3P}fYD|Yhqes<$QrIgEj6za%t*E4||H-jsgSBoTkPA{L+o1sS_-ln$h zw!8;es&ymhZeg5agi-454gsL@5526_1k!$mJyC$E9Xd=e4V}&HK%5-k`~URue^?3s zw)B!XMdeN)M)2X&>yWQqOEf)4Nks#;eyP<;G87$qGY8D*LCW2>MZq%oClL@OAJeK zL*ZNb{v}$Oi6f~>oDq&^q^S7$iaMW7F3RAhB-HmygDdL!vv=Z0(tW3s z3brxDLLVvYji(ayflMrC%e?#Ss826RHPx*iSyz~3ISbNw7@FCAIFU+k!@u!nSIX#9 zqj`vT!9DV%mp=Q{SGVTj(O{-W7e8ueao?BzfC$RM&oCGDyOOAW9m=VNDM<1?000}d zGwybrZjR2jCXSA_-yK(;roCf25a(9Z`mX)hEnLwLHzAKjc9f=8v({q2cK|6~8!0l< zy0GZ>JX7{*l6hJV7Cm39P?pz0kSTbU@R299h_H&>)KeU|YEGlBTGn&1$z2B@X)`pC z0Iga#z3#E~espp;z(gSBBa*XH0oo+M}50TVoANI@@;}2EAX&N<0?pA6PQIL_Z;8a}P)jQ`VJ6 zXlpK3b!f2kGFjGUy^}ZrN4B-AI$Ve^o8+aj*hpdN_U6)kI5S%sc0RG=ktR+9$l$_4Xu$cX=bO{jX*KblLb_-=7LQ+`uN73Oi?HMecF~G{%iHq= zY@sK}rJtk|y*1Nzv~7X-Wye*+)un|W6xadeZjxnRC?35~iAYHE+q)hbQxz6*%cf_@tUbW3+7z?}ti((GyOVx#oeFwZkk^Z0ySB4cTM zuKh`#6Tvaq<8Y|g^_&-L6#@UWowYC=5786f?obHHap+_S0mWp$lp^2>5;`o+KoRh{4v|$*F%f-{@$r2*h&9R8A8GpyzfR) z4+#JuhQ0BpQ3P3;n}b1|KL)Pv*6|1UN0$-59RtS$EPY&OO3*nt~tji#!dVLQh|7W*R*^e6>h!Y~AE7!ZbVD*1gNq-m0MZ!UoIs zZp(y&Aj@eW+}(=I)9@2E&j8^`rH>EGOc1{*-sO&v6%MXSZXR9Y<^V*I+q>gEe3SpkA$6Gp_SHF>`#8ui_1raG?Pz#>0DkqdX%);^8fj{^pPmi^#t4S1OHdUz}i~T%3 zyVx3$lDxS8Ru>$;)pAlDP^?9YZ3JWa4n@ymTV+g;t zH9xzRyh&tEWSLixH1pl8{Z93EBAiwwWB{Ot>igyO2i3t==Jw{CKl&dm-_se2AmhK^ zMsy{H0dl+MU5larygXtTzes16nLu7!x2LMb!yVU5h7V8w=v0jHz(?aPDV|SK&^zLi3|m!>MKU61 zQs^d^^%*Kb`LXA&e!XGv+@epYYEIq zrln^^mGo~b*E*{tLW8!{4jxd?9UEtH2~n(ijh{2&;rUoy(%)9)XfO)COX6#W2#(D zy={7Ss5waZdDQTEHRM52Owe?;hHphMB}U`2Gv#5S&NT$U*%iZbh`-Xa*)AIWU zD)nD&RitE{8-h84YHi#ga|C7`ThaKRF#^R~;+RKNV=;^O)YKKUY51YKkq6wO06%y& zI@#6!ZVcs7l&XdZrbo+N^Yjxac#gq%3`Pwa%$RbT7v-Yzp%>DAQ_reX~5Zf=M^8@Ank z**W6ho@6}g=xV#Z987MzI}$vtSY06CY<+oryd6)p^zw95Ip)FKJo$r^FVta`U&>ZY z4;dni{jt6s!HH#d0VTTP9^-Dg79I@t!5ipN?R2dHHD47wmsmGD*>Eu@?<|-Rhx~fFyFuo#|tYE zXdhQ^tCWmHFs`Xhb~g$|$1>TI@WA`I z6RVG7b+3`(XOaC@L=tZs5~{QMvmqQ++W=wXU=%bAqQ!tvf?Iv5%wk=;gM{>%bUti^ z`!ZTB`0?ve-6LUDjMr`h6mD>!dq^>QN8b_z)0xaSrTnW=&nek#J*~19J~+jdfIfL> zf()iE?!FaSOc;okn-ANjp6K?Ro}G%@q&9o|4=@}aZ)GVrS3-HH6AlKEx|<~2ULrP+ zMIr+W=T#dSAvSQsG#6>SDQpV~wCrmy7{nO4=VC@NbS2FfKV*a}oNBo9Fl3wNg}AU1 zycsS1rgY*S6E&e^2`OnzdykG3cj?ZoA0?SASFoika`?G)a@S`|!%Zjo9@Fduv9W>$ znW_u1sv(xdeFMu^2D7Q!V_@wum7V0bx-u`IXh3@c0(a=yvUCeHM0`#>*n&J^)0E&{ zO=@#w8QO5FjAuO0`&2j;6HXqg7_jvf7(LKnLsyKf@q!!hz4d)8-uIHJ01X^&Yc z(_i3#h5FpN+i9(X7l~D~lqmgI)XSW1i@KK{l+ewRceGGO#k3#@Zt~;iX=`(`B1eb$ zMFcwU3~~9VR}j30Ub?Ls4OmS#hmSu>h^7^cP;t#kG0W=U4J-RNrp!u7tUR06{&tr` zIHd^TtVMZ|pK@vdbkBOjvY?w~XA&I09U`=jS$r%xS;dm?aHGWTTxQDw!NQyJkZWF< zd>Mhz4rG7xky}xxS*bI;x>|L5QLHcXqpr(iwq3c*i>rZ! z<|zwgH-BMICtrbgYFjE2j>)u4SL0-T34BHo3-LNpC`-+c7}@W9nC*}kJ$;?@-hxe{v)-c;!CxUgU^8@*Q5$C}u^g3~u1m3Fl*@15p2Sc9?;1>r_SC>VYu zs$IESZPlOkesPFPmHDl9AX~@Y)h5WIR)h($MJac5?~`DVL8;y$rsrbC7`gD57FtZK zxhV&gU4FD$=XyO98+vn}T%AJXL^+|tda|4B8!A>)BPjDrvsS>lO;g?7zh1uy;bP8O zV3B4q?D~!Qhx-MAJ?zXue_X!j9p-@;FDWa0alRf5xUR9G+7T(LBOuioKjtwi4`*lW z0CUmNgZTEAp3Ew(=5%uG%S(+I7ERAaVI<82q zPlj;;UB&|Ran3gJ@OqRR>NkR(;+xF)e>+M0AM911CdU!o^5`tM ztTOP;x{8G(o#?ugc0*T?03*&f#1FCWMwxpfSssfAHjDD%7__UL0yCEko9lxqas^19 zQ$7D6ylAD~juZ3#yg-q}|e z-a{cET1$8<$y|xf{7?ep_$LIiK3|PIMtZ?`X`e>!>#;*PI7iE;#P(wy&qrw+ri(1(-S4>z9Um5Qn&lJxPZWc;)N80>Y1(86(+I z^29!15;d?RpbSuqF5RMyFqqOi@DqF5fE{WQm&HGv=*ucUXY8^-VZ zFfF+MC(o^noz2bE!OqqWmOtnYj!~3Hc?K*o_%rwfv|gsDFhKmE!s` zl|XfiBcijgagmf(J&)Y%8Q-dsf&7rTS4qU{QneI%JZpm?C{RD09FJBZzf!PS!Ybo4 zX;j;+p6ur$%E38qNlE}V6s0#0w}(NOyE#uM7xJz~s#d0jcWFS@>pE3`Q+?a;>KWfn z;vGzhe_!_FsKUEY*pdkm003NA?!nB_RK?lR3B+mY=xqLHVd%e<1B?%mYVF@mT?_V% z7;&Rel_}UZstc(u=N%#OCdtYgZS^yZ zF@YvRXbujEuG8GizV7vB{mo69h`bW5(&`36ugKLZSc(y;^&ZieXHFCdB#|USv)X}% z5tcND@+2!HLIgx56$+w|QDzh3x^Y%_RlS74oC^jax_koWN5mUGuJ_~fgJ;JNC4@+= zVrNW3l5*IH@`bHXC5goBh*N3JEv*hc-dQi0I%0-pOgWBy>}WkCddVBzev*8=a<<{1 z&&%)Hhox}cMAE8f8E3!Sh!?*xeM5d*UdgsxOu|8hiuJTJMJEl@rH6Tvx!P@`^~$3bLO4{V z&2f@5Fj%elLX}AK<=M?h#ii_BtQ-q?Lg9^TNl~M)n6o#(Rga{`D?Oru8zY&uDBV?B z2(5Gzv$zvwLNq7j5_SdroxYUm&m#_DrxOmNFwWoUYwYCoAA4aN^JmM5{aHp}I_D*M zik~*FuqLn1AP~8jJGoDzD%Az(;gHwYZM^0wQ3yrUaoB?fdC13rVwS$`Z<+ZnS z$Ip3oHp9+fR_qUwz`?V_%=o_-!2jBmzs7$lhpWi{Q@}qfb$JRY$Cr$jToL{qrKP8Q$|G!E6mOK1a%CCu-pHf<| z{xvQ0tAJla$)5s*34aLq8Cd=b{nb1Fgwm1x0sYli|0?01j_xNO03ag;0Dg0Ozrz1% gX#NhLBmW!xPqU*Uj|4ki000g4^ZV|1DZc;vKR#IB2><{9 literal 0 HcmV?d00001 -- 2.39.5