From 9a7b16406681a4bea454525a17bd884e0764ed1f Mon Sep 17 00:00:00 2001 From: Simon Brandhof Date: Wed, 28 Sep 2016 17:03:53 +0200 Subject: [PATCH] Fix Quality flaws --- .../org/sonar/server/qualityprofile/QProfileBackuper.java | 2 +- .../server/qualityprofile/QProfileProjectOperations.java | 6 +++--- 2 files changed, 4 insertions(+), 4 deletions(-) diff --git a/server/sonar-server/src/main/java/org/sonar/server/qualityprofile/QProfileBackuper.java b/server/sonar-server/src/main/java/org/sonar/server/qualityprofile/QProfileBackuper.java index 6a3566435aa..73c45998976 100644 --- a/server/sonar-server/src/main/java/org/sonar/server/qualityprofile/QProfileBackuper.java +++ b/server/sonar-server/src/main/java/org/sonar/server/qualityprofile/QProfileBackuper.java @@ -201,7 +201,7 @@ public class QProfileBackuper { } } - private SMInputFactory initStax() { + private static SMInputFactory initStax() { XMLInputFactory xmlFactory = XMLInputFactory.newInstance(); xmlFactory.setProperty(XMLInputFactory.IS_COALESCING, Boolean.TRUE); xmlFactory.setProperty(XMLInputFactory.IS_NAMESPACE_AWARE, Boolean.FALSE); diff --git a/server/sonar-server/src/main/java/org/sonar/server/qualityprofile/QProfileProjectOperations.java b/server/sonar-server/src/main/java/org/sonar/server/qualityprofile/QProfileProjectOperations.java index 40ec8d6f8d4..ae809fd6cbc 100644 --- a/server/sonar-server/src/main/java/org/sonar/server/qualityprofile/QProfileProjectOperations.java +++ b/server/sonar-server/src/main/java/org/sonar/server/qualityprofile/QProfileProjectOperations.java @@ -55,7 +55,7 @@ public class QProfileProjectOperations { } } - void addProject(String profileKey, String projectUuid, UserSession userSession, DbSession session) { + private void addProject(String profileKey, String projectUuid, UserSession userSession, DbSession session) { ComponentDto project = db.componentDao().selectOrFailByUuid(session, projectUuid); checkPermission(userSession, project.key()); QualityProfileDto qualityProfile = findNotNull(profileKey, session); @@ -89,7 +89,7 @@ public class QProfileProjectOperations { } } - public void removeProject(String language, long projectId, UserSession userSession) { + void removeProject(String language, long projectId, UserSession userSession) { DbSession session = db.openSession(false); try { ComponentDto project = db.componentDao().selectOrFailById(session, projectId); @@ -105,7 +105,7 @@ public class QProfileProjectOperations { } } - public void removeAllProjects(String profileKey, UserSession userSession) { + void removeAllProjects(String profileKey, UserSession userSession) { checkPermission(userSession); DbSession session = db.openSession(false); try { -- 2.39.5