From 9bd44301d36103a951cd9026682b93b7ff0bdd2f Mon Sep 17 00:00:00 2001 From: =?utf8?q?J=C3=B6rn=20Zaefferer?= Date: Tue, 4 Dec 2012 01:17:00 +0100 Subject: [PATCH] Dialog: Refactor _createOverlay and _destroyOverlay to use widget methods and properties. --- ui/jquery.ui.dialog.js | 16 +++++++++------- 1 file changed, 9 insertions(+), 7 deletions(-) diff --git a/ui/jquery.ui.dialog.js b/ui/jquery.ui.dialog.js index 77392cb19..472d686a2 100644 --- a/ui/jquery.ui.dialog.js +++ b/ui/jquery.ui.dialog.js @@ -665,17 +665,19 @@ $.widget("ui.dialog", { // prevent use of anchors and inputs // we use a setTimeout in case the overlay is created from an // event that we're going to be cancelling (see #2804) - setTimeout(function() { + this._delay(function() { // handle $(el).dialog().dialog('close') (see #4065) if ( $.ui.dialog.overlayInstances ) { - $( document ).bind( "focusin.dialog-overlay", function( event ) { - if ( !$( event.target ).closest( ".ui-dialog").length ) { - event.preventDefault(); - $( ".ui-dialog:visible:last .ui-dialog-content" ).data( "ui-dialog" )._focusTabbable(); + this._on( this.document, { + focusin: function( event ) { + if ( !$( event.target ).closest( ".ui-dialog").length ) { + event.preventDefault(); + $( ".ui-dialog:visible:last .ui-dialog-content" ).data( "ui-dialog" )._focusTabbable(); + } } }); } - }, 1 ); + }); } var $el = this.overlay = $( "
" ).addClass( "ui-widget-overlay ui-front" ); @@ -692,7 +694,7 @@ $.widget("ui.dialog", { } $.ui.dialog.overlayInstances -= 1; if ( $.ui.dialog.overlayInstances === 0 ) { - $( [ document, window ] ).unbind( ".dialog-overlay" ); + this._off( this.document, "focusin" ); } this.overlay.remove(); } -- 2.39.5