From 9fbe68ab36db626fc2a11dd5a606c53bd3dbd70e Mon Sep 17 00:00:00 2001 From: Jonas Date: Tue, 14 Nov 2023 16:07:49 +0100 Subject: [PATCH] fix(Background): Show comment about limit at end and conditionally * Only print the comment when job list is truncated * Show the comment at the end so users actually see it * Format the comment as comment Signed-off-by: Jonas --- core/Command/Background/ListCommand.php | 9 +++++---- 1 file changed, 5 insertions(+), 4 deletions(-) diff --git a/core/Command/Background/ListCommand.php b/core/Command/Background/ListCommand.php index 44ae72c2c9b..a2588112524 100644 --- a/core/Command/Background/ListCommand.php +++ b/core/Command/Background/ListCommand.php @@ -66,11 +66,12 @@ class ListCommand extends Base { } protected function execute(InputInterface $input, OutputInterface $output): int { - $jobs = $this->jobList->getJobsIterator($input->getOption('class'), (int)$input->getOption('limit'), (int)$input->getOption('offset')); - if ($input->getOption('output') === self::OUTPUT_FORMAT_PLAIN) { - $output->writeln("Output is currently limited to first " . $input->getOption('limit') . " jobs. Specify `-l, --limit[=LIMIT]` to override."); + $limit = (int)$input->getOption('limit'); + $jobsInfo = $this->formatJobs($this->jobList->getJobsIterator($input->getOption('class'), $limit, (int)$input->getOption('offset'))); + $this->writeTableInOutputFormat($input, $output, $jobsInfo); + if ($input->getOption('output') === self::OUTPUT_FORMAT_PLAIN && count($jobsInfo) >= $limit) { + $output->writeln("\nOutput is currently limited to first " . $limit . " jobs. Specify `-l, --limit[=LIMIT]` to override."); } - $this->writeTableInOutputFormat($input, $output, $this->formatJobs($jobs)); return 0; } -- 2.39.5