From a20494228d51c57c454ff9f10a4ba8bbdda0e49c Mon Sep 17 00:00:00 2001 From: Dave Methvin Date: Wed, 22 Jan 2014 14:50:36 -0800 Subject: [PATCH] Manipulation: Use textarea for missing IE defaultValue check IE11 fixed the checkbox defaultValue issue but not textarea. Rather than creating a new detect name I'm reusing the old one to protect anyone who is unwisely using this externally. Re-fixing the defaultValue when it doesn't need to be done is not a problem, so leave that code for IE11. Fixes #14716 Closes gh-1495 --- src/manipulation/support.js | 13 +++++-------- test/unit/support.js | 2 +- 2 files changed, 6 insertions(+), 9 deletions(-) diff --git a/src/manipulation/support.js b/src/manipulation/support.js index 9463a01f1..e2ba066ec 100644 --- a/src/manipulation/support.js +++ b/src/manipulation/support.js @@ -3,8 +3,7 @@ define([ ], function( support ) { (function() { - var input, - fragment = document.createDocumentFragment(), + var fragment = document.createDocumentFragment(), div = fragment.appendChild( document.createElement( "div" ) ); // #11217 - WebKit loses check when the name is after the checked attribute @@ -14,12 +13,10 @@ define([ // old WebKit doesn't clone checked state correctly in fragments support.checkClone = div.cloneNode( true ).cloneNode( true ).lastChild.checked; - // Make sure checked status is properly cloned - // Support: IE9, IE10 - input = document.createElement("input"); - input.type = "checkbox"; - input.checked = true; - support.noCloneChecked = input.cloneNode( true ).checked; + // Make sure textarea (and checkbox) defaultValue is properly cloned + // Support: IE9-IE11+ + div.innerHTML = ""; + support.noCloneChecked = !!div.cloneNode( true ).lastChild.defaultValue; })(); return support; diff --git a/test/unit/support.js b/test/unit/support.js index efd4f820b..10defc5e9 100644 --- a/test/unit/support.js +++ b/test/unit/support.js @@ -92,7 +92,7 @@ testIframeWithCallback( "Check CSP (https://developer.mozilla.org/en-US/docs/Sec "clearCloneStyle": false, "cors": true, "focusinBubbles": true, - "noCloneChecked": true, + "noCloneChecked": false, "optDisabled": true, "optSelected": false, "pixelPosition": true, -- 2.39.5