From a22b43bad41592ec61e5fa0fcd2b3a3d44f8bfd3 Mon Sep 17 00:00:00 2001 From: Ed Sanders Date: Tue, 21 Apr 2020 12:43:52 +0100 Subject: [PATCH] Build: Append .eslintignore paths to grunt eslint paths This allows us to turn off the `quiet` option which was suppressing warnings. We can also set `maxWarnings` to 0 now that aren't any. Closes gh-4689 --- Gruntfile.js | 20 +++++++++++++++----- 1 file changed, 15 insertions(+), 5 deletions(-) diff --git a/Gruntfile.js b/Gruntfile.js index 43507c24b..5021c59e9 100644 --- a/Gruntfile.js +++ b/Gruntfile.js @@ -15,7 +15,8 @@ module.exports = function( grunt ) { var fs = require( "fs" ), gzip = require( "gzip-js" ), isTravis = process.env.TRAVIS, - travisBrowsers = process.env.BROWSERS && process.env.BROWSERS.split( "," ); + travisBrowsers = process.env.BROWSERS && process.env.BROWSERS.split( "," ), + CLIEngine = require( "eslint" ).CLIEngine; if ( !grunt.option( "filename" ) ) { grunt.option( "filename", "jquery.js" ); @@ -77,9 +78,7 @@ module.exports = function( grunt ) { }, eslint: { options: { - - // See https://github.com/sindresorhus/grunt-eslint/issues/119 - quiet: true + maxWarnings: 0 }, // We have to explicitly declare "src" property otherwise "newer" @@ -88,7 +87,18 @@ module.exports = function( grunt ) { src: [ "dist/jquery.js", "dist/jquery.min.js" ] }, dev: { - src: [ "src/**/*.js", "Gruntfile.js", "test/**/*.js", "build/**/*.js" ] + src: [ + "src/**/*.js", + "Gruntfile.js", + "test/**/*.js", + "build/**/*.js", + + // Ignore files from .eslintignore + // See https://github.com/sindresorhus/grunt-eslint/issues/119 + ...new CLIEngine() + .getConfigForFile( "Gruntfile.js" ) + .ignorePatterns.map( ( p ) => `!${ p }` ) + ] } }, testswarm: { -- 2.39.5