From a2749f6e52fbb1b46263383f0f4cf39ce5d4c418 Mon Sep 17 00:00:00 2001 From: =?utf8?q?Gr=C3=A9goire=20Aubert?= Date: Wed, 10 Jan 2018 12:38:09 +0100 Subject: [PATCH] Remove unused router from overview Meta component --- .../main/js/apps/overview/events/AnalysesList.js | 3 +-- .../src/main/js/apps/overview/meta/Meta.js | 16 +++++++++------- 2 files changed, 10 insertions(+), 9 deletions(-) diff --git a/server/sonar-web/src/main/js/apps/overview/events/AnalysesList.js b/server/sonar-web/src/main/js/apps/overview/events/AnalysesList.js index 47f75499e05..bff7894acb7 100644 --- a/server/sonar-web/src/main/js/apps/overview/events/AnalysesList.js +++ b/server/sonar-web/src/main/js/apps/overview/events/AnalysesList.js @@ -33,8 +33,7 @@ type Props = { branch?: string, component: Object, history: ?History, - qualifier: string, - router: { push: ({ pathname: string, query?: {} }) => void } + qualifier: string }; */ diff --git a/server/sonar-web/src/main/js/apps/overview/meta/Meta.js b/server/sonar-web/src/main/js/apps/overview/meta/Meta.js index 5cce8904100..9b0f6afe149 100644 --- a/server/sonar-web/src/main/js/apps/overview/meta/Meta.js +++ b/server/sonar-web/src/main/js/apps/overview/meta/Meta.js @@ -18,7 +18,6 @@ * Inc., 51 Franklin Street, Fifth Floor, Boston, MA 02110-1301, USA. */ import React from 'react'; -import { withRouter } from 'react-router'; import { connect } from 'react-redux'; import MetaKey from './MetaKey'; import MetaOrganizationKey from './MetaOrganizationKey'; @@ -37,7 +36,7 @@ const Meta = ({ measures, areThereCustomOrganizations, onComponentChange, - router + onSonarCloud }) => { const { qualifier, description, qualityProfiles, qualityGate } = component; @@ -66,7 +65,6 @@ const Meta = ({ component={component} qualifier={component.qualifier} history={history} - router={router} /> {shouldShowQualityGate && ( @@ -93,8 +91,12 @@ const Meta = ({ ); }; -const mapStateToProps = state => ({ - areThereCustomOrganizations: areThereCustomOrganizations(state) -}); +const mapStateToProps = state => { + const sonarCloudSetting = getGlobalSettingValue(state, 'sonar.sonarcloud.enabled'); + return { + areThereCustomOrganizations: areThereCustomOrganizations(state), + onSonarCloud: Boolean(sonarCloudSetting && sonarCloudSetting.value === 'true') + }; +}; -export default connect(mapStateToProps)(withRouter(Meta)); +export default connect(mapStateToProps)(Meta); -- 2.39.5