From a4433927ad687e7048d058b7d2577214eea523fc Mon Sep 17 00:00:00 2001 From: Stas Vilchik Date: Tue, 23 Dec 2014 14:35:01 +0100 Subject: [PATCH] SONAR-5967 Remove the limitation of 3000 lines --- .../src/main/coffee/component-viewer/source.coffee | 13 ++++--------- .../src/main/hbs/component-viewer/cw-source.hbs | 4 ---- .../main/resources/org/sonar/l10n/core.properties | 1 - 3 files changed, 4 insertions(+), 14 deletions(-) diff --git a/server/sonar-web/src/main/coffee/component-viewer/source.coffee b/server/sonar-web/src/main/coffee/component-viewer/source.coffee index 42ae5c05719..079566287a6 100644 --- a/server/sonar-web/src/main/coffee/component-viewer/source.coffee +++ b/server/sonar-web/src/main/coffee/component-viewer/source.coffee @@ -24,7 +24,6 @@ define [ $ = jQuery API_COVERAGE_TESTS = "#{baseUrl}/api/tests/test_cases" - LINES_LIMIT = 3000 ISSUES_LIMIT = 100 @@ -104,7 +103,6 @@ define [ $(expand).insertBefore rows.first() lines = _.size @model.get 'source' - lines = Math.min lines, LINES_LIMIT lastShown = rows.last().data('line-number') if lastShown < lines expand = @expandTemplate @@ -311,17 +309,16 @@ define [ source.forEach (sourceLine) => show = false line = sourceLine.lineNumber - if line <= LINES_LIMIT - @showBlocks.forEach (block) -> - show = true if block.from <= line && block.to >= line - _.extend sourceLine, show: show + @showBlocks.forEach (block) -> + show = true if block.from <= line && block.to >= line + _.extend sourceLine, show: show source prepareSource: -> source = @model.get 'formattedSource' if source? - _.first @augmentWithShow(source), LINES_LIMIT + @augmentWithShow(source) getStatColumnsCount: -> @@ -359,6 +356,4 @@ define [ showZeroLine: @showZeroLine() issuesLimit: ISSUES_LIMIT issuesLimitReached: @model.get('activeIssues')?.length > ISSUES_LIMIT - linesLimit: LINES_LIMIT - linesLimitReached: _.size(@model.get 'source') > LINES_LIMIT baseDuplications: @getBaseDuplications() diff --git a/server/sonar-web/src/main/hbs/component-viewer/cw-source.hbs b/server/sonar-web/src/main/hbs/component-viewer/cw-source.hbs index dbb80fcf7cf..7fb13a6bee8 100644 --- a/server/sonar-web/src/main/hbs/component-viewer/cw-source.hbs +++ b/server/sonar-web/src/main/hbs/component-viewer/cw-source.hbs @@ -4,10 +4,6 @@ {{else}} - {{#if linesLimitReached}} -

{{tp 'component_viewer.lines_limit_reached' linesLimit}}

- {{/if}} - {{#if issuesLimitReached}}

{{tp 'component_viewer.issues_limit_reached' issuesLimit}}

{{/if}} diff --git a/sonar-core/src/main/resources/org/sonar/l10n/core.properties b/sonar-core/src/main/resources/org/sonar/l10n/core.properties index 0b6a9905610..ade5dec40c9 100644 --- a/sonar-core/src/main/resources/org/sonar/l10n/core.properties +++ b/sonar-core/src/main/resources/org/sonar/l10n/core.properties @@ -2755,7 +2755,6 @@ component_viewer.more_actions=More Actions component_viewer.new_window=Open in New Window component_viewer.get_permalink=Get Permalink component_viewer.covered_lines=Covered Lines -component_viewer.lines_limit_reached=For performance reasons, only the {0} first lines will be displayed. component_viewer.issues_limit_reached=For usability reasons, only the {0} first issues will be fully displayed. Remaining issues will simply be underlined. component_viewer.issues_limit_reached_tooltip={0}\n\nRefine your filter to be able to see the details of this issue. component_viewer.cannot_show=We're sorry, but something went wrong. Please try back in a few minutes and contact support if the problem persists. -- 2.39.5