From a4cfa9554548c53a3d0aa267495427729deb9352 Mon Sep 17 00:00:00 2001
From: Arthur Schiwon <blizzz@owncloud.com>
Date: Tue, 25 Feb 2014 15:22:20 +0100
Subject: [PATCH] restructure group.js and put functions to object, also add
 group list sorting after adding.

---
 settings/js/users/groups.js                 | 91 +++++++++++++++------
 settings/templates/users/part.grouplist.php |  2 +-
 2 files changed, 68 insertions(+), 25 deletions(-)

diff --git a/settings/js/users/groups.js b/settings/js/users/groups.js
index f8f6d3fedcc..7c8b6608f11 100644
--- a/settings/js/users/groups.js
+++ b/settings/js/users/groups.js
@@ -5,6 +5,61 @@
  */
 
  var GroupList = {
+	addGroup: function(gid) {
+		var li = $('li[data-gid]').last().clone();
+		var ul = $('li[data-gid]').first().parent();
+		li.attr('data-gid', gid);
+		li.attr('data-usercount', 0);
+		li.find('a span').first().text(gid);
+		li.find('span[class=usercount]').first().text('');
+
+		$(li).appendTo(ul);
+
+		GroupList.sortGroups(0);
+	},
+
+	sortGroups: function(usercount) {
+		var lis = $('li[data-gid]').filterAttr('data-usercount', usercount.toString()).get();
+		var ul = $(lis).first().parent();
+
+		lis.sort(function(a, b) {
+			return UserList.alphanum($(a).find('a span').text(), $(b).find('a span').text());
+		});
+
+		var items = [];
+		$.each(lis, function(index, li) {
+			items.push(li);
+			if(items.length === 100) {
+				$(ul).append(items);
+				items = [];
+			}
+		});
+		if(items.length > 0) {
+			$(ul).append(items);
+		}
+	},
+
+	createGroup: function(groupname) {
+		$.post(
+			OC.filePath('settings', 'ajax', 'creategroup.php'),
+			{
+				groupname : groupname
+			},
+			function (result) {
+				if (result.status !== 'success') {
+					OC.dialogs.alert(result.data.message,
+						t('settings', 'Error creating group'));
+				} else {
+					if (result.data.groupname) {
+						var addedGroups = result.data.groupname;
+						UserList.availableGroups = $.unique($.merge(UserList.availableGroups, addedGroups));
+						GroupList.addGroup(result.data.groupname);
+					}
+					GroupList.toggleAddGroup();
+				}
+			}
+		)
+	},
 
 	delete_group: function (gid) {
 		if(GroupList.deleteGid !=='undefined') {
@@ -42,6 +97,16 @@
 		}
 	},
 
+	isGroupNameValid: function(groupname) {
+		if ($.trim(groupname) === '') {
+			OC.dialogs.alert(
+				t('settings', 'A valid groupname must be provided'),
+				t('settings', 'Error creating group'));
+			return false;
+		}
+		return true;
+	},
+
 	finishDelete: function (ready) {
 		if (!GroupList.deleteCanceled && GroupList.deleteGid) {
 			$.ajax({
@@ -87,31 +152,9 @@ $(document).ready( function () {
 	// Responsible for Creating Groups.
 	$('#newgroup-form form').submit(function (event) {
 		event.preventDefault();
-		var groupname = $('#newgroupname').val();
-		if ($.trim(groupname) === '') {
-			OC.dialogs.alert(
-				t('settings', 'A valid groupname must be provided'),
-				t('settings', 'Error creating group'));
-			return false;
+		if(GroupList.isGroupNameValid($('#newgroupname').val())) {
+			GroupList.createGroup($('#newgroupname').val());
 		}
-		$.post(
-			OC.filePath('settings', 'ajax', 'creategroup.php'),
-			{
-				groupname : groupname
-			},
-			function (result) {
-				if (result.status !== 'success') {
-					OC.dialogs.alert(result.data.message,
-						t('settings', 'Error creating group'));
-				} else {
-					if (result.data.groupname) {
-						var addedGroups = result.data.groupname;
-						UserList.availableGroups = $.unique($.merge(UserList.availableGroups, addedGroups));
-					}
-					GroupList.toggleAddGroup();
-				}
-			}
-		)
 	});
 
 	// click on group name
diff --git a/settings/templates/users/part.grouplist.php b/settings/templates/users/part.grouplist.php
index 6acf12a952f..4b1958c1a67 100644
--- a/settings/templates/users/part.grouplist.php
+++ b/settings/templates/users/part.grouplist.php
@@ -32,7 +32,7 @@
 
 	<!--List of Groups-->
 	<?php foreach($_["groups"] as $group): ?>
-		<li data-gid="<?php p($group['name']) ?>">
+		<li data-gid="<?php p($group['name']) ?>" data-usercount="<?php p(count($group['useringroup'])) ?>">
 			<a href="#">
 				<span><?php p($group['name']); ?></span>
 				<img class="svg action rename" src="<?php p(image_path('core', 'actions/rename.svg'))?>"
-- 
2.39.5