From a514d3cd1692c97ff29c5aa48366d957cfdbb9b8 Mon Sep 17 00:00:00 2001 From: Mathieu Suen Date: Wed, 1 Feb 2023 16:37:22 +0100 Subject: [PATCH] SONAR-18381 Improve landmark and heading level --- .../app/components/ProjectAdminContainer.tsx | 4 ++-- .../ProjectAdminContainer-test.tsx.snap | 4 ++-- .../src/main/js/apps/account/Account.tsx | 4 +++- .../components/AuditAppRenderer.tsx | 8 +++---- .../components/BackgroundTasksApp.tsx | 4 ++-- .../BackgroundTasksApp-test.tsx.snap | 4 ++-- .../main/js/apps/code/components/CodeApp.tsx | 4 ++-- .../js/apps/coding-rules/components/App.tsx | 4 ++-- .../__tests__/__snapshots__/App-test.tsx.snap | 8 +++---- .../component-measures/components/App.tsx | 4 ++-- .../components/MeasureOverview.tsx | 4 ++-- .../__tests__/__snapshots__/App-test.tsx.snap | 4 ++-- .../MeasureOverview-test.tsx.snap | 16 ++++++------- .../main/js/apps/groups/components/App.tsx | 4 ++-- .../__tests__/__snapshots__/App-test.tsx.snap | 8 +++---- .../src/main/js/apps/marketplace/App.tsx | 6 ++--- .../src/main/js/apps/marketplace/Header.tsx | 2 +- .../__tests__/__snapshots__/App-test.tsx.snap | 24 +++++++++---------- .../__snapshots__/Header-test.tsx.snap | 8 +++---- .../main/js/apps/overview/components/App.tsx | 8 +++---- .../components/__tests__/App-test.tsx | 5 ++++ .../components/PermissionTemplatesApp.tsx | 4 ++-- .../permissions/global/components/App.tsx | 4 ++-- .../__tests__/__snapshots__/App-test.tsx.snap | 8 +++---- .../components/ProjectActivityAppRenderer.tsx | 4 ++-- .../ProjectManagementApp.tsx | 4 ++-- .../js/apps/quality-gates/components/App.tsx | 4 ++-- .../apps/quality-gates/components/Details.tsx | 4 ++-- .../components/ProfileContainer.tsx | 4 +++- .../details/ProfileHeader.tsx | 4 ++-- .../quality-profiles/home/HomeContainer.tsx | 8 +++---- .../SecurityHotspotsAppRenderer.tsx | 4 ++-- .../components/SettingsAppRenderer.tsx | 4 ++-- .../SettingsAppRenderer-test.tsx.snap | 24 +++++++++---------- .../main/js/apps/system/components/App.tsx | 4 ++-- .../__tests__/__snapshots__/App-test.tsx.snap | 12 +++++----- .../src/main/js/apps/users/UsersApp.tsx | 4 ++-- .../__snapshots__/UsersApp-test.tsx.snap | 8 +++---- 38 files changed, 127 insertions(+), 118 deletions(-) diff --git a/server/sonar-web/src/main/js/app/components/ProjectAdminContainer.tsx b/server/sonar-web/src/main/js/app/components/ProjectAdminContainer.tsx index e25fe8c69b0..5d1ded1dc5b 100644 --- a/server/sonar-web/src/main/js/app/components/ProjectAdminContainer.tsx +++ b/server/sonar-web/src/main/js/app/components/ProjectAdminContainer.tsx @@ -54,10 +54,10 @@ export class ProjectAdminContainer extends React.PureComponent { } return ( - <> +
- +
); } } diff --git a/server/sonar-web/src/main/js/app/components/__tests__/__snapshots__/ProjectAdminContainer-test.tsx.snap b/server/sonar-web/src/main/js/app/components/__tests__/__snapshots__/ProjectAdminContainer-test.tsx.snap index c3f74fb0aa7..0d01829fb3b 100644 --- a/server/sonar-web/src/main/js/app/components/__tests__/__snapshots__/ProjectAdminContainer-test.tsx.snap +++ b/server/sonar-web/src/main/js/app/components/__tests__/__snapshots__/ProjectAdminContainer-test.tsx.snap @@ -1,10 +1,10 @@ // Jest Snapshot v1, https://goo.gl/fbAQLP exports[`should render correctly 1`] = ` - +
- +
`; diff --git a/server/sonar-web/src/main/js/apps/account/Account.tsx b/server/sonar-web/src/main/js/apps/account/Account.tsx index 56528dc90c0..89c44b98f9a 100644 --- a/server/sonar-web/src/main/js/apps/account/Account.tsx +++ b/server/sonar-web/src/main/js/apps/account/Account.tsx @@ -61,7 +61,9 @@ export class Account extends React.PureComponent { - +
+ +
); } diff --git a/server/sonar-web/src/main/js/apps/audit-logs/components/AuditAppRenderer.tsx b/server/sonar-web/src/main/js/apps/audit-logs/components/AuditAppRenderer.tsx index fd5cbcd1a66..c9a3479dce9 100644 --- a/server/sonar-web/src/main/js/apps/audit-logs/components/AuditAppRenderer.tsx +++ b/server/sonar-web/src/main/js/apps/audit-logs/components/AuditAppRenderer.tsx @@ -72,12 +72,12 @@ export default function AuditAppRenderer(props: AuditAppRendererProps) { const { dateRange, downloadStarted, housekeepingPolicy, selection } = props; return ( -
+
-

{translate('audit_logs.page')}

+

{translate('audit_logs.page')}

@@ -104,7 +104,7 @@ export default function AuditAppRenderer(props: AuditAppRendererProps) {

-

{translate('audit_logs.download')}

+

{translate('audit_logs.download')}

    {getRangeOptions(housekeepingPolicy).map((option) => ( @@ -134,6 +134,6 @@ export default function AuditAppRenderer(props: AuditAppRendererProps) { onStartDownload={props.handleStartDownload} selection={selection} /> -
+
); } diff --git a/server/sonar-web/src/main/js/apps/background-tasks/components/BackgroundTasksApp.tsx b/server/sonar-web/src/main/js/apps/background-tasks/components/BackgroundTasksApp.tsx index aadcc2704a8..430a327776f 100644 --- a/server/sonar-web/src/main/js/apps/background-tasks/components/BackgroundTasksApp.tsx +++ b/server/sonar-web/src/main/js/apps/background-tasks/components/BackgroundTasksApp.tsx @@ -229,7 +229,7 @@ export class BackgroundTasksApp extends React.PureComponent { const query = this.props.location.query.query || ''; return ( -
+
@@ -272,7 +272,7 @@ export class BackgroundTasksApp extends React.PureComponent { pageSize={pagination.pageSize} total={pagination.total} /> -
+ ); } } diff --git a/server/sonar-web/src/main/js/apps/background-tasks/components/__tests__/__snapshots__/BackgroundTasksApp-test.tsx.snap b/server/sonar-web/src/main/js/apps/background-tasks/components/__tests__/__snapshots__/BackgroundTasksApp-test.tsx.snap index afb200f89f2..d6a88662327 100644 --- a/server/sonar-web/src/main/js/apps/background-tasks/components/__tests__/__snapshots__/BackgroundTasksApp-test.tsx.snap +++ b/server/sonar-web/src/main/js/apps/background-tasks/components/__tests__/__snapshots__/BackgroundTasksApp-test.tsx.snap @@ -11,7 +11,7 @@ exports[`should render correctly: initial 1`] = ` `; exports[`should render correctly: loaded 1`] = ` -
-
+ `; diff --git a/server/sonar-web/src/main/js/apps/code/components/CodeApp.tsx b/server/sonar-web/src/main/js/apps/code/components/CodeApp.tsx index 646599998aa..5bd09e3c39d 100644 --- a/server/sonar-web/src/main/js/apps/code/components/CodeApp.tsx +++ b/server/sonar-web/src/main/js/apps/code/components/CodeApp.tsx @@ -292,7 +292,7 @@ class CodeApp extends React.Component { const isPortfolio = isPortfolioLike(qualifier); return ( -
+
{!canBrowseAllChildProjects && isPortfolio && ( @@ -394,7 +394,7 @@ class CodeApp extends React.Component {
)}
- + ); } } diff --git a/server/sonar-web/src/main/js/apps/coding-rules/components/App.tsx b/server/sonar-web/src/main/js/apps/coding-rules/components/App.tsx index 95f89618efb..66e7210d3b2 100644 --- a/server/sonar-web/src/main/js/apps/coding-rules/components/App.tsx +++ b/server/sonar-web/src/main/js/apps/coding-rules/components/App.tsx @@ -602,7 +602,7 @@ export class App extends React.PureComponent { )} -
+
@@ -673,7 +673,7 @@ export class App extends React.PureComponent { )}
-
+
); diff --git a/server/sonar-web/src/main/js/apps/coding-rules/components/__tests__/__snapshots__/App-test.tsx.snap b/server/sonar-web/src/main/js/apps/coding-rules/components/__tests__/__snapshots__/App-test.tsx.snap index 59f49c690c4..58ab4ac91cd 100644 --- a/server/sonar-web/src/main/js/apps/coding-rules/components/__tests__/__snapshots__/App-test.tsx.snap +++ b/server/sonar-web/src/main/js/apps/coding-rules/components/__tests__/__snapshots__/App-test.tsx.snap @@ -205,7 +205,7 @@ exports[`should render correctly: loaded 1`] = ` > -
-
+
`; @@ -360,7 +360,7 @@ exports[`should render correctly: loading 1`] = ` > -
-
+ `; diff --git a/server/sonar-web/src/main/js/apps/component-measures/components/App.tsx b/server/sonar-web/src/main/js/apps/component-measures/components/App.tsx index 22252b9d61f..922fa2d0906 100644 --- a/server/sonar-web/src/main/js/apps/component-measures/components/App.tsx +++ b/server/sonar-web/src/main/js/apps/component-measures/components/App.tsx @@ -265,11 +265,11 @@ export class App extends React.PureComponent { if (hideDrilldown) { return ( -
+
{translate('component_measures.details_are_not_available')}
-
+ ); } diff --git a/server/sonar-web/src/main/js/apps/component-measures/components/MeasureOverview.tsx b/server/sonar-web/src/main/js/apps/component-measures/components/MeasureOverview.tsx index ff194a1834c..501ec9fac2e 100644 --- a/server/sonar-web/src/main/js/apps/component-measures/components/MeasureOverview.tsx +++ b/server/sonar-web/src/main/js/apps/component-measures/components/MeasureOverview.tsx @@ -154,7 +154,7 @@ export default class MeasureOverview extends React.PureComponent { const { branchLike, className, component, leakPeriod, loading, rootComponent } = this.props; const displayLeak = hasFullMeasures(branchLike); return ( -
+
@@ -190,7 +190,7 @@ export default class MeasureOverview extends React.PureComponent { {!loading && this.renderContent()}
-
+ ); } } diff --git a/server/sonar-web/src/main/js/apps/component-measures/components/__tests__/__snapshots__/App-test.tsx.snap b/server/sonar-web/src/main/js/apps/component-measures/components/__tests__/__snapshots__/App-test.tsx.snap index 17e692d4ad3..523e596b871 100644 --- a/server/sonar-web/src/main/js/apps/component-measures/components/__tests__/__snapshots__/App-test.tsx.snap +++ b/server/sonar-web/src/main/js/apps/component-measures/components/__tests__/__snapshots__/App-test.tsx.snap @@ -21,7 +21,7 @@ exports[`should not render drilldown for estimated duplications 1`] = ` > -
-
+ `; diff --git a/server/sonar-web/src/main/js/apps/component-measures/components/__tests__/__snapshots__/MeasureOverview-test.tsx.snap b/server/sonar-web/src/main/js/apps/component-measures/components/__tests__/__snapshots__/MeasureOverview-test.tsx.snap index 002e5241a15..56095ad8c01 100644 --- a/server/sonar-web/src/main/js/apps/component-measures/components/__tests__/__snapshots__/MeasureOverview-test.tsx.snap +++ b/server/sonar-web/src/main/js/apps/component-measures/components/__tests__/__snapshots__/MeasureOverview-test.tsx.snap @@ -1,7 +1,7 @@ // Jest Snapshot v1, https://goo.gl/fbAQLP exports[`should render correctly: default 1`] = ` -
+
@@ -104,11 +104,11 @@ exports[`should render correctly: default 1`] = ` updateSelected={[MockFunction]} />
-
+ `; exports[`should render correctly: has leak period 1`] = ` -
+
@@ -252,11 +252,11 @@ exports[`should render correctly: has leak period 1`] = ` updateSelected={[MockFunction]} />
-
+ `; exports[`should render correctly: is file 1`] = ` -
+
@@ -337,11 +337,11 @@ exports[`should render correctly: is file 1`] = ` />
- + `; exports[`should render correctly: loading 1`] = ` -
+
@@ -410,5 +410,5 @@ exports[`should render correctly: loading 1`] = ` loading={true} />
-
+ `; diff --git a/server/sonar-web/src/main/js/apps/groups/components/App.tsx b/server/sonar-web/src/main/js/apps/groups/components/App.tsx index e26520e4aa3..e282044653b 100644 --- a/server/sonar-web/src/main/js/apps/groups/components/App.tsx +++ b/server/sonar-web/src/main/js/apps/groups/components/App.tsx @@ -196,7 +196,7 @@ export default class App extends React.PureComponent<{}, State> { <> -
+
{ onSubmit={this.handleEdit} /> )} -
+ ); } diff --git a/server/sonar-web/src/main/js/apps/groups/components/__tests__/__snapshots__/App-test.tsx.snap b/server/sonar-web/src/main/js/apps/groups/components/__tests__/__snapshots__/App-test.tsx.snap index 7a517e97573..a06d0810832 100644 --- a/server/sonar-web/src/main/js/apps/groups/components/__tests__/__snapshots__/App-test.tsx.snap +++ b/server/sonar-web/src/main/js/apps/groups/components/__tests__/__snapshots__/App-test.tsx.snap @@ -11,7 +11,7 @@ exports[`should render correctly 1`] = ` prioritizeSeoTags={false} title="user_groups.page" /> -
@@ -26,7 +26,7 @@ exports[`should render correctly 1`] = ` placeholder="search.search_by_name" value="" /> -
+ `; @@ -41,7 +41,7 @@ exports[`should render correctly 2`] = ` prioritizeSeoTags={false} title="user_groups.page" /> -
@@ -89,6 +89,6 @@ exports[`should render correctly 2`] = ` total={5} />
- + `; diff --git a/server/sonar-web/src/main/js/apps/marketplace/App.tsx b/server/sonar-web/src/main/js/apps/marketplace/App.tsx index b47eff46860..52dd3a65eeb 100644 --- a/server/sonar-web/src/main/js/apps/marketplace/App.tsx +++ b/server/sonar-web/src/main/js/apps/marketplace/App.tsx @@ -156,13 +156,13 @@ export class App extends React.PureComponent { riskConsent === RiskConsent.Accepted; return ( -
+
-

{translate('marketplace.page.plugins')}

+

{translate('marketplace.page.plugins')}

{translate('marketplace.page.plugins.description')}

{currentEdition !== EditionKey.community && ( @@ -209,7 +209,7 @@ export class App extends React.PureComponent { )} -
+
); } } diff --git a/server/sonar-web/src/main/js/apps/marketplace/Header.tsx b/server/sonar-web/src/main/js/apps/marketplace/Header.tsx index 209ea4f41fc..88312102589 100644 --- a/server/sonar-web/src/main/js/apps/marketplace/Header.tsx +++ b/server/sonar-web/src/main/js/apps/marketplace/Header.tsx @@ -28,7 +28,7 @@ interface Props { export default function Header({ currentEdition }: Props) { return (
-

{translate('marketplace.page')}

+

{translate('marketplace.page')}

{currentEdition && (

{translate('marketplace.page.you_are_running', currentEdition)} diff --git a/server/sonar-web/src/main/js/apps/marketplace/__tests__/__snapshots__/App-test.tsx.snap b/server/sonar-web/src/main/js/apps/marketplace/__tests__/__snapshots__/App-test.tsx.snap index a17030467b4..423ae4b0dd4 100644 --- a/server/sonar-web/src/main/js/apps/marketplace/__tests__/__snapshots__/App-test.tsx.snap +++ b/server/sonar-web/src/main/js/apps/marketplace/__tests__/__snapshots__/App-test.tsx.snap @@ -1,7 +1,7 @@ // Jest Snapshot v1, https://goo.gl/fbAQLP exports[`should render correctly: loaded 1`] = ` -
@@ -23,11 +23,11 @@ exports[`should render correctly: loaded 1`] = `
-

marketplace.page.plugins -

+

@@ -94,11 +94,11 @@ exports[`should render correctly: loaded 1`] = ` total={1} /> -
+ `; exports[`should render correctly: loading 1`] = ` -
@@ -120,11 +120,11 @@ exports[`should render correctly: loading 1`] = `
-

marketplace.page.plugins -

+
@@ -170,11 +170,11 @@ exports[`should render correctly: loading 1`] = ` > marketplace.plugin_list.no_plugins.all -
+ `; exports[`should render correctly: not readonly 1`] = ` -
@@ -196,11 +196,11 @@ exports[`should render correctly: not readonly 1`] = `
-

marketplace.page.plugins -

+
@@ -250,5 +250,5 @@ exports[`should render correctly: not readonly 1`] = ` total={1} /> -
+ `; diff --git a/server/sonar-web/src/main/js/apps/marketplace/__tests__/__snapshots__/Header-test.tsx.snap b/server/sonar-web/src/main/js/apps/marketplace/__tests__/__snapshots__/Header-test.tsx.snap index 4b6c283ca46..83e8c3b7b33 100644 --- a/server/sonar-web/src/main/js/apps/marketplace/__tests__/__snapshots__/Header-test.tsx.snap +++ b/server/sonar-web/src/main/js/apps/marketplace/__tests__/__snapshots__/Header-test.tsx.snap @@ -5,11 +5,11 @@ exports[`should render with installed editions 1`] = ` className="page-header" id="marketplace-header" > -

marketplace.page -

+

@@ -28,11 +28,11 @@ exports[`should render with installed editions 2`] = ` className="page-header" id="marketplace-header" > -

marketplace.page -

+

diff --git a/server/sonar-web/src/main/js/apps/overview/components/App.tsx b/server/sonar-web/src/main/js/apps/overview/components/App.tsx index 942a3ace000..8c6efe0b26c 100644 --- a/server/sonar-web/src/main/js/apps/overview/components/App.tsx +++ b/server/sonar-web/src/main/js/apps/overview/components/App.tsx @@ -56,12 +56,12 @@ export class App extends React.PureComponent { } return isPullRequest(branchLike) ? ( - <> +
- +
) : ( - <> +
{!component.analysisDate && ( @@ -82,7 +82,7 @@ export class App extends React.PureComponent { projectBinding={projectBinding} /> )} - +
); } } diff --git a/server/sonar-web/src/main/js/apps/overview/components/__tests__/App-test.tsx b/server/sonar-web/src/main/js/apps/overview/components/__tests__/App-test.tsx index b5126094321..e72a1a7e7a4 100644 --- a/server/sonar-web/src/main/js/apps/overview/components/__tests__/App-test.tsx +++ b/server/sonar-web/src/main/js/apps/overview/components/__tests__/App-test.tsx @@ -19,7 +19,9 @@ */ import { shallow } from 'enzyme'; import * as React from 'react'; +import { mockPullRequest } from '../../../../helpers/mocks/branch-like'; import BranchOverview from '../../branches/BranchOverview'; +import PullRequestOverview from '../../pullRequests/PullRequestOverview'; import { App } from '../App'; const component = { @@ -33,6 +35,9 @@ const component = { it('should render BranchOverview', () => { expect(getWrapper().find(BranchOverview).exists()).toBe(true); + expect(getWrapper({ branchLike: mockPullRequest() }).find(PullRequestOverview).exists()).toBe( + true + ); }); function getWrapper(props = {}) { diff --git a/server/sonar-web/src/main/js/apps/permission-templates/components/PermissionTemplatesApp.tsx b/server/sonar-web/src/main/js/apps/permission-templates/components/PermissionTemplatesApp.tsx index a6691e30792..0a613050b6f 100644 --- a/server/sonar-web/src/main/js/apps/permission-templates/components/PermissionTemplatesApp.tsx +++ b/server/sonar-web/src/main/js/apps/permission-templates/components/PermissionTemplatesApp.tsx @@ -110,13 +110,13 @@ export class PermissionTemplatesApp extends React.PureComponent { render() { const { id } = this.props.location.query; return ( -
+
{id && this.renderTemplate(id)} {!id && this.renderHome()} -
+ ); } } diff --git a/server/sonar-web/src/main/js/apps/permissions/global/components/App.tsx b/server/sonar-web/src/main/js/apps/permissions/global/components/App.tsx index 55df242511c..5e0c9a0c8a6 100644 --- a/server/sonar-web/src/main/js/apps/permissions/global/components/App.tsx +++ b/server/sonar-web/src/main/js/apps/permissions/global/components/App.tsx @@ -281,7 +281,7 @@ export class App extends React.PureComponent { 'global_permissions' ); return ( -
+
@@ -302,7 +302,7 @@ export class App extends React.PureComponent { users={users} usersPaging={usersPaging} /> -
+ ); } } diff --git a/server/sonar-web/src/main/js/apps/permissions/global/components/__tests__/__snapshots__/App-test.tsx.snap b/server/sonar-web/src/main/js/apps/permissions/global/components/__tests__/__snapshots__/App-test.tsx.snap index 5017c675591..55679b704a0 100644 --- a/server/sonar-web/src/main/js/apps/permissions/global/components/__tests__/__snapshots__/App-test.tsx.snap +++ b/server/sonar-web/src/main/js/apps/permissions/global/components/__tests__/__snapshots__/App-test.tsx.snap @@ -1,7 +1,7 @@ // Jest Snapshot v1, https://goo.gl/fbAQLP exports[`should render correctly 1`] = ` -
-
+ `; exports[`should render correctly 2`] = ` -
-
+ `; diff --git a/server/sonar-web/src/main/js/apps/projectActivity/components/ProjectActivityAppRenderer.tsx b/server/sonar-web/src/main/js/apps/projectActivity/components/ProjectActivityAppRenderer.tsx index becf6e59200..4bb0d646efe 100644 --- a/server/sonar-web/src/main/js/apps/projectActivity/components/ProjectActivityAppRenderer.tsx +++ b/server/sonar-web/src/main/js/apps/projectActivity/components/ProjectActivityAppRenderer.tsx @@ -56,7 +56,7 @@ export default function ProjectActivityAppRenderer(props: Props) { (configuration ? configuration.showHistory : false); const canDeleteAnalyses = configuration ? configuration.showHistory : false; return ( -
+
@@ -106,6 +106,6 @@ export default function ProjectActivityAppRenderer(props: Props) { />

-
+ ); } diff --git a/server/sonar-web/src/main/js/apps/projectsManagement/ProjectManagementApp.tsx b/server/sonar-web/src/main/js/apps/projectsManagement/ProjectManagementApp.tsx index 24b8e7f9ced..2688eeede81 100644 --- a/server/sonar-web/src/main/js/apps/projectsManagement/ProjectManagementApp.tsx +++ b/server/sonar-web/src/main/js/apps/projectsManagement/ProjectManagementApp.tsx @@ -204,7 +204,7 @@ export class ProjectManagementApp extends React.PureComponent { const { currentUser } = this.props; const { defaultProjectVisibility } = this.state; return ( -
+
@@ -258,7 +258,7 @@ export class ProjectManagementApp extends React.PureComponent { onProjectCreated={this.requestProjects} /> )} -
+ ); } } diff --git a/server/sonar-web/src/main/js/apps/quality-gates/components/App.tsx b/server/sonar-web/src/main/js/apps/quality-gates/components/App.tsx index 623d21ad35b..87cb5a6097c 100644 --- a/server/sonar-web/src/main/js/apps/quality-gates/components/App.tsx +++ b/server/sonar-web/src/main/js/apps/quality-gates/components/App.tsx @@ -123,7 +123,7 @@ class App extends React.PureComponent { {({ top }) => ( -
+
+ )}
diff --git a/server/sonar-web/src/main/js/apps/quality-gates/components/Details.tsx b/server/sonar-web/src/main/js/apps/quality-gates/components/Details.tsx index 1409940c95c..97f18dc80f0 100644 --- a/server/sonar-web/src/main/js/apps/quality-gates/components/Details.tsx +++ b/server/sonar-web/src/main/js/apps/quality-gates/components/Details.tsx @@ -150,7 +150,7 @@ export default class Details extends React.PureComponent { const { loading, qualityGate, updatedConditionId } = this.state; return ( -
+
{qualityGate && ( <> @@ -172,7 +172,7 @@ export default class Details extends React.PureComponent { )} -
+ ); } } diff --git a/server/sonar-web/src/main/js/apps/quality-profiles/components/ProfileContainer.tsx b/server/sonar-web/src/main/js/apps/quality-profiles/components/ProfileContainer.tsx index ddc968d65a0..5588a4d15b9 100644 --- a/server/sonar-web/src/main/js/apps/quality-profiles/components/ProfileContainer.tsx +++ b/server/sonar-web/src/main/js/apps/quality-profiles/components/ProfileContainer.tsx @@ -64,7 +64,9 @@ export default function ProfileContainer() { isComparable={filteredProfiles.length > 1} updateProfiles={context.updateProfiles} /> - +
+ +
); } diff --git a/server/sonar-web/src/main/js/apps/quality-profiles/details/ProfileHeader.tsx b/server/sonar-web/src/main/js/apps/quality-profiles/details/ProfileHeader.tsx index 2ca6f42e977..c02116e3877 100644 --- a/server/sonar-web/src/main/js/apps/quality-profiles/details/ProfileHeader.tsx +++ b/server/sonar-web/src/main/js/apps/quality-profiles/details/ProfileHeader.tsx @@ -53,7 +53,7 @@ export default function ProfileHeader(props: Props) { const isChangeLogPage = location.pathname.endsWith(`/${QualityProfilePath.CHANGELOG}`); return ( -
+
{(isComparePage || isChangeLogPage) && (
)} - + ); } diff --git a/server/sonar-web/src/main/js/apps/quality-profiles/home/HomeContainer.tsx b/server/sonar-web/src/main/js/apps/quality-profiles/home/HomeContainer.tsx index aef096a04f5..e06487ef75b 100644 --- a/server/sonar-web/src/main/js/apps/quality-profiles/home/HomeContainer.tsx +++ b/server/sonar-web/src/main/js/apps/quality-profiles/home/HomeContainer.tsx @@ -35,12 +35,12 @@ export default function HomeContainer() {
-
+
-
-
+ +
+
); diff --git a/server/sonar-web/src/main/js/apps/security-hotspots/SecurityHotspotsAppRenderer.tsx b/server/sonar-web/src/main/js/apps/security-hotspots/SecurityHotspotsAppRenderer.tsx index ba8b7c1bd9f..1db2708e3ba 100644 --- a/server/sonar-web/src/main/js/apps/security-hotspots/SecurityHotspotsAppRenderer.tsx +++ b/server/sonar-web/src/main/js/apps/security-hotspots/SecurityHotspotsAppRenderer.tsx @@ -174,7 +174,7 @@ export default function SecurityHotspotsAppRenderer(props: SecurityHotspotsAppRe )} -
+
-
+ ))} diff --git a/server/sonar-web/src/main/js/apps/settings/components/SettingsAppRenderer.tsx b/server/sonar-web/src/main/js/apps/settings/components/SettingsAppRenderer.tsx index 3765dd223e9..9d844cc2133 100644 --- a/server/sonar-web/src/main/js/apps/settings/components/SettingsAppRenderer.tsx +++ b/server/sonar-web/src/main/js/apps/settings/components/SettingsAppRenderer.tsx @@ -67,7 +67,7 @@ export function SettingsAppRenderer(props: SettingsAppRendererProps) { (!isProjectSettings && foundAdditionalCategory.availableGlobally)); return ( -
+
@@ -110,7 +110,7 @@ export function SettingsAppRenderer(props: SettingsAppRendererProps) {
- + ); } diff --git a/server/sonar-web/src/main/js/apps/settings/components/__tests__/__snapshots__/SettingsAppRenderer-test.tsx.snap b/server/sonar-web/src/main/js/apps/settings/components/__tests__/__snapshots__/SettingsAppRenderer-test.tsx.snap index 02bc3346760..491942307b9 100644 --- a/server/sonar-web/src/main/js/apps/settings/components/__tests__/__snapshots__/SettingsAppRenderer-test.tsx.snap +++ b/server/sonar-web/src/main/js/apps/settings/components/__tests__/__snapshots__/SettingsAppRenderer-test.tsx.snap @@ -1,7 +1,7 @@ // Jest Snapshot v1, https://goo.gl/fbAQLP exports[`should render almintegration correctly 1`] = ` -
- + `; exports[`should render default view correctly 1`] = ` -
- + `; exports[`should render default view correctly: All Categories List 1`] = ` @@ -195,7 +195,7 @@ exports[`should render default view correctly: All Categories List 1`] = ` `; exports[`should render exclusions correctly 1`] = ` -
- + `; exports[`should render languages correctly 1`] = ` -
- + `; exports[`should render new_code_period correctly 1`] = ` -
- + `; exports[`should render pull_request_decoration_binding correctly 1`] = ` -
- + `; diff --git a/server/sonar-web/src/main/js/apps/system/components/App.tsx b/server/sonar-web/src/main/js/apps/system/components/App.tsx index 53d20e573aa..7478fdfa549 100644 --- a/server/sonar-web/src/main/js/apps/system/components/App.tsx +++ b/server/sonar-web/src/main/js/apps/system/components/App.tsx @@ -123,7 +123,7 @@ export class App extends React.PureComponent { render() { const { loading, sysInfoData } = this.state; return ( -
+
@@ -143,7 +143,7 @@ export class App extends React.PureComponent { /> )} {this.renderSysInfo()} -
+
); } } diff --git a/server/sonar-web/src/main/js/apps/system/components/__tests__/__snapshots__/App-test.tsx.snap b/server/sonar-web/src/main/js/apps/system/components/__tests__/__snapshots__/App-test.tsx.snap index 1f62f012092..aeffef45a27 100644 --- a/server/sonar-web/src/main/js/apps/system/components/__tests__/__snapshots__/App-test.tsx.snap +++ b/server/sonar-web/src/main/js/apps/system/components/__tests__/__snapshots__/App-test.tsx.snap @@ -1,7 +1,7 @@ // Jest Snapshot v1, https://goo.gl/fbAQLP exports[`should render correctly: cluster sysinfo 1`] = ` -
-
+ `; exports[`should render correctly: loading 1`] = ` -
-
+ `; exports[`should render correctly: stand-alone sysinfo 1`] = ` -
-
+ `; diff --git a/server/sonar-web/src/main/js/apps/users/UsersApp.tsx b/server/sonar-web/src/main/js/apps/users/UsersApp.tsx index c2fb58dbcc7..b0d7c36df4f 100644 --- a/server/sonar-web/src/main/js/apps/users/UsersApp.tsx +++ b/server/sonar-web/src/main/js/apps/users/UsersApp.tsx @@ -118,7 +118,7 @@ export class UsersApp extends React.PureComponent { const query = parseQuery(this.props.location.query); const { loading, paging, users } = this.state; return ( -
+
@@ -138,7 +138,7 @@ export class UsersApp extends React.PureComponent { total={paging.total} /> )} -
+ ); } } diff --git a/server/sonar-web/src/main/js/apps/users/__tests__/__snapshots__/UsersApp-test.tsx.snap b/server/sonar-web/src/main/js/apps/users/__tests__/__snapshots__/UsersApp-test.tsx.snap index aee0b17d53a..41245b66512 100644 --- a/server/sonar-web/src/main/js/apps/users/__tests__/__snapshots__/UsersApp-test.tsx.snap +++ b/server/sonar-web/src/main/js/apps/users/__tests__/__snapshots__/UsersApp-test.tsx.snap @@ -1,7 +1,7 @@ // Jest Snapshot v1, https://goo.gl/fbAQLP exports[`should render correctly 1`] = ` -
@@ -39,11 +39,11 @@ exports[`should render correctly 1`] = ` updateTokensCount={[Function]} users={[]} /> -
+ `; exports[`should render correctly 2`] = ` -
@@ -106,5 +106,5 @@ exports[`should render correctly 2`] = ` ready={true} total={2} /> -
+ `; -- 2.39.5