From aa2b9116625c1bcb08da5ba0858c035f847eaa26 Mon Sep 17 00:00:00 2001
From: Fabrice Bellingard <bellingard@gmail.com>
Date: Thu, 26 May 2011 17:53:53 +0200
Subject: [PATCH] SONAR-2388 Make it possible to search for 'false-positive'
 reviews

- Adds select box on the search page
- Change comment icon color if false-positive
- Add "False positive" label on the permalink page
- Adjust link that opens the resource to directly open the resource
  viewer on the false-positives
---
 .../app/controllers/reviews_controller.rb     |   8 ++++--
 .../WEB-INF/app/helpers/application_helper.rb |   6 ++---
 .../WEB-INF/app/helpers/users_helper.rb       |   8 ++++--
 .../views/autocomplete/_text_field.html.erb   |   6 ++++-
 .../app/views/reviews/_review.html.erb        |   7 ++++-
 .../WEB-INF/app/views/reviews/index.html.erb  |  18 +++++++++----
 .../webapp/images/reviews/+false-positive.png | Bin 849 -> 0 bytes
 .../main/webapp/images/reviews/+review.png    | Bin 976 -> 0 bytes
 .../webapp/images/reviews/false_positive.png  | Bin 0 -> 3118 bytes
 .../src/main/webapp/images/reviews/review.png | Bin 947 -> 0 bytes
 .../images/reviews/with_false_positives.png   | Bin 0 -> 3092 bytes
 .../src/main/webapp/stylesheets/style.css     |  24 ++++++++++++++----
 12 files changed, 58 insertions(+), 19 deletions(-)
 delete mode 100644 sonar-server/src/main/webapp/images/reviews/+false-positive.png
 delete mode 100644 sonar-server/src/main/webapp/images/reviews/+review.png
 create mode 100644 sonar-server/src/main/webapp/images/reviews/false_positive.png
 delete mode 100644 sonar-server/src/main/webapp/images/reviews/review.png
 create mode 100644 sonar-server/src/main/webapp/images/reviews/with_false_positives.png

diff --git a/sonar-server/src/main/webapp/WEB-INF/app/controllers/reviews_controller.rb b/sonar-server/src/main/webapp/WEB-INF/app/controllers/reviews_controller.rb
index ddf519dca1e..5062feb382d 100644
--- a/sonar-server/src/main/webapp/WEB-INF/app/controllers/reviews_controller.rb
+++ b/sonar-server/src/main/webapp/WEB-INF/app/controllers/reviews_controller.rb
@@ -272,7 +272,8 @@ class ReviewsController < ApplicationController
     @severities = filter_any(params[:severities]) || ['']
     @statuses = filter_any(params[:statuses]) || [Review::STATUS_OPEN]
     @projects = filter_any(params[:projects]) || ['']
-    @id = params[:review_id] || ""
+    @false_positives = params[:false_positives] || 'without'
+    @id = params[:review_id] || ''
     @sort = params[:sort]
     @asc = params[:asc] == "true"
   end
@@ -285,7 +286,7 @@ class ReviewsController < ApplicationController
   end
 
   def search_reviews
-    options = { 'false_positives' => 'without' }
+    options = {}
     unless @statuses == ['']
       options['statuses']=@statuses.join(',')
     end
@@ -301,6 +302,9 @@ class ReviewsController < ApplicationController
     if @assignee_id
       options['assignees']=@assignee_id.to_s
     end
+    if @false_positives
+      options['false_positives']=@false_positives
+    end
     unless @id  == ''
       if is_number? @id
         options['id'] = @id
diff --git a/sonar-server/src/main/webapp/WEB-INF/app/helpers/application_helper.rb b/sonar-server/src/main/webapp/WEB-INF/app/helpers/application_helper.rb
index ccc33e692ff..2922bcf0c92 100644
--- a/sonar-server/src/main/webapp/WEB-INF/app/helpers/application_helper.rb
+++ b/sonar-server/src/main/webapp/WEB-INF/app/helpers/application_helper.rb
@@ -315,13 +315,13 @@ module ApplicationHelper
     period_index=nil if period_index && period_index<=0
     if resource.display_dashboard?
       if options[:dashboard]
-        link_to(name || resource.name, {:overwrite_params => {:controller => 'dashboard', :action => 'index', :id => (resource.copy_resource_id||resource.id), :period => period_index, :tab => options[:tab]}}, :title => options[:title])
+        link_to(name || resource.name, {:overwrite_params => {:controller => 'dashboard', :action => 'index', :id => (resource.copy_resource_id||resource.id), :period => period_index, :tab => options[:tab], :rule => options[:rule]}}, :title => options[:title])
       else
         # stay on the same page (for example components)
-        link_to(name || resource.name, {:overwrite_params => {:id => (resource.copy_resource_id||resource.id), :period => period_index, :tab => options[:tab]}}, :title => options[:title])
+        link_to(name || resource.name, {:overwrite_params => {:id => (resource.copy_resource_id||resource.id), :period => period_index, :tab => options[:tab], :rule => options[:rule]}}, :title => options[:title])
       end
     else
-      link_to(name || resource.name, {:controller => 'resource', :action => 'index', :id => resource.id, :period => period_index, :tab => options[:tab]}, :popup => ['resource', 'height=800,width=900,scrollbars=1,resizable=1'], :title => options[:title])
+      link_to(name || resource.name, {:controller => 'resource', :action => 'index', :id => resource.id, :period => period_index, :tab => options[:tab], :rule => options[:rule]}, :popup => ['resource', 'height=800,width=900,scrollbars=1,resizable=1'], :title => options[:title])
     end
   end
 
diff --git a/sonar-server/src/main/webapp/WEB-INF/app/helpers/users_helper.rb b/sonar-server/src/main/webapp/WEB-INF/app/helpers/users_helper.rb
index a99f1fd7b30..7999bc9c69d 100644
--- a/sonar-server/src/main/webapp/WEB-INF/app/helpers/users_helper.rb
+++ b/sonar-server/src/main/webapp/WEB-INF/app/helpers/users_helper.rb
@@ -117,11 +117,14 @@ module UsersHelper
   # field that is submitted is a hidden one that contains the user ID that corresponds
   # to the typed name (if the user exists, of course).
   #
+  # The 'options' argument can be used to pass HTML elements to the text field.
+  # (for the moment 'class' is supported).
+  #
   # Example:
   #   <%= user_autocomplete_field "assignee_id", @assignee_id -%>
   #   # => generates an input field for the parameter 'assignee_id'
   #
-  def user_autocomplete_field(param_id, param_value)
+  def user_autocomplete_field(param_id, param_value, options={})
     param_id_name = param_id
     param_id_value = param_value
     
@@ -134,7 +137,8 @@ module UsersHelper
     server_url = url_for :controller => 'users', :action => 'autocomplete'
     
     render :partial => 'autocomplete/text_field', :locals => {:param_id_name => param_id_name, :param_id_value => param_id_value, 
-                                                              :param_displayed_value => param_displayed_value, :server_url => server_url }
+                                                              :param_displayed_value => param_displayed_value, :server_url => server_url,
+                                                              :options => options.to_options}
   end
 
 end
diff --git a/sonar-server/src/main/webapp/WEB-INF/app/views/autocomplete/_text_field.html.erb b/sonar-server/src/main/webapp/WEB-INF/app/views/autocomplete/_text_field.html.erb
index 8675ee22515..2e9b6f047e7 100644
--- a/sonar-server/src/main/webapp/WEB-INF/app/views/autocomplete/_text_field.html.erb
+++ b/sonar-server/src/main/webapp/WEB-INF/app/views/autocomplete/_text_field.html.erb
@@ -1,4 +1,8 @@
-  <input type="text" id="autocompleteText-<%= param_id_name -%>" value="<%= param_displayed_value -%>" onfocus="$('<%= param_id_name -%>').value=''; this.value=''"/>
+  <input type="text" 
+         id="autocompleteText-<%= param_id_name -%>" 
+         value="<%= param_displayed_value -%>" 
+         onfocus="$('<%= param_id_name -%>').value=''; this.value=''"
+         <%= "class=\"" + options[:class] + "\"" if options[:class] -%>/>
   <input type="hidden" id="<%= param_id_name -%>" name="<%= param_id_name -%>" value="<%= param_id_value -%>"/>
   <div id="autocomplete-<%= param_id_name -%>" class="autocomplete"></div>
   <script>
diff --git a/sonar-server/src/main/webapp/WEB-INF/app/views/reviews/_review.html.erb b/sonar-server/src/main/webapp/WEB-INF/app/views/reviews/_review.html.erb
index ef3ea5b72fa..dd702ee4158 100644
--- a/sonar-server/src/main/webapp/WEB-INF/app/views/reviews/_review.html.erb
+++ b/sonar-server/src/main/webapp/WEB-INF/app/views/reviews/_review.html.erb
@@ -1,6 +1,11 @@
 <div id="rev_<%= review.id -%>">
   <div class="reportTitle">
     <h2>Review #<%= h(review.id.to_s) -%> - <%= h(review.title) -%></h2>
+    <% if review.false_positive %>
+      <%= image_tag("sep12.png") -%>
+      &nbsp;
+      <span class="falsePositive">False-Positive</span>
+    <% end %>
     
     <% 
       if current_user && review.status != "CLOSED" && review.rule_failure
@@ -91,7 +96,7 @@
 	   <td class="val" colspan="3">
 		<%= qualifier_icon(@review.resource) -%> 
 		<% if !review.on_project? %> <%= @review.project.long_name -%> <%= image_tag 'sep12.png' -%> <% end %>
-		<%= link_to_resource(review.resource, review.resource.long_name, { :tab => :violations } ) %>
+		<%= link_to_resource(review.resource, review.resource.long_name, { :tab => :violations, :rule => "f-positive" } ) %>
 	   </td>
 	 </tr>
   </table>
diff --git a/sonar-server/src/main/webapp/WEB-INF/app/views/reviews/index.html.erb b/sonar-server/src/main/webapp/WEB-INF/app/views/reviews/index.html.erb
index 0b1d521a583..bb2b91e8aa9 100644
--- a/sonar-server/src/main/webapp/WEB-INF/app/views/reviews/index.html.erb
+++ b/sonar-server/src/main/webapp/WEB-INF/app/views/reviews/index.html.erb
@@ -7,7 +7,8 @@ function reviewIdFieldModified(field) {
     $('author_id').value = ''
     $('autocompleteText-author_id').value = ''
     $('assignee_id').value = ''
-    $('autocompleteText-assignee_id').value = ''    
+    $('autocompleteText-assignee_id').value = ''  
+    $('false_positives').value = 'with'  
   }
 }
 function launchSearch(columnName, link) {
@@ -63,13 +64,19 @@ function launchSearch(columnName, link) {
         </td>
         <td width="1%" nowrap>
           <span class="note">Created by</span><br/>
-          <%= user_autocomplete_field "author_id", @author_id -%>
+          <%= user_autocomplete_field "author_id", @author_id, { :class => "max-width" } -%>
           <br/>
           <span class="note">Assigned to</span><br/>
-          <%= user_autocomplete_field "assignee_id", @assignee_id -%>
+          <%= user_autocomplete_field "assignee_id", @assignee_id, { :class => "max-width" } -%>
           <br/>
+          <br/>
+          <select name="false_positives" id="false_positives" class="withIcons">
+            <option <%= 'selected' if @false_positives=='without' -%> value="without" class="sel-without-false-positives">Without false positives</option>
+            <option <%= 'selected' if @false_positives=='only' -%> value="only" class="sel-only-false-positives">Only false positives</option>
+            <option <%= 'selected' if @false_positives=='with' -%> value="with" class="sel-with-false-positives">With false positives</option>
+          </select>
         </td>
-        <td width="1%" nowrap>
+        <td width="1%" style="padding-left: 20px" nowrap>
           <span class="note">Id</span><br/>
           <%= text_field_tag "review_id", @id, :size => 10, :onkeyup => "reviewIdFieldModified(this)" -%>
           <br/>
@@ -140,7 +147,8 @@ function launchSearch(columnName, link) {
           <td>
             <%= link_to h(review.title), :controller => "reviews", :action => "view", :id => review.id -%>
             <div class="comment-excerpt">
-              <%= image_tag("reviews/comment.png") -%> &nbsp;<b><%= comment.user.name -%> :</b> 
+              <img src="<%= ApplicationController.root_context -%>/images/reviews/<%= review.false_positive ? "false_positive" : "comment" -%>.png" title="<%= 'False positive' if review.false_positive -%>"/>
+              &nbsp;<b><%= comment.user.name -%> :</b> 
               <%= comment.excerpt -%>
 	        </div>            
           </td>
diff --git a/sonar-server/src/main/webapp/images/reviews/+false-positive.png b/sonar-server/src/main/webapp/images/reviews/+false-positive.png
deleted file mode 100644
index 84edfdf4b3abfc615a23fe5c2915459cb29b6bdf..0000000000000000000000000000000000000000
GIT binary patch
literal 0
HcmV?d00001

literal 849
zcmV-X1FrmuP)<h;3K|Lk000e1NJLTq000mG000mO1^@s6AM^iV0009RNkl<ZIE_tH
zO-L(e6g_t)FNsdZAtQo+Rf$p%{DGR-O%OM4Q=}4}g>DPQMFnw@l~`yuf?L5|>qc5=
zH!g~(1vk%yWFrbfD@d>i65^XA+T=^VneUt1MNN1Y4&2Q>_ug~QC43ZJU0oO-A5RPq
z4}a}A&RYOu%*+6awOZ}Z$H&Lti^ZZ4LUd}Vow%+`v$L~r2L}g#T3lQlG7N)GPEPRf
z@BjdC9EUB-`p5IUZ*FdG-g}<M9Rl07DV<Kgo1C2dWo>QkO}$=6KA$Jw_W=O^4*>>%
zzP>)$Xf(dMyu3Vmd3j-jh>%L9KJD-C-{08Scr!3CfTN=$Qc7WKYYQtYD+t37N-5G>
zqf{!zVzJmkDwP@~A{e%9Q!<(SVR?Dka$Of%Yw|n~rfDLR$zW<~3Q8$xtve*;a=FKG
zobMgSp-3W;u%glEm)UHV!Z0Le#@N^x&d<-Ww6ugE2%wbuSZg982qE6tw*8%9n&#x_
z=xB_HptVLAhREe|n4X@75CT$4D5ap3LJ$NUG@H!?5sgQ**0yPyq_w8DVDWey+uPf?
zzP`rA#RbmJ&fs|-m>J9rA|j;}DW!T0DP^TxF0<B}l~M@95L#;hz|71HR##WCzrT<9
z`T0(F-}hNc$w3fQ3@PQ`S65f{Mxz0(bq7i*RI618ArOzpk<aI0nkIbTZ^LV~T1BJP
zYRPJ~`rF~*AqPRgZN(dn26DL^*4Nh&h9NA=!qCtVf*@eu_u2RTUt6t~Hk4A_Y&L(~
z-QE3gdwUC|6l<+v7zQ$#4ASXz=ZsHJPb{T`l(HnH+zx_(+g7GXB$Dmz?fqkCXQyXw
zZm#3fR~O>+^prO@HxY(mm59F3S{IlZWEcjb(I~pRyD1WhOba1?&StZpEi5dM>$<4b
zYA6&6I6gjRA}Uyx^({01C4^w#_d$DmdyZvUpAb<mGxt0{KgaLy@0afG?y{9i#eIFW
z4-*p;??*;Pj+4oxB%)^k6(Pg}9UL4?0Qek0KY$(p2>=E&+W?H$6+<HW7eEN04&Vhq
b2|(dL<Ppl}ghL7P00000NkvXXu0mjfD;0mm

diff --git a/sonar-server/src/main/webapp/images/reviews/+review.png b/sonar-server/src/main/webapp/images/reviews/+review.png
deleted file mode 100644
index 622e48e194ae0b42792718824b27e6467019c6d7..0000000000000000000000000000000000000000
GIT binary patch
literal 0
HcmV?d00001

literal 976
zcmV;>126oEP)<h;3K|Lk000e1NJLTq000mG000mO1^@s6AM^iV00001b5ch_0Itp)
z=>Px#24YJ`L;(K){{a7>y{D4^000SaNLh0L01FcU01FcV0GgZ_00007bV*G`2ipV;
z6C@rU{GQkV00U4-L_t(I%cYZBXj^pv#=rl$<|HR+;@VhE(zz||tg@GM6x(!)h>Sp6
zu|w#?$^<VsE5i#)yIJX5Gh~HLMVPFLI!hIqZg?GIm-eBx+7@TDpmuF~$@L_wIVZPs
z`TL*_Ho+Ia$M50yJ$&B>{7;cvjp5<pkk98o<do$wF9>c`E!3*2x}M2o)+?3jc}nTY
zXmlk0FTl{yYu=8I@ELy~(9RG7P1BG}CZQ;bv9XchG);qH7ywWLFc^)F9KQiLa^%&m
zkw|2oWf@N__Ve=8)RZHa%WV;D5>qNykVqs!Ez|V-?npH>G#IihH~bBWvI7Hya!bqZ
z`9h(P9~*l&DcB^fXJ5}YyX;~dat-pE1;p19Sp0Q~ak+1k!r``4Gt<+2U0q%Ko;~+}
zMFs{2U*<S&+e&;jef0HX2b~Vdd+v)b@$LBwP*n{p@l`BcTZW?KAP77%iDe{G%E+N-
zpSFiWp(IzXRFYkhuB6A~eurU*2m+Xvg&*b?P%c-H%jcmeIRHSw?+3MjQb`*;I(lMk
z?BtuDF&4vJ({=rEL6pQ)It|mX5ZU`Mbi=rj{EuFI{yC&G8SuQ#OeZ!{lHK8CAAG2z
zdimm{0ZKECO-*;@bBe^V9C{z?!Rp!?ve_&egFy@(eg!l4&S7-rEu6mmp=w`bzB6=s
zg&gSb7JSZ~I}+J!IDfs=)Y;X!y>)kMt4$IEF4+k~uYwmvXr*%TzONq;yZ1f9j(<FU
zy+6MH3BAJ2{#D~khh<14U{C~8sZ?{ZPz(s7&Es;pYdMZ3@9X1jrL9$t;aH=yugiIE
z;_SM?SsEdjCIIl!=@_$g;d7hjE!R?u)-$|S56h~vC~*@?<rDSq9c=AwyZzSHUi$Rn
z0s(;EK*{9jaV#wVB3Odpkcj94%hZ5!HH4V<Q=W+zRHE$wK!d$^2Nx$|F$<<a8O+}N
z1zBX8yPrfzsui{fs%RHjiSmX_EeA)a!5s6v{fW2FcTehr)gSw_2ioITA1$*t0jeg=
zUY(^sZG3O8{a#<S+vKX9c(tNjEb5$9nctk*^~Youq)g{_m733Hzj?|e|8-TKXUUyh
y4f9OnUN+srle|-B1<r|0m)C%@)0}vt&-@b>(||%XBon>>0000<MNUMnLSTYV2+LCd

diff --git a/sonar-server/src/main/webapp/images/reviews/false_positive.png b/sonar-server/src/main/webapp/images/reviews/false_positive.png
new file mode 100644
index 0000000000000000000000000000000000000000..42e6a028f9d3ee6f5ca19f3202fa7b76c208889f
GIT binary patch
literal 3118
zcmV+}4AJw6P)<h;3K|Lk000e1NJLTq000mG000aK1^@s6Yv(<I000U@X+uL$Nkc;*
zaB^>EX>4Tx0C?J+Q+HUC_ZB|i_hk=OLfG)Jmu!ImA|tE_$Pihg5Rw34gb)%y#f69p
zRumNxoJdu~g4GI0orvO~D7a@qiilc^Ra`jkAKa(4eR}Wh?fcjJyyu+f{LXpL4}cL8
zCXwc%Y5+M>g*-agACFH+#L2yY0u@N$1RxOR%fe>`#Q*^C19^CUbg)1C0k3ZW0swH;
zE+i7i;s1lWP$pLZAdvvzA`<5d0gzGv$SzdK6adH=0I*ZDWC{S3003-xd_p1ssto|_
z^hrJi0NAOM+!p}Yq8zCR0F40vnJ7mj0zkU}U{!%qECRs70HCZuA}$2Lt^t5qwlYTo
zfV~9(c8*w(4?ti5fSE!p%m5%b0suoE6U_r4Oaq`W(!b!TUvP!ENC5!A%azTSOVTqG
zxRuZvck=My;vwR~Y_URN7by^C3FIQ2mzyIKNaq7g&I|wm8u`(|{y0C7=jP<$=4R(?
z@ASo@{%i1WB0eGU-~POe0t5gMPS5Y!U*+Z218~Oyuywy{sapWrRsd+<`CT*H37}dE
z(0cicc{uz)9-g64$UGe!3JVMEC1RnyFyo6p|1;rl;ER6t{6HT5+j{T-ahgDxt-zy$
z{c&M#cCJ#6=gR~_F>d$gBmT#QfBlXr(c(0*Tr3re@mPttP$EsodAU-NL?OwQ;u7h9
zGVvdl{RxwI4FIf$Pry#L2er#=z<%xl0*ek<(slqqe)BDi8VivC5N9+pdG`PSlfU_o
zKq~<N&6lL(006w`7+k277fi+o002awfhw>;2Moa!tiTSO!5zH77Xo1hL_iEAz&sE_
z2IPPo3ZWR5K^auQI@koYumc*P5t`u;w81er4d>tzT!HIw7Y1M$p28Tsh6w~g$Osc*
zAv%Z=Vvg7%&IlKojszlMNHmgwq#)^t6j36@$a16tsX}UzT}UJHEpik&ja)$bklV;0
zGK&0)yhkyVfwEBp)B<%txu_o+ipHRG(R4HqU4WLNYtb6C9zB4zqNmYI=yh}eeTt4_
zfYC7yW{lZkT#ScBV2M~7CdU?I<ybXVk2PZ*ST}YR8^E4n?+7FUi+~gC2wsE`!fb+&
zkVjZdSVO2K>?5=ix(HVZgM=}{CnA%mPqZa^68Xe<Vmh&qSVpWS?jar_o+Vx<4ijIK
zNF)x)lH^VbAtjJ9NefA9NZUv)q*J6m(hzB!OeX7)ZOPu`2(o~zAeWK1kPnbglKaWS
z<hK+$#faie38ExYq?8g$HDy2L1f`!cLYbhdQO&8I)Cj7GI-goeZJ>5gFH?u96Et<2
zCC!@_L(8Nsqt(!wX=iEoXfNq>x(VHb9z~bXm(pwK2kGbOgY<U{4TcSa$4Fu*8EYAP
z8K)Sx884YkrUlcNnaETy*D@QKXP6I|Z&g?-_9}c8k;)R4I+a$HewF8{R8@0TKh=4v
z3skFB5362QeWpfLvryxy3Dg#=)u|m-yQwy=&Qf<$k5JE1U!%TX{et>q4YG!XMxcgB
zqf}$J#u<$v7REAV@mNCEa#jQDENhreVq3EL>`ZnA`x|yIdrVV9bE;;nW|3x{=5fsd
z4#u(I@HyF>O3oq94bFQl11&!-vDRv>X03j$H`;pIzS?5#a_tuF>)P*iaGgM%ES>c_
zZ94aL3A#4AQM!e?+jY<CKGS3CdFcuD%JmNE-O)$&ZS<q{7wYfU@6jJOFf<4@kQr<-
zIAie4kYng;m}$7t@Py&05zA=0k;G`D(Mh8xxF+t0XX7<^7d~dJZyaK*G~Q+0Ydm3M
zX)@cS#H7XKzA4R=Yno=d(X`Wa%*@Cv+^pEF$?T3f)tqadVZPbC+x(4%rA3^@N{cp&
z$Clcbe9HxvO_ukpm{vYkc~<pS*Q`m_T<a|BZPr(8P#ag944XQe%eJVko2|rln{D3|
z;uMc5(kb;*ZrU;I{Ok(sn(PMcIrd@pCH8Ih&mGJh5*^k%bUS=<bal*jY;e5mq~SEf
zsl=(n=~rhPXQ6YQ^EDTyOOVSFmv)yIQ*Eb;r*5Bm%a!FC?z+;o)Agg9yPMpt*=^L_
z%ss_@tNTqZn;Xep!#(do^zips;&II5ou`|p!t;>lFJ5+DSzi0S9#6BJCZ5(XZOGfi
zTj0IRdtf>~J!SgN=>tB-J_4V5pNGDtz9Qc}z9W9tewls;{GR(e`pf-~_`l(K@)q$<
z1z-We0p$U`ff|9c18V~x1epY-2Q>wa1-k|>3_cY?3<(WcA99m#z!&lx`C~KOXDpi0
z70L*m6<QnmFw7=Q9@Y_#hR+D!5Pol_`Aq4|wg`yeM{J0=A88qx7x{e@DJn9mF6vRV
zQ*?23_bk?|<XQV?y^isZsf@Wh+iJFQc4w?=Y*K7v?3=iNxT?5;c!&5!@s|>G6C?@k
ziR8rC#65}Qa{}jVnlqf_npBo_W3J`gqPZ95>CVfZcRX1&S&)1<g_shTvOnd6AVN?t
z7*FM=ZcQB%@`Rg(Pes0>jiOPpx423?lIEROmG(H@JAFg?XogQlb;dIZPf{y+kr|S?
zBlAsGMAqJ{&)IR=Ejg5&l$@hd4QZCNE7vf$D7Q~$D=U)?<ay?8${Ul1%J<|W`E&Ez
z6>Nn}(WA6du22pZOfRS_cv~1-c(_QtNLti0-)8>m`6CO07JR*suu!<Lv)H(JS@GZ^
zzeT$iBa2fPcP=qqQo3Y#Y4Fm0%V^88mi<uTSW;E;YI)r9j#7itrKLkFf>$(^sg%jf
zZm#rNxnmV!m1I@#YM0epR(~oNm0zrItf;Q|utvD%;#W>z)qM4NZQ9!2O1H}G>qzUQ
z>u#*~S--DJy=p<#(1!30tsC);<r`mZO5Sv#dTRBK&9u$R%>y-IHSJr>wyfLop*ExT
zdYyk=%U1oZtGB+{Cfe4&-FJKQ4uc&PJKpb<?7X!rcvow^MSb;d((Z!Yj~Zedy1(Xr
z-MB}0PsN^(d!>5^_C@dOYIJXG+^@gCvI%WcHjN%gI&kHifN$EH?V5MBa9S!3!a?Q1
zC*P)gd*e{(q0YnH!_D8Bf4B7r>qvPk(mKC&tSzH$pgp0z@92!9ogH2sN4~fJe(y2k
zV|B+hk5`_cohUu=`Q(C=<ELb&o}ErVJ=B@pdG}2GnQL89UA<>R&z?UQbnZ;IU-!xL
z-sg{9@Vs#JBKKn3CAUkhJ+3`ResKNaNUvLO>t*-L?N>ambo5Q@JJIjcfBI^`)pOVQ
z*DhV3dA;w(>>IakCfyvkCA#(acJ}QTcM9%I++BK)c(44v+WqPW`VZ=VwEnSWz-{38
zV8CF{!&wjS4he^z{*?dIhvCvk%tzHDMk9@nogW_?4H~`jWX_Y}r?RIL&&qyQ|9R_k
ztLNYS;`>X_Sp3-V3;B!Bzpi<y^K$R2sjoW6BgY@S&UroYru?nW+kNl2@4DZ|y&st<
z{6PLt^U?Za$EVOw_de%*{`@cZg!B7=IVBMQ000JJOGiWi{{a60|De66lK=n!32;bR
za{vGf5&!@T5&_cPe*6Fc00(qQO+^RW1sV=C1og0FBLDyaY)M2xR4C7Vk}*%?KoEt$
z-2{>dB1J;LU74Ccao18&KyPe`-@+eAg{-)zM54XpZ%~BR2q8tXAjJ0WquAJ1juTIM
zn%Nn>w==6Xk^p#0k_easU<`IR1Y<(JyNi2!LuJVZm(w)O0FcBYj-z5Wlh1Rta8B|*
zu*oI)JXbNBX%WYfq}HGlJ13Q;R8@gx*`1whO%`!1N%WhU%<(Z)6?o4UHftcYJ#%yv
zYS0+~$a|>k(6ly)q>zVw!5B=hM{j@ss{!5z8q-bE+-xm47iv2@_|*yk+iD*lw*_?_
zR%*CjhiEPO_&{~t8AytX`+Jn<(C=dg1I%z3I38n0Bh20&W-<ZqDQ<26G62*3gGG`=
zy}@8UIXPi`dfGl-ad$`Y{ES;J@$c`=z}YlSFSiUDJSE9|bZ`(IUR>~Ud&}zeHT!XX
zezkmfsD55w^Dn*_Y)t+Dzkt8fH2uvtu>UJo>-8CsZQ{511W17W%U&G&DgXcg07*qo
IM6N<$f-rXQX#fBK

literal 0
HcmV?d00001

diff --git a/sonar-server/src/main/webapp/images/reviews/review.png b/sonar-server/src/main/webapp/images/reviews/review.png
deleted file mode 100644
index 3af02f48d89d43dd905f7e2a660aec2f3e7e69fb..0000000000000000000000000000000000000000
GIT binary patch
literal 0
HcmV?d00001

literal 947
zcmV;k15EshP)<h;3K|Lk000e1NJLTq000mG000mO1^@s6AM^iV0000PbVXQnQ*UN;
zcVTj606}DLVr3vnZDD6+Qe|Oed2z{QJOBU#RY^oaRCwB?Q(b5rRTMt=XYTCm&i<vF
z?a%H;ThmDO$xR5_&5Nk$LQ-f%5c;4GMbK&yL20zD<VlNIwD?ppzUiZis9+5BCpIlw
z6RXrhXtGI@?9R^qB<{@4&fmRG0xKfEdEk4vhjZ@v&Uem1LJ0UjM*r=YoSe*OGTD<+
zRV_%2B@CmLG7Mu~*Y$PVcBX@Z7lW|XZanHTID7W>^vFozlWZ<`7$XFxX+ot^fqK2}
zZETe3_S^Hk?NBSgM1XhyW^nrSnLCQb;yfWZId^%kG&?&RX*3$U<dA}`j!nzu3JC7|
z+00(8udmNjRrQ@9O$qQO323Q<gG2MJR;xKR^<jmD6m$IX@%>>nh9hbmnp-VcT`R-Q
z#U&g|^eBbG10P(yaz*Ox?LCYT`U;&oHSsc~bpOig?drL=-hMV3QPQ7(@g;mcJp+be
zLg0s`<x<c}0~nJ)FPEUK)!#Vz+%w^PK3}07+pdfi$12HW;(d&f3<$vI9IpMc0G*Bv
zjb?KvdE0W?Y|u&|f@MyeJAYwn>f(E!Vvgyu>$*=fS&_AB6?~6F@zF=X4Fu~}?%GQ)
zJ`Yu02T2O~)$)d>gd<V%;6o$Mcb9(fKnVTdz`&i&MqQzV!jn&o!|k;-sMTt4u)iP9
zy!r|hi;n>aWL%&B`J=hZvxeu2@6l5yj<8Jh?z_shTA{gV4UCSB9vB`P9u6sTE~ZAo
za~+Um8BD9wUYK9_{o705EHXm2FvByhO@Bhb;_%uFCsa^S&J)nDY1*N7tDR$VC>e_-
zQj`*eFcuBH`e#ovZYW`;j)C0pedkxY<(78#;NJYP_R`E}D`vW5?&;a9;oW=>aNf%W
zN(7sx3WP{*U)u9Awm^X9dtzDGp&Cxn_Ra^x$L<mK`DtsRw4!mw48@VFKyVxcjU&Xv
zz>&-eA;=YWz-BXqs1CAeq%($(x(c%Zjw<6rM~*{YNwHnbki(29Lh@9>BNPb_bK)Tx
zBby>*G^}=O^|zxP^j{Z-c1O@YHj3`QFC%4BX=0}~C5$+WbvSZ~<NF*treWACA75~Z
zqJ)Fl`$5`2&f0XrH2x5ax32Q_8`t>5&6ID)EvLpd109H0izi*%9rUmNIK=-FU;yGP
VnL<(F`6&PZ002ovPDHLkV1np(&gB3A

diff --git a/sonar-server/src/main/webapp/images/reviews/with_false_positives.png b/sonar-server/src/main/webapp/images/reviews/with_false_positives.png
new file mode 100644
index 0000000000000000000000000000000000000000..64e06e1c9f6d61ccc8a74c76b379a09f2cafce06
GIT binary patch
literal 3092
zcmV+v4D0iWP)<h;3K|Lk000e1NJLTq000mG000aK1^@s6Yv(<I000U@X+uL$Nkc;*
zaB^>EX>4Tx0C?J+Q+HUC_ZB|i_hk=OLfG)Jmu!ImA|tE_$Pihg5Rw34gb)%y#f69p
zRumNxoJdu~g4GI0orvO~D7a@qiilc^Ra`jkAKa(4eR}Wh?fcjJyyu+f{LXpL4}cL8
zCXwc%Y5+M>g*-agACFH+#L2yY0u@N$1RxOR%fe>`#Q*^C19^CUbg)1C0k3ZW0swH;
zE+i7i;s1lWP$pLZAdvvzA`<5d0gzGv$SzdK6adH=0I*ZDWC{S3003-xd_p1ssto|_
z^hrJi0NAOM+!p}Yq8zCR0F40vnJ7mj0zkU}U{!%qECRs70HCZuA}$2Lt^t5qwlYTo
zfV~9(c8*w(4?ti5fSE!p%m5%b0suoE6U_r4Oaq`W(!b!TUvP!ENC5!A%azTSOVTqG
zxRuZvck=My;vwR~Y_URN7by^C3FIQ2mzyIKNaq7g&I|wm8u`(|{y0C7=jP<$=4R(?
z@ASo@{%i1WB0eGU-~POe0t5gMPS5Y!U*+Z218~Oyuywy{sapWrRsd+<`CT*H37}dE
z(0cicc{uz)9-g64$UGe!3JVMEC1RnyFyo6p|1;rl;ER6t{6HT5+j{T-ahgDxt-zy$
z{c&M#cCJ#6=gR~_F>d$gBmT#QfBlXr(c(0*Tr3re@mPttP$EsodAU-NL?OwQ;u7h9
zGVvdl{RxwI4FIf$Pry#L2er#=z<%xl0*ek<(slqqe)BDi8VivC5N9+pdG`PSlfU_o
zKq~<N&6lL(006w`7+k277fi+o002awfhw>;2Moa!tiTSO!5zH77Xo1hL_iEAz&sE_
z2IPPo3ZWR5K^auQI@koYumc*P5t`u;w81er4d>tzT!HIw7Y1M$p28Tsh6w~g$Osc*
zAv%Z=Vvg7%&IlKojszlMNHmgwq#)^t6j36@$a16tsX}UzT}UJHEpik&ja)$bklV;0
zGK&0)yhkyVfwEBp)B<%txu_o+ipHRG(R4HqU4WLNYtb6C9zB4zqNmYI=yh}eeTt4_
zfYC7yW{lZkT#ScBV2M~7CdU?I<ybXVk2PZ*ST}YR8^E4n?+7FUi+~gC2wsE`!fb+&
zkVjZdSVO2K>?5=ix(HVZgM=}{CnA%mPqZa^68Xe<Vmh&qSVpWS?jar_o+Vx<4ijIK
zNF)x)lH^VbAtjJ9NefA9NZUv)q*J6m(hzB!OeX7)ZOPu`2(o~zAeWK1kPnbglKaWS
z<hK+$#faie38ExYq?8g$HDy2L1f`!cLYbhdQO&8I)Cj7GI-goeZJ>5gFH?u96Et<2
zCC!@_L(8Nsqt(!wX=iEoXfNq>x(VHb9z~bXm(pwK2kGbOgY<U{4TcSa$4Fu*8EYAP
z8K)Sx884YkrUlcNnaETy*D@QKXP6I|Z&g?-_9}c8k;)R4I+a$HewF8{R8@0TKh=4v
z3skFB5362QeWpfLvryxy3Dg#=)u|m-yQwy=&Qf<$k5JE1U!%TX{et>q4YG!XMxcgB
zqf}$J#u<$v7REAV@mNCEa#jQDENhreVq3EL>`ZnA`x|yIdrVV9bE;;nW|3x{=5fsd
z4#u(I@HyF>O3oq94bFQl11&!-vDRv>X03j$H`;pIzS?5#a_tuF>)P*iaGgM%ES>c_
zZ94aL3A#4AQM!e?+jY<CKGS3CdFcuD%JmNE-O)$&ZS<q{7wYfU@6jJOFf<4@kQr<-
zIAie4kYng;m}$7t@Py&05zA=0k;G`D(Mh8xxF+t0XX7<^7d~dJZyaK*G~Q+0Ydm3M
zX)@cS#H7XKzA4R=Yno=d(X`Wa%*@Cv+^pEF$?T3f)tqadVZPbC+x(4%rA3^@N{cp&
z$Clcbe9HxvO_ukpm{vYkc~<pS*Q`m_T<a|BZPr(8P#ag944XQe%eJVko2|rln{D3|
z;uMc5(kb;*ZrU;I{Ok(sn(PMcIrd@pCH8Ih&mGJh5*^k%bUS=<bal*jY;e5mq~SEf
zsl=(n=~rhPXQ6YQ^EDTyOOVSFmv)yIQ*Eb;r*5Bm%a!FC?z+;o)Agg9yPMpt*=^L_
z%ss_@tNTqZn;Xep!#(do^zips;&II5ou`|p!t;>lFJ5+DSzi0S9#6BJCZ5(XZOGfi
zTj0IRdtf>~J!SgN=>tB-J_4V5pNGDtz9Qc}z9W9tewls;{GR(e`pf-~_`l(K@)q$<
z1z-We0p$U`ff|9c18V~x1epY-2Q>wa1-k|>3_cY?3<(WcA99m#z!&lx`C~KOXDpi0
z70L*m6<QnmFw7=Q9@Y_#hR+D!5Pol_`Aq4|wg`yeM{J0=A88qx7x{e@DJn9mF6vRV
zQ*?23_bk?|<XQV?y^isZsf@Wh+iJFQc4w?=Y*K7v?3=iNxT?5;c!&5!@s|>G6C?@k
ziR8rC#65}Qa{}jVnlqf_npBo_W3J`gqPZ95>CVfZcRX1&S&)1<g_shTvOnd6AVN?t
z7*FM=ZcQB%@`Rg(Pes0>jiOPpx423?lIEROmG(H@JAFg?XogQlb;dIZPf{y+kr|S?
zBlAsGMAqJ{&)IR=Ejg5&l$@hd4QZCNE7vf$D7Q~$D=U)?<ay?8${Ul1%J<|W`E&Ez
z6>Nn}(WA6du22pZOfRS_cv~1-c(_QtNLti0-)8>m`6CO07JR*suu!<Lv)H(JS@GZ^
zzeT$iBa2fPcP=qqQo3Y#Y4Fm0%V^88mi<uTSW;E;YI)r9j#7itrKLkFf>$(^sg%jf
zZm#rNxnmV!m1I@#YM0epR(~oNm0zrItf;Q|utvD%;#W>z)qM4NZQ9!2O1H}G>qzUQ
z>u#*~S--DJy=p<#(1!30tsC);<r`mZO5Sv#dTRBK&9u$R%>y-IHSJr>wyfLop*ExT
zdYyk=%U1oZtGB+{Cfe4&-FJKQ4uc&PJKpb<?7X!rcvow^MSb;d((Z!Yj~Zedy1(Xr
z-MB}0PsN^(d!>5^_C@dOYIJXG+^@gCvI%WcHjN%gI&kHifN$EH?V5MBa9S!3!a?Q1
zC*P)gd*e{(q0YnH!_D8Bf4B7r>qvPk(mKC&tSzH$pgp0z@92!9ogH2sN4~fJe(y2k
zV|B+hk5`_cohUu=`Q(C=<ELb&o}ErVJ=B@pdG}2GnQL89UA<>R&z?UQbnZ;IU-!xL
z-sg{9@Vs#JBKKn3CAUkhJ+3`ResKNaNUvLO>t*-L?N>ambo5Q@JJIjcfBI^`)pOVQ
z*DhV3dA;w(>>IakCfyvkCA#(acJ}QTcM9%I++BK)c(44v+WqPW`VZ=VwEnSWz-{38
zV8CF{!&wjS4he^z{*?dIhvCvk%tzHDMk9@nogW_?4H~`jWX_Y}r?RIL&&qyQ|9R_k
ztLNYS;`>X_Sp3-V3;B!Bzpi<y^K$R2sjoW6BgY@S&UroYru?nW+kNl2@4DZ|y&st<
z{6PLt^U?Za$EVOw_de%*{`@cZg!B7=IVBMQ000JJOGiWi{{a60|De66lK=n!32;bR
za{vGf5&!@T5&_cPe*6Fc00(qQO+^RW1sV?<8XRE@8UO$RQb|NXR4C7dlCe$#K@f(&
z-8(FV5Uh9z8yb3ziM4NV2Q804%_CS?5RUj1#6mj?8X99lVMBA#1QIaE<=ES?@VIb#
z!9SU7GV{+jyOUKS0>E3Z=Ns1@iBcHXMU*0S9IVz@tw|k+qgv;t-wyx~5#GC9e|vu~
zHVoxI*)Wv#!-G5x2EK^ofI_p4BC)GgF`_81Z?{_sf<QzBO(xZB{@iG{gE;1o;uu-4
z0jSk#dD=bp$bMgJu2dk~hq#$FO>rEj9KhEXWX61nO8wM~$!*7g{0Vlkfb(-OhJBi{
zQ;Nh|j4_4KT9YJ65g;P|=VZd>;{$bZ!C9k0wOTC=Yc1316d(Xlhkx)m9D27=6ue$u
z(rUHx3G?}!<#PFZrGe*podV#X@pwF{*Xw?}-DWnMvDs{LbD91CGRQM<1-y8kcg+du
ivSgAZcR-MxC-n_IZTA_bt@^eA0000<MNUMnLSTYp6y+NL

literal 0
HcmV?d00001

diff --git a/sonar-server/src/main/webapp/stylesheets/style.css b/sonar-server/src/main/webapp/stylesheets/style.css
index c3d24f1689f..3b137d5fd6a 100644
--- a/sonar-server/src/main/webapp/stylesheets/style.css
+++ b/sonar-server/src/main/webapp/stylesheets/style.css
@@ -693,6 +693,8 @@ div.vtitle{
 }
 .falsePositive {
   background-color: #FFF6BF;
+  padding-left: 5px;
+  padding-right: 5px;
 }
 div.vtitle a.action {
   color: #777;
@@ -898,11 +900,23 @@ div.discussionComment li {
   list-style: square inside;
 }
 div.comment-excerpt {
-	background-color: transparent;
-	margin-top: 5px;
-	margin-bottom: 5px;
-	color: #777777;
-	font-size: 90%;
+  background-color: transparent;
+  margin-top: 5px;
+  margin-bottom: 5px;
+  color: #777777;
+  font-size: 90%;
+}
+.max-width {
+  width: 100%;
+}
+option.sel-with-false-positives {
+  background-image: url('../images/reviews/with_false_positives.png');
+}
+option.sel-only-false-positives {
+  background-image: url('../images/reviews/false_positive.png');
+}
+option.sel-without-false-positives {
+  background-image: url('../images/reviews/comment.png');
 }
 
 
-- 
2.39.5