From aaadb099340ef9be01ededf5f1681e86b8efcdd0 Mon Sep 17 00:00:00 2001 From: Sergey Vladimirov Date: Fri, 21 Oct 2011 21:56:54 +0000 Subject: [PATCH] it's better to always specify offset for write and reading operations deprecate methods with default (0) offset git-svn-id: https://svn.apache.org/repos/asf/poi/trunk@1187568 13f79535-47bb-0310-9956-ffa450edef68 --- src/java/org/apache/poi/util/LittleEndian.java | 17 ++++++++++++++++- 1 file changed, 16 insertions(+), 1 deletion(-) diff --git a/src/java/org/apache/poi/util/LittleEndian.java b/src/java/org/apache/poi/util/LittleEndian.java index fa67dfdda1..81dc3536e4 100644 --- a/src/java/org/apache/poi/util/LittleEndian.java +++ b/src/java/org/apache/poi/util/LittleEndian.java @@ -112,7 +112,9 @@ public class LittleEndian implements LittleEndianConsts * @param data * the byte array * @return the int (32-bit) value + * @deprecated Use {@link #getInt(byte[], int)} */ + @Deprecated public static int getInt( byte[] data ) { return getInt( data, 0 ); @@ -164,7 +166,9 @@ public class LittleEndian implements LittleEndianConsts * @param data * the byte array * @return the short (16-bit) value + * @deprecated Use {@link #getShort(byte[], int)} instead */ + @Deprecated public static short getShort( byte[] data ) { return getShort( data, 0 ); @@ -228,7 +232,9 @@ public class LittleEndian implements LittleEndianConsts * @param data * the byte array * @return the unsigned int (32-bit) value in a long + * @deprecated Use {@link #getUInt(byte[], int)} */ + @Deprecated public static long getUInt( byte[] data ) { return getUInt( data, 0 ); @@ -271,7 +277,9 @@ public class LittleEndian implements LittleEndianConsts * @param data * the byte array * @return the unsigned short (16-bit) value in an int + * @deprecated Use {@link #getUShort(byte[], int)} */ + @Deprecated public static int getUShort( byte[] data ) { return getUShort( data, 0 ); @@ -376,7 +384,9 @@ public class LittleEndian implements LittleEndianConsts * the byte array * @param value * the int (32-bit) value + * @deprecated Use {@link #putInt(byte[], int, int)} instead */ + @Deprecated public static void putInt( byte[] data, int value ) { putInt( data, 0, value ); @@ -489,7 +499,9 @@ public class LittleEndian implements LittleEndianConsts * the byte array * @param value * the short (16-bit) value + * @deprecated Use {@link #putShort(byte[], int, short)} instead */ + @Deprecated public static void putShort( byte[] data, short value ) { putShort( data, 0, value ); @@ -522,7 +534,8 @@ public class LittleEndian implements LittleEndianConsts * @param value * the short (16-bit) values */ - public static void putShortArray( byte[] data, int startOffset, short[] value ) + public static void putShortArray( byte[] data, int startOffset, + short[] value ) { int offset = startOffset; for ( short s : value ) @@ -579,7 +592,9 @@ public class LittleEndian implements LittleEndianConsts * the byte array * @param value * the int (32-bit) value + * @deprecated Use {@link #putUInt(byte[], int, long)} instead */ + @Deprecated public static void putUInt( byte[] data, long value ) { putUInt( data, 0, value ); -- 2.39.5