From ade6bde9667b483d64fbdf472e45b5ca407003b6 Mon Sep 17 00:00:00 2001
From: Constantin Kaplinsky <const@tightvnc.com>
Date: Fri, 19 May 2006 10:58:37 +0000
Subject: [PATCH] Various small fixes in file transfer related files to
 eliminate compilation warnings under Linux.

git-svn-id: svn://svn.code.sf.net/p/tigervnc/code/trunk@563 3789f03b-4d11-0410-bbf8-ca57d06f2519
---
 rfb/SFileTransfer.cxx                 | 3 +++
 rfb/SFileTransfer.h                   | 4 ++--
 rfb/SFileTransferManager.cxx          | 2 +-
 rfb/SFileTransferManager.h            | 2 +-
 rfb_win32/SFileTransferManagerWin32.h | 4 ++--
 rfb_win32/SFileTransferWin32.h        | 2 +-
 6 files changed, 10 insertions(+), 7 deletions(-)

diff --git a/rfb/SFileTransfer.cxx b/rfb/SFileTransfer.cxx
index 9161fff7..0a8b40e9 100644
--- a/rfb/SFileTransfer.cxx
+++ b/rfb/SFileTransfer.cxx
@@ -199,6 +199,9 @@ SFileTransfer::processFileUploadData()
       }
     }
   }
+  // FIXME: For the next line, gcc says:
+  //        warning: deleting `void *' is undefined
+  //        Perhaps it should not be `void *' at all.
   delete [] pUploadData;
   return true;
 }
diff --git a/rfb/SFileTransfer.h b/rfb/SFileTransfer.h
index 62bed406..51a49282 100644
--- a/rfb/SFileTransfer.h
+++ b/rfb/SFileTransfer.h
@@ -39,9 +39,9 @@ namespace rfb {
   {
   public:
     SFileTransfer(network::Socket *sock);
-    ~SFileTransfer();
+    virtual ~SFileTransfer();
 
-	bool processMessages(int type);
+    bool processMessages(int type);
     bool sendFileDownloadPortion();
 
   protected:
diff --git a/rfb/SFileTransferManager.cxx b/rfb/SFileTransferManager.cxx
index d8b231af..999a079b 100644
--- a/rfb/SFileTransferManager.cxx
+++ b/rfb/SFileTransferManager.cxx
@@ -52,4 +52,4 @@ SFileTransferManager::destroy()
 {
   while(!m_lstFTObjects.empty())
     delete m_lstFTObjects.front();
-}
\ No newline at end of file
+}
diff --git a/rfb/SFileTransferManager.h b/rfb/SFileTransferManager.h
index 4ee1406e..fe816444 100644
--- a/rfb/SFileTransferManager.h
+++ b/rfb/SFileTransferManager.h
@@ -36,7 +36,7 @@ namespace rfb {
   {
   public:
     SFileTransferManager();
-    ~SFileTransferManager();
+    virtual ~SFileTransferManager();
 
     virtual SFileTransfer *createObject(network::Socket *sock) = 0;
     void destroyObject(SFileTransfer *pFT);
diff --git a/rfb_win32/SFileTransferManagerWin32.h b/rfb_win32/SFileTransferManagerWin32.h
index b98de4f0..ed1f997a 100644
--- a/rfb_win32/SFileTransferManagerWin32.h
+++ b/rfb_win32/SFileTransferManagerWin32.h
@@ -36,8 +36,8 @@ namespace rfb {
     {
     public:
       SFileTransferManagerWin32();
-      ~SFileTransferManagerWin32();  
-      
+      virtual ~SFileTransferManagerWin32();
+
       void processDownloadMsg(MSG msg);
 
       virtual SFileTransfer *createObject(network::Socket *sock);
diff --git a/rfb_win32/SFileTransferWin32.h b/rfb_win32/SFileTransferWin32.h
index f4c87ea8..5f682a44 100644
--- a/rfb_win32/SFileTransferWin32.h
+++ b/rfb_win32/SFileTransferWin32.h
@@ -38,7 +38,7 @@ namespace rfb {
     {
     public:
       SFileTransferWin32(network::Socket *sock);
-      ~SFileTransferWin32();
+      virtual ~SFileTransferWin32();
 
       bool processDownloadCallback();
       virtual bool initDownloadCallback();
-- 
2.39.5