From af86054979ef0a46800238e22fa15c8aff02759b Mon Sep 17 00:00:00 2001
From: Jeremy Davis <jeremy.davis@sonarsource.com>
Date: Fri, 5 Aug 2022 14:32:17 +0200
Subject: [PATCH] SONAR-16731 [891660] Programmatic label does not convey
 purpose of control

---
 .../js/apps/projects/components/AllProjects.tsx     |  1 +
 .../__snapshots__/AllProjects-test.tsx.snap         |  1 +
 .../src/main/js/components/controls/ListFooter.tsx  | 13 ++++++++++++-
 .../src/main/js/components/controls/buttons.tsx     |  2 +-
 .../main/resources/org/sonar/l10n/core.properties   |  2 +-
 5 files changed, 16 insertions(+), 3 deletions(-)

diff --git a/server/sonar-web/src/main/js/apps/projects/components/AllProjects.tsx b/server/sonar-web/src/main/js/apps/projects/components/AllProjects.tsx
index d7de7ef7727..b2a000ba1b2 100644
--- a/server/sonar-web/src/main/js/apps/projects/components/AllProjects.tsx
+++ b/server/sonar-web/src/main/js/apps/projects/components/AllProjects.tsx
@@ -265,6 +265,7 @@ export class AllProjects extends React.PureComponent<Props, State> {
           />
         )}
         <ListFooter
+          accessibleLoadMoreLabel={translate('projects.show_more')}
           count={this.state.projects !== undefined ? this.state.projects.length : 0}
           loading={this.state.loading}
           loadMore={this.fetchMoreProjects}
diff --git a/server/sonar-web/src/main/js/apps/projects/components/__tests__/__snapshots__/AllProjects-test.tsx.snap b/server/sonar-web/src/main/js/apps/projects/components/__tests__/__snapshots__/AllProjects-test.tsx.snap
index e5bddc372ab..5bc0159cb69 100644
--- a/server/sonar-web/src/main/js/apps/projects/components/__tests__/__snapshots__/AllProjects-test.tsx.snap
+++ b/server/sonar-web/src/main/js/apps/projects/components/__tests__/__snapshots__/AllProjects-test.tsx.snap
@@ -170,6 +170,7 @@ exports[`renders 1`] = `
           }
         />
         <ListFooter
+          accessibleLoadMoreLabel="projects.show_more"
           count={1}
           loadMore={[Function]}
           loading={false}
diff --git a/server/sonar-web/src/main/js/components/controls/ListFooter.tsx b/server/sonar-web/src/main/js/components/controls/ListFooter.tsx
index 3f2aaac7ba6..1d4c8786977 100644
--- a/server/sonar-web/src/main/js/components/controls/ListFooter.tsx
+++ b/server/sonar-web/src/main/js/components/controls/ListFooter.tsx
@@ -25,6 +25,7 @@ import DeferredSpinner from '../ui/DeferredSpinner';
 import { Button } from './buttons';
 
 export interface ListFooterProps {
+  accessibleLoadMoreLabel?: string;
   count: number;
   className?: string;
   loading?: boolean;
@@ -37,7 +38,16 @@ export interface ListFooterProps {
 }
 
 export default function ListFooter(props: ListFooterProps) {
-  const { className, count, loading, needReload, total, pageSize, ready = true } = props;
+  const {
+    accessibleLoadMoreLabel,
+    className,
+    count,
+    loading,
+    needReload,
+    total,
+    pageSize,
+    ready = true
+  } = props;
 
   let hasMore = false;
   if (total !== undefined) {
@@ -56,6 +66,7 @@ export default function ListFooter(props: ListFooterProps) {
   } else if (hasMore && props.loadMore) {
     button = (
       <Button
+        aria-label={accessibleLoadMoreLabel}
         className="spacer-left"
         disabled={loading}
         data-test="show-more"
diff --git a/server/sonar-web/src/main/js/components/controls/buttons.tsx b/server/sonar-web/src/main/js/components/controls/buttons.tsx
index 8c0aa493d2a..e4cf225e3f1 100644
--- a/server/sonar-web/src/main/js/components/controls/buttons.tsx
+++ b/server/sonar-web/src/main/js/components/controls/buttons.tsx
@@ -30,7 +30,7 @@ import Tooltip, { TooltipProps } from './Tooltip';
 
 type AllowedButtonAttributes = Pick<
   React.ButtonHTMLAttributes<HTMLButtonElement>,
-  'className' | 'disabled' | 'id' | 'style' | 'title'
+  'aria-label' | 'className' | 'disabled' | 'id' | 'style' | 'title'
 >;
 
 interface ButtonProps extends AllowedButtonAttributes {
diff --git a/sonar-core/src/main/resources/org/sonar/l10n/core.properties b/sonar-core/src/main/resources/org/sonar/l10n/core.properties
index 0a81ba4f272..ee93a308e00 100644
--- a/sonar-core/src/main/resources/org/sonar/l10n/core.properties
+++ b/sonar-core/src/main/resources/org/sonar/l10n/core.properties
@@ -1108,7 +1108,7 @@ projects.sort.duplications=by duplications (best first)
 projects.sort.-duplications=by duplications (worst first)
 projects.sort.size=by size (smallest first)
 projects.sort.-size=by size (biggest first)
-
+projects.show_more=Show more projects
 projects.security_hotspots_reviewed=Hotspots Reviewed
 
 #------------------------------------------------------------------------------
-- 
2.39.5