From b209508d8f4fea31adc6f27871fa6ec69e8770d5 Mon Sep 17 00:00:00 2001 From: provokateurin Date: Mon, 7 Oct 2024 17:37:38 +0200 Subject: [PATCH] feat(TimedJob): Add debug log about time sensitive jobs with long intervals Signed-off-by: provokateurin --- lib/public/BackgroundJob/TimedJob.php | 5 +++++ 1 file changed, 5 insertions(+) diff --git a/lib/public/BackgroundJob/TimedJob.php b/lib/public/BackgroundJob/TimedJob.php index 6a81e841460..85ca34665b4 100644 --- a/lib/public/BackgroundJob/TimedJob.php +++ b/lib/public/BackgroundJob/TimedJob.php @@ -8,6 +8,8 @@ declare(strict_types=1); namespace OCP\BackgroundJob; use OCP\ILogger; +use OCP\Server; +use Psr\Log\LoggerInterface; /** * Simple base class to extend to run periodic background jobs. @@ -80,6 +82,9 @@ abstract class TimedJob extends Job { */ final public function start(IJobList $jobList): void { if (($this->time->getTime() - $this->lastRun) > $this->interval) { + if ($this->interval >= 12 * 60 * 60 && $this->isTimeSensitive()) { + Server::get(LoggerInterface::class)->debug('TimedJob ' . get_class($this) . ' has a configured interval of ' . $this->interval . ' seconds, but is also marked as time sensitive. Please consider marking it as time insensitive to allow more sensitive jobs to run when needed.'); + } parent::start($jobList); } } -- 2.39.5