From b6f53def96d31d07e16eb40c290fcf1705d52156 Mon Sep 17 00:00:00 2001 From: =?utf8?q?Micha=C5=82=20Go=C5=82=C4=99biowski-Owczarek?= Date: Wed, 29 May 2024 18:32:27 +0200 Subject: [PATCH] Tests: Make `:has` selector tests not vulnerable to unrelated failures Use `assert.selectInFixture` consistently in `:has` tests. Previously, any test failure that happened before this test run made it fail due to an additional paragraph with id `qunit-testresult` injected by QUnit. Closes gh-5497 --- test/unit/selector.js | 12 ++++++------ 1 file changed, 6 insertions(+), 6 deletions(-) diff --git a/test/unit/selector.js b/test/unit/selector.js index befc3c618..9867aaf18 100644 --- a/test/unit/selector.js +++ b/test/unit/selector.js @@ -986,10 +986,10 @@ QUnit.test( "pseudo - nth-last-of-type", function( assert ) { QUnit[ QUnit.jQuerySelectors ? "test" : "skip" ]( "pseudo - has", function( assert ) { assert.expect( 4 ); - assert.t( "Basic test", "p:has(a)", [ "firstp", "ap", "en", "sap" ] ); - assert.t( "Basic test (irrelevant whitespace)", "p:has( a )", [ "firstp", "ap", "en", "sap" ] ); - assert.t( "Nested with overlapping candidates", - "#qunit-fixture div:has(div:has(div:not([id])))", + assert.selectInFixture( "Basic test", "p:has(a)", [ "firstp", "ap", "en", "sap" ] ); + assert.selectInFixture( "Basic test (irrelevant whitespace)", "p:has( a )", [ "firstp", "ap", "en", "sap" ] ); + assert.selectInFixture( "Nested with overlapping candidates", + "div:has(div:has(div:not([id])))", [ "moretests", "t2037", "fx-test-group", "fx-queue" ] ); // Support: Safari 15.4+, Chrome 105+ @@ -998,8 +998,8 @@ QUnit[ QUnit.jQuerySelectors ? "test" : "skip" ]( "pseudo - has", function( asse // return no results. Make sure this is accounted for. (gh-5098) // Note: Chrome 105 has this behavior only in 105.0.5195.125 or newer; // initially it shipped with a fully forgiving parsing in `:has()`. - assert.t( "Nested with list arguments", - "#qunit-fixture div:has(faketag, div:has(faketag, div:not([id])))", + assert.selectInFixture( "Nested with list arguments", + "div:has(faketag, div:has(faketag, div:not([id])))", [ "moretests", "t2037", "fx-test-group", "fx-queue" ] ); } ); -- 2.39.5