From b723c0ba6da5945178e24d28d3e2bdfc0e4d5a9b Mon Sep 17 00:00:00 2001 From: Aurelien Poscia Date: Wed, 31 May 2023 12:22:08 +0200 Subject: [PATCH] SONAR-19336 add warning in case organizations whitelist is not set --- .../src/main/java/org/sonar/auth/github/GitHubSettings.java | 4 ++-- .../sonar-web/src/main/js/helpers/mocks/definitions-list.ts | 2 +- 2 files changed, 3 insertions(+), 3 deletions(-) diff --git a/server/sonar-auth-github/src/main/java/org/sonar/auth/github/GitHubSettings.java b/server/sonar-auth-github/src/main/java/org/sonar/auth/github/GitHubSettings.java index b01b1116fbc..cd1e30d010e 100644 --- a/server/sonar-auth-github/src/main/java/org/sonar/auth/github/GitHubSettings.java +++ b/server/sonar-auth-github/src/main/java/org/sonar/auth/github/GitHubSettings.java @@ -238,8 +238,8 @@ public class GitHubSettings { .build(), PropertyDefinition.builder(ORGANIZATIONS) .name("Organizations") - .description("Only members of these organizations will be able to authenticate to the server. " + - "If a user is a member of any of the organizations listed they will be authenticated.") + .description("Only members of these organizations will be able to authenticate to the server. " + + "⚠ if not set, users from any organization where the GitHub App is installed will be able to login to this SonarQube instance.") .multiValues(true) .category(CATEGORY) .subCategory(SUBCATEGORY) diff --git a/server/sonar-web/src/main/js/helpers/mocks/definitions-list.ts b/server/sonar-web/src/main/js/helpers/mocks/definitions-list.ts index 54548bbbe2f..32e36b16e27 100644 --- a/server/sonar-web/src/main/js/helpers/mocks/definitions-list.ts +++ b/server/sonar-web/src/main/js/helpers/mocks/definitions-list.ts @@ -335,7 +335,7 @@ export const definitions: ExtendedSettingDefinition[] = [ key: 'sonar.auth.github.organizations', name: 'Organizations', description: - 'Only members of these organizations will be able to authenticate to the server. If a user is a member of any of the organizations listed they will be authenticated.', + 'Only members of these organizations will be able to authenticate to the server. ⚠︎ if not set, users from any organization where the GitHub App is installed will be able to login to this SonarQube instance.', category: 'authentication', subCategory: 'github', multiValues: true, -- 2.39.5