From be5b81b5349705eaa4b03bbf9a12a2a4630bdd26 Mon Sep 17 00:00:00 2001 From: Stas Vilchik Date: Mon, 3 Mar 2014 18:28:20 +0100 Subject: [PATCH] Fix display of the footer on issues and quality gate pages --- sonar-server/src/main/webapp/javascripts/issues/app.js | 5 ++++- .../src/main/webapp/javascripts/quality-gate/layout.coffee | 3 +++ .../src/main/webapp/javascripts/quality-gate/layout.js | 3 ++- 3 files changed, 9 insertions(+), 2 deletions(-) diff --git a/sonar-server/src/main/webapp/javascripts/issues/app.js b/sonar-server/src/main/webapp/javascripts/issues/app.js index 84d6fbadfed..1467c52c0d6 100644 --- a/sonar-server/src/main/webapp/javascripts/issues/app.js +++ b/sonar-server/src/main/webapp/javascripts/issues/app.js @@ -49,7 +49,6 @@ requirejs( ReadOnlyFilterView, ActionPlanFilterView, RuleFilterView) { Handlebars.registerPartial('detailInnerTemplate', jQuery('#issue-detail-inner-template').html()); - var NavigatorApp = new Marionette.Application(); @@ -62,6 +61,10 @@ requirejs( }); + // Adjust details region height + jQuery('.navigator-details').css('bottom', jQuery('#footer').outerHeight()); + + NavigatorApp.addInitializer(function () { jQuery('html').addClass('navigator-page issues-page'); diff --git a/sonar-server/src/main/webapp/javascripts/quality-gate/layout.coffee b/sonar-server/src/main/webapp/javascripts/quality-gate/layout.coffee index 929d8cae128..bb3abdb19c1 100644 --- a/sonar-server/src/main/webapp/javascripts/quality-gate/layout.coffee +++ b/sonar-server/src/main/webapp/javascripts/quality-gate/layout.coffee @@ -29,3 +29,6 @@ define [ onRender: -> @updateLayout() + + # Adjust details region height + @$(@detailsRegion.el).css 'bottom', jQuery('#footer').outerHeight() diff --git a/sonar-server/src/main/webapp/javascripts/quality-gate/layout.js b/sonar-server/src/main/webapp/javascripts/quality-gate/layout.js index 20b544fabdd..b18e10cdccd 100644 --- a/sonar-server/src/main/webapp/javascripts/quality-gate/layout.js +++ b/sonar-server/src/main/webapp/javascripts/quality-gate/layout.js @@ -36,7 +36,8 @@ }; AppLayout.prototype.onRender = function() { - return this.updateLayout(); + this.updateLayout(); + return this.$(this.detailsRegion.el).css('bottom', jQuery('#footer').outerHeight()); }; return AppLayout; -- 2.39.5