From bee7f2531b170035f037365a474783dd3eb2b22b Mon Sep 17 00:00:00 2001 From: Jean-Philippe Lang Date: Wed, 28 Nov 2018 18:15:34 +0000 Subject: [PATCH] Missing validation for custom field formats based on RecordList (#29674). Patch by Alexander Achenbach. git-svn-id: http://svn.redmine.org/redmine/trunk@17645 e93f8b46-1217-0410-a6f0-8f06a7374b81 --- lib/redmine/field_format.rb | 10 ++++++++++ 1 file changed, 10 insertions(+) diff --git a/lib/redmine/field_format.rb b/lib/redmine/field_format.rb index 64fcdc6a4..3878b2dcb 100644 --- a/lib/redmine/field_format.rb +++ b/lib/redmine/field_format.rb @@ -740,6 +740,16 @@ module Redmine options end + def validate_custom_value(custom_value) + values = Array.wrap(custom_value.value).reject {|value| value.to_s == ''} + invalid_values = values - possible_custom_value_options(custom_value).map(&:last) + if invalid_values.any? + [::I18n.t('activerecord.errors.messages.inclusion')] + else + [] + end + end + def order_statement(custom_field) if target_class.respond_to?(:fields_for_order_statement) target_class.fields_for_order_statement(value_join_alias(custom_field)) -- 2.39.5